John Dennis added the comment:
I think your basic approach is fine and it's O.K. to break backwards
compatibility. I'm not sure anyone was using the httponly and secure flags in
the past because it was so broken, the logic was completely contradictory, so
backwards compatibility
John Dennis added the comment:
That's because #3073 never addressed the core problems, so yes I would expect
you would see failures. The point of the attached test is to illustrate the
deficiencies in Cookie.py, so apparently it's doing it's job :-)
FWIW, we wrote a new cookie
New submission from John Dennis:
There are multiple problems with Cookie.py. Some of the issues are covered in
http://bugs.python.org/issue3073 which is still open (after 4.5 years).
In all honesty the API and the implementation are not great perhaps the best
thing would be to remove it from
John Dennis added the comment:
The changesets are not in the release27-maint branch. sdist still does not
generate a correct archive for release, this is a very serious regression.
--
resolution: fixed ->
status: closed -> open
___
Python t
Changes by John Dennis :
--
nosy: +dmalcolm
___
Python tracker
<http://bugs.python.org/issue11104>
___
___
Python-bugs-list mailing list
Unsubscribe:
John Dennis added the comment:
No, I don't think I'm going to turn the tarball into a unit test, etc. I didn't
break the code but I did report the problem, researched the history, provided a
clear explanation, a reproducer and a patch to fix the problem. I think I'v
John Dennis added the comment:
$ tar xzf distutils_bug.tar.gz
$ cd distutils_bug
$ ./setup.py sdist
$ ./setup.py sdist
running sdist
running check
warning: sdist: manifest template 'MANIFEST.in' does not exist (using default
file list)
not writing to manually maintained man
Changes by John Dennis :
Added file: http://bugs.python.org/file20659/sdist_new
___
Python tracker
<http://bugs.python.org/issue11104>
___
___
Python-bugs-list mailin
Changes by John Dennis :
Added file: http://bugs.python.org/file20658/sdist.patch
___
Python tracker
<http://bugs.python.org/issue11104>
___
___
Python-bugs-list mailin
Changes by John Dennis :
Removed file: http://bugs.python.org/file20656/sdist_new
___
Python tracker
<http://bugs.python.org/issue11104>
___
___
Python-bugs-list mailin
Changes by John Dennis :
Removed file: http://bugs.python.org/file20655/sdist.patch
___
Python tracker
<http://bugs.python.org/issue11104>
___
___
Python-bugs-list mailin
Changes by John Dennis :
Added file: http://bugs.python.org/file20656/sdist_new
___
Python tracker
<http://bugs.python.org/issue11104>
___
___
Python-bugs-list mailin
Changes by John Dennis :
--
keywords: +patch
Added file: http://bugs.python.org/file20655/sdist.patch
___
Python tracker
<http://bugs.python.org/issue11
New submission from John Dennis :
The behaviour of sdist has changed dramatically in Python 2.7. Some projects
prefer to maintain their own manifest file instead of utilizing automatic
manifest generation from a template. The defined behaviour of sdist is to check
for the presence of both a
14 matches
Mail list logo
