[issue14632] Race condition in WatchedFileHandler leads to unhandled exception

2012-04-22 Thread JohnM
JohnM added the comment: Thank you both for looking at this. I've added an updated version of the patch that incorporates the last two suggestions that Charles-François made. I agree that this test may not be appropriate for the python test suite, due to the length and non-determinism o

[issue14632] Race condition in WatchedFileHandler leads to unhandled exception

2012-04-20 Thread JohnM
JohnM added the comment: I'm attaching a patch of an emit function implementation that reduces the number of stats and uses fstat were we can. Using fstat should also prevent any races between opening the new file and stating the path in the file system. Using this patch or something

[issue14632] Race condition in WatchedFileHandler leads to unhandled exception

2012-04-20 Thread JohnM
New submission from JohnM : The (very handy) logging.handlers.WatchedFileHandler appears to be susceptible to a race condition that causes occasional OSErrors during the normal course of operations: Traceback (most recent call last): File "test.py", line 58, in test_race l