Changes by Kasun Herath kasun...@gmail.com:
--
nosy: +kasun
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13559
___
___
Python-bugs-list mailing
Changes by Kasun Herath kasun...@gmail.com:
--
nosy: +kasun
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12537
___
___
Python-bugs-list mailing
Kasun Herath kasun...@gmail.com added the comment:
Thanks Antoine
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8809
___
___
Python-bugs-list
Kasun Herath kasun...@gmail.com added the comment:
I added a test to smtpnet and submitting a separate patch for it as my
test_smtpnet.py file was old and could have had conflicts.
I didn't use keys and certificates for the SSLContext as those would have to be
shipped with the source. Looking
Kasun Herath kasun...@gmail.com added the comment:
Yes, I would like to have a try at it
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8809
Kasun Herath kasun...@gmail.com added the comment:
david, I'm not much familiar with c. Still trying to figure out how to do it
--
status: pending - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11882
Kasun Herath kasun...@gmail.com added the comment:
I'm submitting another patch which includes a test in test_smtpnet. Would
appreciate further feedback.
--
Added file:
http://bugs.python.org/file21927/smtp_default_port_with_smtpnet_test.patch
Kasun Herath kasun...@gmail.com added the comment:
Thanks for the quick review. I'm submitting a new patch with changes suggested.
--
Added file: http://bugs.python.org/file21791/smtp_sslcontext_updated3.patch
___
Python tracker rep
Kasun Herath kasun...@gmail.com added the comment:
I did a quick patch based on the suggested solution.
(pitrou, thanks for adding to the nosy list or could have missed this)
--
keywords: +patch
Added file: http://bugs.python.org/file21794/smtplib_default_ports.patch
Kasun Herath kasun...@gmail.com added the comment:
Yes problem seems to be with time.mktime(). Here is my output,
calendar.timegm((2000, 1, 1, 0, 0, 0, -1, -1, -1))
946684800
x = imaplib.Internaldate2tuple(b'25 (INTERNALDATE 01-Jan-2000 00:00:00
+)')
x
time.struct_time(tm_year=2000
Kasun Herath kasun...@gmail.com added the comment:
I did another patch based on feedback given. A test for SMTP_SSL wasn't added;
will look into it later. Tab character that were present are removed. Also
SSLContext support was added to starttls() but it is slightly different from
Kasun Herath kasun...@gmail.com added the comment:
Yes this is a repeatable error. My timezone is GMT + 5:30.
The test fails even if the last element of 'calendar.timegm's tuple is changed
to 0 or 1 but pass if the function is changed as follows
print calendar.timegm((1999, 12, 31, 23, 30, 0
Kasun Herath kasun...@gmail.com added the comment:
I'm submitting a new patch with changes suggested by Terry. But I feel an
example of how to use a SSLContext inside the Docstring of SMTP_SSL constructor
is unnecessary since no smtp specific things are done to the passed SSLContext.
Any
New submission from Kasun Herath kasun...@gmail.com:
test_imaplib failed on x86 ubuntu machine with following error(s)
==
FAIL: test_Internaldate2tuple (test.test_imaplib.TestImaplib
Kasun Herath kasun...@gmail.com added the comment:
I did a patch that allows smtplib.SMTP_SSL constructor to accept an optional
SSLContext
--
keywords: +patch
nosy: +kasun
Added file: http://bugs.python.org/file21730/smtp_sslcontext.patch
___
Python
15 matches
Mail list logo
