[issue36074] Result of `asyncio.Server.sockets` after `Server.close()` is not clear

2019-02-22 Thread Kevin Mai-Hsuan Chia
Kevin Mai-Hsuan Chia added the comment: @mdk That's interesting. May I ask which one is the preferred behavior, `None` or `[]`? IMO both make sense, but `None` is more consistent with the behavior in previous versions. If it is the case, may I work on fixing this(`None` to `[]`)

[issue35826] Typo in example for async with statement with condition

2019-02-22 Thread Kevin Mai-Hsuan Chia
Kevin Mai-Hsuan Chia added the comment: Cool! Thanks for the reminder. -- stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/i

[issue36074] Result of `asyncio.Server.sockets` after `Server.close()` is not clear

2019-02-22 Thread Kevin Mai-Hsuan Chia
Kevin Mai-Hsuan Chia added the comment: Sure thing. Should it be discussed more detailed before the PR? If the document or the returned value is controversial, I would like to contribute if needed. Thanks :) -- ___ Python tracker <ht

[issue36074] Result of `asyncio.Server.sockets` after `Server.close()` is not clear

2019-02-22 Thread Kevin Mai-Hsuan Chia
Kevin Mai-Hsuan Chia added the comment: Excuse me, I tried 3.7.2 and 3.8.0a1+ with the following code and still failed. Could you help me to try this? or can you give me a pointer to the code returning `None`? Sorry for the inconvenience and thanks a lot. ``` import asyncio import platform

[issue36074] Result of `asyncio.Server.sockets` after `Server.close()` is not clear

2019-02-22 Thread Kevin Mai-Hsuan Chia
New submission from Kevin Mai-Hsuan Chia : It seems the result of `asyncio.Server.sockets` after `asyncio.Server.close()` is performed becomes `[]` instead of `None` since python 3.7. However, in the [document 3.7 and 3.8](https://docs.python.org/3.8/library/asyncio-eventloop.html

[issue35826] Typo in example for async with statement with condition

2019-01-25 Thread Kevin Mai-Hsuan Chia
Change by Kevin Mai-Hsuan Chia : -- keywords: +patch, patch, patch, patch pull_requests: +11511, 11512, 11513, 11514 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35826] Typo in example for async with statement with condition

2019-01-25 Thread Kevin Mai-Hsuan Chia
Change by Kevin Mai-Hsuan Chia : -- keywords: +patch, patch, patch pull_requests: +11511, 11512, 11514 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35826] Typo in example for async with statement with condition

2019-01-25 Thread Kevin Mai-Hsuan Chia
Change by Kevin Mai-Hsuan Chia : -- keywords: +patch pull_requests: +11511 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35826] Typo in example for async with statement with condition

2019-01-25 Thread Kevin Mai-Hsuan Chia
Change by Kevin Mai-Hsuan Chia : -- keywords: +patch, patch pull_requests: +11511, 11512 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35826] Typo in example for async with statement with condition

2019-01-25 Thread Kevin Mai-Hsuan Chia
Kevin Mai-Hsuan Chia added the comment: In the [example](https://docs.python.org/3.8/library/asyncio-sync.html#asyncio.Condition) of the equivalent code to the `async with` statement: ```python cond = asyncio.Condition() # ... later await lock.acquire() try: await cond.wait() finally

[issue35826] Typo in example for async with statement with condition

2019-01-25 Thread Kevin Mai-Hsuan Chia
New submission from Kevin Mai-Hsuan Chia : In the [example](https://docs.python.org/3.8/library/asyncio-sync.html#asyncio.Condition) of the equivalent code to the `async with statement`: ```python cond = asyncio.Condition() # ... later await lock.acquire() try: await cond.wait() finally