Changes by Mariatta Wijaya <mariatta.wij...@gmail.com>:
--
versions: +Python 2.7, Python 3.5, Python 3.6, Python 3.7
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Mariatta Wijaya added the comment:
How about
```
Because deep copy copies everything, it may copy too much, including the
administrative data structures.
```
?
--
nosy: +Mariatta
___
Python tracker <rep...@bugs.python.org>
<http://bugs.p
Changes by Mariatta Wijaya <mariatta.wij...@gmail.com>:
--
stage: -> needs patch
versions: -Python 3.3, Python 3.4
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Mariatta Wijaya added the comment:
Thanks for reviewing, Marco :)
Updated the patch.
--
Added file: http://bugs.python.org/file46597/issue29474py3-2.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Changes by Mariatta Wijaya <mariatta.wij...@gmail.com>:
--
stage: -> patch review
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Mariatta Wijaya added the comment:
And here is the patch that fixes the issue for python 2.7.
--
Added file: http://bugs.python.org/file46571/issue29474py2.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Mariatta Wijaya added the comment:
Attached is the patch to fix the grammatical errors for versions 3.5+
--
keywords: +patch
Added file: http://bugs.python.org/file46570/issue29474py3.patch
___
Python tracker <rep...@bugs.python.org>
Mariatta Wijaya added the comment:
You're right, Victor :)
The wording in 2.7 is a little bit different, but should be fixed too.
In 2.7:
These method have the same issues as the iterkeyrefs() and keyrefs() methods of
WeakKeyDictionary objects.
Assigning this to myself.
--
assignee
New submission from Mariatta Wijaya:
https://docs.python.org/3/library/weakref.html?highlight=weakref#weakref.WeakValueDictionary
There are grammatical errors in the sentence:
These method have the same issues as the and keyrefs() method of
WeakKeyDictionary objects.
Reported by Arthur
Mariatta Wijaya added the comment:
Thanks all :)
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Mariatta Wijaya added the comment:
Thanks, Marco, Jim, and Raymond :)
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Mariatta Wijaya added the comment:
Thanks, Raymond. I have an updated patch there the hypen and apostrophe are
removed.
--
versions: -Python 3.3, Python 3.4
Added file: http://bugs.python.org/file46552/issue29371v2.patch
___
Python tracker <
Changes by Mariatta Wijaya <mariatta.wij...@gmail.com>:
--
stage: -> patch review
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Mariatta Wijaya added the comment:
Hi everyone,
I made a patch to clarify that "or'ed" here really means "bitwise-OR'ed", and
made a reference to the section of the docs about bitwise OR.
Please review and let me know if this will work.
Thanks.
--
keywords: +pa
Mariatta Wijaya added the comment:
Martin,
I reviewed the patch (rm-finite.patch) and ran the tests. The patch no longer
applies cleanly to the default branch, but otherwise looks good.
Assigning this back to you as per Raymond's suggestion.
Thanks :)
--
assignee: Mariatta
Changes by Mariatta Wijaya <mariatta.wij...@gmail.com>:
--
resolution: -> fixed
stage: commit review -> resolved
___
Python tracker <rep...@bugs.python.org>
<http://bugs.
Mariatta Wijaya added the comment:
Thanks, Pekka, Eryk, Ammar, and Zachary :)
--
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.or
Mariatta Wijaya added the comment:
Thanks, Jim, Marco, and Raymond :)
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29381>
___
__
Mariatta Wijaya added the comment:
Thanks all for the feedback. I updated the patch.
Marco, IMO it's not necessary to update the PEP.
This section of the documentation serves as a tutorial for it, and the update
in this patch clarifies the situation.
--
Added file: http
Mariatta Wijaya added the comment:
Thanks for the feedback, Raymond. I adjusted my patch.
--
Added file: http://bugs.python.org/file46453/issue29381v2.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Mariatta Wijaya added the comment:
There are certain rules about the encoding declaration line.
It has to be the first line of the source code, or in the case that the file
starts with a unix "shebang" line, then the encoding declaration has to be on
the second line. In fact,
Mariatta Wijaya added the comment:
Attached patch adds stacklevel=2 to the deprecation warning.
--
keywords: +patch
nosy: +Mariatta
Added file: http://bugs.python.org/file46369/issue29314.patch
___
Python tracker <rep...@bugs.python.org>
Mariatta Wijaya added the comment:
Please let me know if I'm doing this right :) Thanks.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Mariatta Wijaya added the comment:
Patch for 2.7 branch.
The url will change from
https://hg.python.org/cpython/file/2.7/Lib/abc.py
into
https://github.com/python/cpython/blob/2.7/Lib/abc.py
--
Added file: http://bugs.python.org/file45906/issue28941v27.patch
Mariatta Wijaya added the comment:
Patch for 3.5 branch.
The url will change from
https://hg.python.org/cpython/file/3.5/Lib/abc.py
into
https://github.com/python/cpython/blob/3.5/Lib/abc.py
--
Added file: http://bugs.python.org/file45905/issue28941v35.patch
Mariatta Wijaya added the comment:
Attached is the patch that will work for 3.6 and 3.7 branches.
The url will be changed from
https://hg.python.org/cpython/file/3.6/Lib/abc.py
into
https://github.com/python/cpython/blob/3.6/Lib/abc.py for python version 3.6,
and
https://github.com/python
Mariatta Wijaya added the comment:
There's source code of the documentation itself
https://github.com/python/cpython/blob/master/Doc/library/abc.rst ) for
and source code of abc.py
https://github.com/python/cpython/blob/master/Lib/abc.py
Maybe I misunderstood, I figured issue #28929
Changes by Mariatta Wijaya <mariatta.wij...@gmail.com>:
--
nosy: +brett.cannon
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
New submission from Mariatta Wijaya:
Some Python docs include a link to the Source Code, for example:
https://docs.python.org/3.6/library/abc.html
Once the repo is moved to github, the link should probably be updated to point
to github:
https://github.com/python/cpython/blob/master/Lib/abc.py
Mariatta Wijaya added the comment:
Thanks, Brett.
Here's the patch that will work for the 2.7 branch.
--
Added file: http://bugs.python.org/file45854/issue28929-v27.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Mariatta Wijaya added the comment:
Hi,
This patch updates the Show Source link on the left of Docs menu and point it
to github.
I tested it locally, and works for versions >= 3.5
Please let me know if you have any feedback about this.
Thanks :)
Not sure if the older docs versions sho
Mariatta Wijaya added the comment:
Thanks, Brett :) I think it's easier to update the existing Source Link to
github. I'll work on a patch for this.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Mariatta Wijaya added the comment:
On the left menu, there's already a Show Source link.
Is the idea to replace that link to github.com/python/cpython/blob/ ?
Or, are you thinking about adding a new link under the main heading, similar to
**Source code:** :source:`Lib/abc.py
Mariatta Wijaya added the comment:
Hi, isn't it documented here?
https://docs.python.org/3.7/library/pickle.html#pickle.Pickler
"If a negative number is specified, HIGHEST_PROTOCOL is selected."
--
nosy: +Mariatta
___
Python tr
Mariatta Wijaya added the comment:
No prob. Thanks, Ned.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue28900>
___
___
Pyth
Mariatta Wijaya added the comment:
If it's ok, I'd like to work on a patch for this :)
--
nosy: +Mariatta
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Mariatta Wijaya added the comment:
Thanks, Berker :)
Updated.
--
Added file: http://bugs.python.org/file45772/issue28089v2.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Mariatta Wijaya added the comment:
I added the following to Doc/library/asyncio-protocol.rst
.. versionchanged:: 3.6.0
The socket option TCP_NODELAY is now set by default.
Let me know if this patch works.
--
keywords: +patch
Added file: http://bugs.python.org/file45770/issue28089
Mariatta Wijaya added the comment:
The change is that TCP_NODELAY option is set by default in 3.6. It was not the
case in 3.5.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Mariatta Wijaya added the comment:
Can anyone review this please? :)
Thanks.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Mariatta Wijaya added the comment:
sqlite 3.15.2 was just released.
I can prepare a patch if that's what we want.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Changes by Mariatta Wijaya <mariatta.wij...@gmail.com>:
--
components: +Installation, Windows, macOS
nosy: +ned.deily, paul.moore, ronaldoussoren, steve.dower, tim.golden, zach.ware
___
Python tracker <rep...@bugs.python.org>
<http://
Mariatta Wijaya added the comment:
Maybe you can post your code snippet and the error?
--
nosy: +Mariatta
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Mariatta Wijaya added the comment:
Hi, attached is the patch with docs for inspect.isasyncgen and
inspect.isasyncgenfunction
Please review, and let me know if this works.
Thanks :)
--
keywords: +patch
nosy: +Mariatta
Added file: http://bugs.python.org/file45636/issue28794.patch
Mariatta Wijaya added the comment:
Sounds good. Thanks, Raymond :)
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27825>
___
___
Mariatta Wijaya added the comment:
Thanks Raymond. The new set of examples is much better than the previous one.
+1
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Mariatta Wijaya added the comment:
Thanks, Raymond and Martin :)
Not sure what the procedure is for fixing this. Do I upload another patch?
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Mariatta Wijaya added the comment:
Works for me. Thanks :)
Maybe it's ok to close this ticket now?
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Mariatta Wijaya added the comment:
lol forgot to upload the patch. Here it is :)
--
Added file: http://bugs.python.org/file4/issue20572v2.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Mariatta Wijaya added the comment:
Thanks Martin :)
Alright, in v2 patch, I added stacklevel=2 parameter and test case for it.
Did not find any usage of the endtime parameter in cpython.
I'm also thinking that it can be removed in 3.7, considering it's been
documented as deprecated since 3.4
Mariatta Wijaya added the comment:
Thanks David :)
So, I found that isdst was never added as method signature in the docs, but it
is mentioned in the paragraph.
https://docs.python.org/3.7/library/email.util.html?#email.utils.localtime
The intention is still just to deprecate isdst argument
Mariatta Wijaya added the comment:
Thanks, Martin :)
Attached is the patch where deprecation warning is emitted if endtime argument
is passed.
Let me know if this works.
Thanks :)
--
keywords: +patch
Added file: http://bugs.python.org/file45532/issue20572.patch
Mariatta Wijaya added the comment:
Hi Alexander,
Is the idea here to raise deprecation warning starting in 3.6 and remove it by
3.8?
Thanks :)
--
nosy: +Mariatta
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Mariatta Wijaya added the comment:
1. So, is it ok to remove the endtime parameter now?
2. Can the attached downloadfile.htm be removed? It's a spam.
Thanks :)
--
nosy: +Mariatta
___
Python tracker <rep...@bugs.python.org>
<http://bugs.p
Mariatta Wijaya added the comment:
Thanks for the feedback, Raymond :)
I rephrased the docs like the following, what do you think?
Return zero-based index in the list of the first item whose value is *x*. It
is an error if there is no such item. Optional arguments ``start`` and ``end
Mariatta Wijaya added the comment:
Hi, here is the doc update, to be applied to 2.7 branch.
Please review. Thanks :)
--
keywords: +patch
nosy: +Mariatta
Added file: http://bugs.python.org/file45418/issue28615.patch
___
Python tracker <
Mariatta Wijaya added the comment:
Hi Ivan, I noticed you used two space indentation in your docs patch.
Can you use 3 spaces instead?
More guidelines here:
https://docs.python.org/devguide/documenting.html?#use-of-whitespace
Thanks :)
--
nosy: +Mariatta
Mariatta Wijaya added the comment:
Here is an updated patch.
Please review :)
Thanks.
--
Added file: http://bugs.python.org/file45376/issue28587v3.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Mariatta Wijaya added the comment:
Thanks for the feedback :) Makes sense, I'll work on another patch.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Mariatta Wijaya added the comment:
Hi, I updated the documentation explaining the path argument.
Let me know if this works. Thanks :)
--
keywords: +patch
nosy: +Mariatta
Added file: http://bugs.python.org/file45329/issue26980.patch
___
Python
Changes by Mariatta Wijaya <mariatta.wij...@gmail.com>:
Removed file: http://bugs.python.org/file45182/issue20847.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Mariatta Wijaya added the comment:
Hmm, I did not mean to replace the documentation example like that.
Here's another update.
--
Added file: http://bugs.python.org/file45314/issue28587.patch
___
Python tracker <rep...@bugs.python.org>
Mariatta Wijaya added the comment:
Attached is the patch to update the documentation.
Please review. Thanks :)
--
keywords: +patch
nosy: +Mariatta
Added file: http://bugs.python.org/file45313/issue28587.patch
___
Python tracker <
Mariatta Wijaya added the comment:
I added a note like this.
.. note::
Switching protocol should only be done when both protocols are
documented to support the switch.
Would this work? Would appreciate any feedback of how to properly document this
behavior.
Thanks.
--
Added
Mariatta Wijaya added the comment:
Thanks Serhiy,
I created these two tickets:
https://bugs.python.org/issue28534
https://bugs.python.org/issue28533
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Changes by Mariatta Wijaya <mariatta.wij...@gmail.com>:
--
components: +asyncio
nosy: +gvanrossum, yselivanov
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
New submission from Mariatta Wijaya:
Deprecation warning was added to asynchat in https://bugs.python.org/issue25002
asynchat is still used in several tests and should be replaced.
--
components: asyncio
messages: 279441
nosy: Mariatta, gvanrossum, yselivanov
priority: normal
severity
New submission from Mariatta Wijaya:
Deprecation warning was added to asyncore in https://bugs.python.org/issue25002
asyncore is still used in several tests and should be replaced.
--
messages: 279439
nosy: Mariatta
priority: normal
severity: normal
status: open
title: Replace asyncore
Mariatta Wijaya added the comment:
Sorry about this Serhiy. I can work on another patch based on your code snippet
later today.
Should I create a different ticket about replacing asyncore and asynchat?
--
___
Python tracker <rep...@bugs.python.
Mariatta Wijaya added the comment:
Hi,
Attached is the patch that adds pending deprecation warnings to asyncore and
asynchat. Please review. Thanks :)
--
keywords: +patch
nosy: +Mariatta
Added file: http://bugs.python.org/file45210/issue25002.patch
Mariatta Wijaya added the comment:
Thanks, Stéphane :)
Perhaps this can be updated into patch review stage?
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Mariatta Wijaya added the comment:
> [2] library/venv.rst:27: default role used
> 1 problem with severity 2 found.
I made a patch to address it. Please review. Thanks :)
--
keywords: +patch
nosy: +Mariatta
Added file: http://bugs.python.org/file45196/issue25152
Mariatta Wijaya added the comment:
Hi,
I added to asyncio logging doc that the log file should point to a file on
local filesystem.
Please review. Thanks :)
--
keywords: +patch
nosy: +Mariatta
Added file: http://bugs.python.org/file45182/issue20847.patch
Mariatta Wijaya added the comment:
Thanks David. I uploaded patch to address your concern with the docs.
Can you please check?
Serhiy, with regards to applying docs and test to 3.5, does that require a
different patch than what I have?
Thanks.
--
Added file: http://bugs.python.org
Changes by Mariatta Wijaya <mariatta.wij...@gmail.com>:
Added file: http://bugs.python.org/file45175/issue18219v8.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Mariatta Wijaya added the comment:
Inada-san, Victor, thank you.
Here is the updated patch.
--
Added file: http://bugs.python.org/file45174/issue18219v7.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Changes by Mariatta Wijaya <mariatta.wij...@gmail.com>:
Added file: http://bugs.python.org/file45173/issue18219v6.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Changes by Mariatta Wijaya <mariatta.wij...@gmail.com>:
Added file: http://bugs.python.org/file45172/issue18219v5.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Changes by Mariatta Wijaya <mariatta.wij...@gmail.com>:
Added file: http://bugs.python.org/file45170/issue18219v4.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Changes by Mariatta Wijaya <mariatta.wij...@gmail.com>:
Added file: http://bugs.python.org/file45169/issue18219v3.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Mariatta Wijaya added the comment:
Thanks, Hugh.
Please check the updated patch :)
--
Added file: http://bugs.python.org/file45168/issue18219v2.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Mariatta Wijaya added the comment:
Thanks Hugh,
Are you thinking of something like the following?
class DictWriter:
def __init__(self, f, fieldnames, restval="", extrasaction="raise",
dialect="excel", *args, **kwds):
self._fieldnames
Mariatta Wijaya added the comment:
Hello, please review my patch.
I used set subtraction to calculate wrong_fields, added more test cases, and
clarify documentation with regards to extrasaction parameter.
Please let me know if this works.
Thanks :)
--
nosy: +Mariatta
Added file
Mariatta Wijaya added the comment:
Hi.
imp.get_magic() is deprecated since 3.4, see the documentation here
https://docs.python.org/3/library/imp.html?highlight=get_magic#imp.get_magic
You should use importlib.util.MAGIC_NUMBER instead.
Please try it.
Thanks.
--
nosy: +Mariatta
Mariatta Wijaya added the comment:
Hello,
I updated the documentation with an example of how to override ArgumentParser
class. Hope this is a clearer than before.
Please review.
Thanks :)
--
keywords: +patch
nosy: +Mariatta
Added file: http://bugs.python.org/file45121/issue28455
Mariatta Wijaya added the comment:
Updated patch based on feedback.
Steven, I removed the example of median_grouped using Fractions.
Would you be able to suggest better examples to be added in the docs?
I also noticed that there are more examples of median_grouped in the paragraph
below
Mariatta Wijaya added the comment:
The documentation seems to indicate that chrome MacOS is supposed to work in
2.7, which makes this a bug.
https://docs.python.org/2.7/library/webbrowser.html?highlight=webbrowser#module-webbrowser
But... it could also be a documentation bug
Mariatta Wijaya added the comment:
Hi, I updated the openssl version from 1.0.2h to 1.0.2j in build-installer.py
Please let me know if this works.
Thanks :)
--
keywords: +patch
nosy: +Mariatta
Added file: http://bugs.python.org/file45054/issue28248.patch
Mariatta Wijaya added the comment:
Hello,
Attached is the patch for updating sqlite version to 3.14.2.
Please review, and let me know if this works.
Thanks :)
--
keywords: +patch
nosy: +Mariatta
Added file: http://bugs.python.org/file45053/issue28208.patch
New submission from Mariatta Wijaya:
Thanks scop.
The patch looks good to me, and it can be applied cleanly to 3.5, 3.6, and
default branches.
I did find more occurrences of unnecessary semicolons, for example (not a
complete list)
https://github.com/python/cpython/blob/master/Lib/smtpd.py
Mariatta Wijaya added the comment:
Hi Jaysinh,
I reviewed your changes, they look good to me.
I can't approve it, so it would still be good for a core dev here to take
another pass.
Thanks :)
--
___
Python tracker <rep...@bugs.python.org>
Mariatta Wijaya added the comment:
Hi, here is the patch. I followed Raymond's suggestion to use 'vulnerable' or
'safe' instead of the original 'True' or 'False'.
Please check it out.
Thanks :)
--
keywords: +patch
Added file: http://bugs.python.org/file44994/issue18789.patch
Mariatta Wijaya added the comment:
Hi, I added the paragraph explaining how to change the log level for asyncio.
Please check it out.
Thanks :)
--
keywords: +patch
nosy: +Mariatta
Added file: http://bugs.python.org/file44992/issue21443.patch
Changes by Mariatta Wijaya <mariatta.wij...@gmail.com>:
--
nosy: +Mariatta
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue28206>
___
Mariatta Wijaya added the comment:
Hi Josh,
I think python ideas mailing list might have been a better venue for this.
https://mail.python.org/mailman/listinfo/python-ideas
--
nosy: +Mariatta
___
Python tracker <rep...@bugs.python.org>
Mariatta Wijaya added the comment:
I'll work on this :)
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue18789>
___
___
Pyth
Changes by Mariatta Wijaya <mariatta.wij...@gmail.com>:
--
nosy: +Mariatta
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue18789>
___
Mariatta Wijaya added the comment:
Hi Joshua,
Seems like your latest patch doesn't apply cleanly to the default branch.
Can you rebase and upload a new patch?
Thanks.
--
nosy: +Mariatta
___
Python tracker <rep...@bugs.python.org>
Mariatta Wijaya added the comment:
Seems like this can be closed.
Thanks.
--
nosy: +Mariatta
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Mariatta Wijaya added the comment:
Updated the docs and updated the example codes as well.
Please review :)
--
keywords: +patch
nosy: +Mariatta
Added file: http://bugs.python.org/file44979/issue27825.patch
___
Python tracker <rep...@bugs.python.
1001 - 1100 of 1148 matches
Mail list logo
