Pablo Galindo Salgado added the comment:
I'm reverting #30855 for the time being given our buildbot policy.
--
___
Python tracker
<https://bugs.python.org/is
Change by Pablo Galindo Salgado :
--
pull_requests: +29190
pull_request: https://github.com/python/cpython/pull/31011
___
Python tracker
<https://bugs.python.org/issue46
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +29189
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/31010
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
>> Pablo, is there any possibility that the internal REPL parser could be
>> wrapped, exposed to Python, and called with fake stdin/out/err objects?
I would really advise against this. Unfortunately, the state of affairs is that
the REP
Pablo Galindo Salgado added the comment:
This seems coherent with https://www.python.org/dev/peps/pep-3131/ to me. The
parser ensures all identifiers are converted into the normal form NFKC while
parsing; comparison of identifiers is based on NFKC
Pablo Galindo Salgado added the comment:
Seems that this PR is causing some segfaults. See
https://github.com/python/cpython/pull/30855#issuecomment-1024658459
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue46
Pablo Galindo Salgado added the comment:
New changeset c7af838805ddf52320bce3d5978bfdd37eed1b3a by Pablo Galindo Salgado
in branch '3.10':
[3.10] bpo-46502: Remove "How do I tell incomplete input" from FAQ (GH-30925)
(GH-30933)
https://github.com/p
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset dafada393f9a790461430e2493ea1379e938b51a by Pablo Galindo Salgado
in branch '3.9':
[3.9] bpo-46502: Remove "How do I tell incomplete input" from FAQ (GH-30925)
(GH-30934)
https://github.com/p
Change by Pablo Galindo Salgado :
--
pull_requests: +29113
pull_request: https://github.com/python/cpython/pull/30934
___
Python tracker
<https://bugs.python.org/issue46
Change by Pablo Galindo Salgado :
--
pull_requests: +29112
pull_request: https://github.com/python/cpython/pull/30933
___
Python tracker
<https://bugs.python.org/issue46
Pablo Galindo Salgado added the comment:
New changeset f0a648152f2d8011f47cc49873438ebaf01d3f82 by Mateusz Łoskot in
branch 'main':
bpo-46502: Remove "How do I tell incomplete input" from FAQ (GH-30925)
https://github.com/python/cpython/commit/f0a648152f2d8011f47c
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
pull_requests: +29078
pull_request: https://github.com/python/cpython/pull/30899
___
Python tracker
<https://bugs.python.org/issue46
Pablo Galindo Salgado added the comment:
New changeset 3fc8b74ace033a17346a992f661928ba619e61e8 by Pablo Galindo Salgado
in branch '3.10':
[3.10] bpo-46091: Correctly calculate indentation levels for whitespace lines
with continuation characters (GH-30130). (GH-30898)
https://
Change by Pablo Galindo Salgado :
--
pull_requests: +29077
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/30898
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset a0efc0c1960e2c49e0092694d9839270914c by Pablo Galindo Salgado
in branch 'main':
bpo-46091: Correctly calculate indentation levels for whitespace lines with
continuation characters (GH-30130)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
The test needs to build a lot of C extensions with different parsers, and that
compilation is what takes most of the time.
I don't think we should skip these tests by default on Windows, as it gives us
valuable information (that the parser fea
Pablo Galindo Salgado added the comment:
> because my requirement is to detect if a code can be incomplete Python code,
> without ever compiling it.
AS I mentioned in other issues, unfortunately the new parser doesn't allow to
do this as the old one does, because how it works.
Pablo Galindo Salgado added the comment:
> Can you help me figure out why this bug doesn't show up in the normal Python
> REPL?
That's because the normal Python REPL works very differently when in
interactive mode. This is because the tokenizer in interactive mode is coupl
Pablo Galindo Salgado added the comment:
> wontfix would really suck, because that would mean every REPL written with
> the `code` module will be broken, even IPython:
I understand, but I don't see a way to fix this without reverting the change to
detect unclosed triple quites
Pablo Galindo Salgado added the comment:
This is due to the fact that the new parser doesn't detect the syntax error of
"abc def" after it has parsed the full text, but before that happens, the
tokenizer has detected a problem (the ''' is not closed) and this is
Change by Pablo Galindo Salgado :
--
nosy: -pablogsal
___
Python tracker
<https://bugs.python.org/issue46521>
___
___
Python-bugs-list mailing list
Unsubscribe:
Pablo Galindo Salgado added the comment:
> However, I'm very keen to learn what is an alternative solution then to
> distinguish hard invalid from incomplete input. IOW, what would be the new
> way of achieving what's described in the old FAQ?
Unfortunately, there is no
Pablo Galindo Salgado added the comment:
Indeed, these new errors are due to the new parser. Unfortunately, the new
parser doesn't allow to check against incomplete input the way the old one did
so that piece of documentation is unfortunately outdated.
We should remove it to avoid fu
Pablo Galindo Salgado added the comment:
Thanks for the quick fix, Eric!
--
___
Python tracker
<https://bugs.python.org/issue46503>
___
___
Python-bugs-list m
Pablo Galindo Salgado added the comment:
No problem! What do I need to update? The script to add the binaries to the
release page?
--
___
Python tracker
<https://bugs.python.org/issue33
Pablo Galindo Salgado added the comment:
This issue is not related to the parser, so I am unmarking it.
--
components: -Parser
___
Python tracker
<https://bugs.python.org/issue46
Change by Pablo Galindo Salgado :
--
nosy: -pablogsal
___
Python tracker
<https://bugs.python.org/issue35095>
___
___
Python-bugs-list mailing list
Unsubscribe:
Pablo Galindo Salgado added the comment:
Adding Eric as this seems to be in the f-string parser.
--
___
Python tracker
<https://bugs.python.org/issue46
Change by Pablo Galindo Salgado :
--
nosy: +eric.smith
___
Python tracker
<https://bugs.python.org/issue46503>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Pablo Galindo Salgado :
--
resolution: -> not a bug
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue46485>
___
___
Pyth
Pablo Galindo Salgado added the comment:
It means the same as if there is alternatives: if it fails to parse then it
will immediately fail. We place them in rules like this in preparation for
extension or in case there are invalid_* rules in the same set (which doesn't
appear in the gr
Pablo Galindo Salgado added the comment:
New changeset 633db1c4eb863a1340e45c353e36f2f8dcf5945c by Pablo Galindo Salgado
in branch '3.10':
[3.10] bpo-46240: Correct the error for unclosed parentheses when the tokenizer
is not finished (GH-30378). (GH-30819)
https://github.com/pyth
Change by Pablo Galindo Salgado :
--
pull_requests: +29005
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/30819
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
Thanks for the bug report, Guido!
Everything should be ok now
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 1fb1f5d8bd084c20f0a5fde547b563c08d103f09 by Miss Islington (bot)
in branch '3.10':
[3.10] bpo-46339: Fix crash in the parser when computing error text for
multi-line f-strings (GH-30529) (GH-30542)
https://github.com/pyth
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +28909
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/30718
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset 353674f289076eecf848d7a26871cce529b89a98 by Miss Islington (bot)
in branch '3.9':
bpo-46231: Remove invalid_* rules preceded by more tokens from the grammar docs
(GH-30341) (GH-30392)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset 8c2fd09f365e082cfceb29afdf38953cdd670946 by Pablo Galindo Salgado
in branch 'main':
bpo-46339: Include clarification on assert in
'get_error_line_from_tokenizer_buffers' (#30545)
https://github.com/p
Pablo Galindo Salgado added the comment:
> Could it wait for 3.10.2 already scheduled for four weeks from now?
I don't feel comfortable leaving a ton of Cython functions leaking memory
constantly on many function calls. According to
https://github.com/MagicStack/asyncpg/issues/874
Pablo Galindo Salgado added the comment:
Apparently, this is causing adyncpg to leak megabytes in seconds
--
___
Python tracker
<https://bugs.python.org/issue46
Pablo Galindo Salgado added the comment:
Turns out this leak affects CYthon quite a lot:
https://github.com/cython/cython/blob/29ad96444b8b1a4f05a6ac2328fde01de4782691/Cython/Utility/ObjectHandling.c#L2139-L2155
This seems to imply that every function call using __Pyx_PyCFunction_FastCall
Change by Pablo Galindo Salgado :
--
pull_requests: +28743
pull_request: https://github.com/python/cpython/pull/30545
___
Python tracker
<https://bugs.python.org/issue46
Pablo Galindo Salgado added the comment:
Backporting this to 3.9 is a bit more challenging and more changes are
required, so I am not backporting for 3.9 to avoid unintended side effects.
--
___
Python tracker
<https://bugs.python.org/issue46
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
pull_requests: +28741
pull_request: https://github.com/python/cpython/pull/30543
___
Python tracker
<https://bugs.python.org/issue46
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +28730
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/30529
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
The reason is that the line numbers are now correctly identified, and that
causes existing code to not work correctly :(
--
___
Python tracker
<https://bugs.python.org/issue46
Pablo Galindo Salgado added the comment:
Seems that the regression is caused by this commit:
6fa8b2ceee38187b0ae96aee12fe4f0a5c8a2ce7 is the first bad commit
commit 6fa8b2ceee38187b0ae96aee12fe4f0a5c8a2ce7
Author: Pablo Galindo Salgado
Date: Sat Jan 8 00:23:40 2022 +
bpo-46237
Pablo Galindo Salgado added the comment:
Unfortunately the release of 3.11.0a4 is already underway and we are waiting
for Steve's windows binaries, so this will need to wait for alpha 5
--
___
Python tracker
<https://bugs.python.org/is
Pablo Galindo Salgado added the comment:
I created a PEP to formally propose the change:
https://www.python.org/dev/peps/pep-0679/
--
___
Python tracker
<https://bugs.python.org/issue46
Pablo Galindo Salgado added the comment:
Seems that this PR has broken the refleak buildbots:
https://buildbot.python.org/all/#/builders/320/builds/269/
https://buildbot.python.org/all/#/builders/384/builds/255
According to our buildbot policy, if this is not fixed in 24h we will need to
Pablo Galindo Salgado added the comment:
New changeset 6fa8b2ceee38187b0ae96aee12fe4f0a5c8a2ce7 by Pablo Galindo Salgado
in branch 'main':
bpo-46237: Fix the line number of tokenizer errors inside f-strings (GH-30463)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
I did some testing on my own using a code generator and a bunch of weird cases
and I am confident this works. I am going to include this in the next alpha but
will wait for your validation for some days before merging the backports
Change by Pablo Galindo Salgado :
--
priority: release blocker ->
___
Python tracker
<https://bugs.python.org/issue46006>
___
___
Python-bugs-list mai
Pablo Galindo Salgado added the comment:
Please Andre and Terry, test this fix as much as you want. I am quite sure is
correct, but it is far-reaching so I want to make sure every situation that we
can think of is correct (and remains correct
Pablo Galindo Salgado added the comment:
I would say yes, for consistency. It doesn't have any effects on user code that
I am aware
--
___
Python tracker
<https://bugs.python.org/is
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +28666
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/30463
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
This also affects 3.9 I imagine, no?
--
___
Python tracker
<https://bugs.python.org/issue46237>
___
___
Python-bug
Change by Pablo Galindo Salgado :
--
nosy: +eric.smith
___
Python tracker
<https://bugs.python.org/issue46237>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Pablo Galindo Salgado :
--
superseder: -> [subinterpreters] Make the PyGILState API compatible with
subinterpreters
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
Yeah, this is indeed related/duplicate of bpo-15751
--
___
Python tracker
<https://bugs.python.org/issue46295>
___
___
Change by Pablo Galindo Salgado :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
I think A is the best option
--
___
Python tracker
<https://bugs.python.org/issue46289>
___
___
Python-bugs-list mailin
New submission from Pablo Galindo Salgado :
Reproducer:
Code for native_ext.cpp:
#define PY_SSIZE_T_CLEAN
#include
#include
#include
#include
#pragma GCC push_options
#pragma GCC optimize ("O0")
PyObject*
run_simple(PyObject*, PyObject*)
{
PyGILState_ST
Change by Pablo Galindo Salgado :
--
nosy: +BTaskaya
___
Python tracker
<https://bugs.python.org/issue46289>
___
___
Python-bugs-list mailing list
Unsubscribe:
Pablo Galindo Salgado added the comment:
> Anyway, (if I'm right,) this makes my points that a) there are false
> positives, and b) we should have separate issues for each actual problem.
Sorry Eric, I failed to clarify my comment: you are absolutely right in your
analysis. I wa
Pablo Galindo Salgado added the comment:
> I don't see how this could be an uninitialized read, although I'm willing to
> be wrong.
It can be uninitialized if the parenstack[nested_depth] value is itself
initialized, which can happen if the memory block pointed by parensta
Pablo Galindo Salgado added the comment:
> Is this under control, or do you still need help with some part?
As Christian mentions, we still have the test_embed issue
--
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
> Based on the research of the result, I tried to design a tool to
> automatically detect and repair vulnerabilities in CPython and make this tool
> available. See:
You mention here that your tool automatically "repairs" the code.
Change by Pablo Galindo Salgado :
--
title: backslash creating statement out of nothing -> Tokenizer module does not
handle backslash characters correctly
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
This doesn't look like a bug to me and is documented behavior:
https://docs.python.org/3/reference/datamodel.html#object.__del__
Check this paragraph:
Warning Due to the precarious circumstances under which __del__() methods are
invoked, excep
Pablo Galindo Salgado added the comment:
Unfortunately the buildbots are still red:
https://buildbot.python.org/all/#/builders/483/builds/1416/steps/5/logs/stdio
https://buildbot.python.org/all/#/builders/172/builds/1102
One is the test_embed problem with frozen modules
Change by Pablo Galindo Salgado :
--
nosy: +eric.smith
___
Python tracker
<https://bugs.python.org/issue46275>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Pablo Galindo Salgado :
--
nosy: -pablogsal
___
Python tracker
<https://bugs.python.org/issue46274>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Pablo Galindo Salgado :
--
nosy: -pablogsal
___
Python tracker
<https://bugs.python.org/issue45665>
___
___
Python-bugs-list mailing list
Unsubscribe:
Pablo Galindo Salgado added the comment:
Gentle ping, as the next alpha will be release soon
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue45
Change by Pablo Galindo Salgado :
--
priority: release blocker ->
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.11
___
Python tracker
<https://bugs.python
Pablo Galindo Salgado added the comment:
I am removing the "release blocker" tag.
Simon, thanks a lot for both PRs. I am sorry that we needed to revert your
original work, but unfortunately it was blocking a release and we are forced to
act in this case. PLease, work together with
Pablo Galindo Salgado added the comment:
New changeset dd50316e458d7c3284f8948b0606d8aa91ab855d by Simon McVittie in
branch 'main':
bpo-43137: Revert "webbrowser: Don't run gvfs-open on GNOME" (GH-30417)
https://github.com/python/cpython/commit/dd50316e458d7c3
Pablo Galindo Salgado added the comment:
>> I am not a regular CPython developer, so I don't have a good way to assess
>> which reviewers speak for the project and which reviewers are only offering
>> a personal opinion.
In this webpage (bpo) core developers have a l
Pablo Galindo Salgado added the comment:
I am quite sure this is due to PR 23316
--
___
Python tracker
<https://bugs.python.org/issue46236>
___
___
Python-bug
Change by Pablo Galindo Salgado :
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue46236>
___
___
Python-bugs-list mailing list
Unsub
Pablo Galindo Salgado added the comment:
Yeah, the docs mention explicitly that is a dictionary or NULL.
--
priority: normal -> release blocker
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
Is there anything left here?
--
priority: release blocker ->
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
There is also this other builder:
https://buildbot.python.org/all/#/builders/172/builds/1093
failing what what seems is a freeze problem:
- 'use_frozen_modules': 1,
+ 'use_frozen_modules': -1,
?+
Pablo Galindo Salgado added the comment:
If this is not fixed by this week, I will be forced to revert the PR
--
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
Can this be closed?
--
___
Python tracker
<https://bugs.python.org/issue40222>
___
___
Python-bugs-list mailin
New submission from Pablo Galindo Salgado :
Seems that the FreeBSD buildbots cannot compile Python 3.11 anymore:
LD_LIBRARY_PATH=/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build CC='cc
-pthread' LDSHARED='cc -pthread -shared' OPT='-g -O0 -Wall'
Pablo Galindo Salgado added the comment:
I did a run of pyperformance manually forcing setuptools<60.0 and another with
setuptools>=60.0 I can reproduce the timing difference.
I assume we can therefore close this issue and maybe open another one thinking
about how to deal wi
Change by Pablo Galindo Salgado :
--
nosy: +eric.smith
___
Python tracker
<https://bugs.python.org/issue46260>
___
___
Python-bugs-list mailing list
Unsubscribe:
Pablo Galindo Salgado added the comment:
New changeset 7d7817cf0f826e566d8370a0e974bbfed6611d91 by Kumar Aditya in
branch 'main':
bpo-20369: concurrent.futures.wait() now deduplicates futures given a…
(GH-30168)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
Thanks Andre for the report!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset e09d94a140a5f6903017da9b6ac752ba041d69da by Pablo Galindo Salgado
in branch 'main':
bpo-46231: Remove invalid_* rules preceded by more tokens from the grammar docs
(GH-30341)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset 70f415fb8b632247e28d87998642317ca7a652ae by Pablo Galindo Salgado
in branch 'main':
bpo-46240: Correct the error for unclosed parentheses when the tokenizer is not
finished (GH-30378)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset a09062c267a94200ad299f779429fea1b571ee35 by Erlend Egeberg
Aasland in branch 'main':
bpo-44092: Move What's New entry to where it belongs (GH-30381)
https://github.com/python/cpython/commit/a09062c267a94200ad299f779
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +28588
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/30378
___
Python tracker
<https://bugs.python.org/issu
101 - 200 of 1001 matches
Mail list logo