[issue5801] spurious empty lines in wsgiref code

Pablo Torres Navarrete tn.pa...@gmail.com added the comment: I cleaned the rest of the module by shortening lines that are too long, removing useless blocks of empty lines and adding whitespace around operators and after commas. Nothing in the programming logic was changed. -- Added

[issue5801] spurious empty lines in wsgiref code

Pablo Torres Navarrete tn.pa...@gmail.com added the comment: The patch applies to rev 73702 of the py3k branch. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5801

[issue5801] spurious empty lines in wsgiref code

Pablo Torres Navarrete tn.pa...@gmail.com added the comment: Oops, forgot to add the .diff extension so web browsers don't get confused. Their contents are the same though. -- keywords: +patch Added file: http://bugs.python.org/file14411/wsgiref-patch.diff

[issue6372] Make all switches keyword-only

New submission from Pablo Torres Navarrete tn.pa...@gmail.com: I propose that all formal parameters that really act as options/switches be made keyword-only. Examples of switches are all flags, timeouts, 'verbose' bools, maximums and minimums, etc. This stresses the difference between needed

[issue6372] Make all switches keyword-only

Pablo Torres Navarrete tn.pa...@gmail.com added the comment: OK, bad idea it is then. Thank you for your time. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6372

[issue5801] spurious empty lines in wsgiref code

Pablo Torres Navarrete tn.pa...@gmail.com added the comment: I added the patch for #5800 -- Added file: http://bugs.python.org/file14321/patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5801

[issue5800] make wsgiref.headers.Headers accept empty constructor

Pablo Torres Navarrete tn.pa...@gmail.com added the comment: Patch attached. While I was at it, I also removed stupid whitespace and generally made the module more PEP8-compliant. -- nosy: +ptn Added file: http://bugs.python.org/file14311/patch

[issue5801] spurious empty lines in wsgiref code

Pablo Torres Navarrete tn.pa...@gmail.com added the comment: The patch for issue #5800 solves this. -- nosy: +ptn ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5801

[issue6064] Add daemon argument to threading.Thread constructor

Pablo Torres Navarrete tn.pa...@gmail.com added the comment: +1, but I can't apply the patch cleanly: $ patch -p0 threading.diff patching file Doc/library/threading.rst Hunk #1 succeeded at 198 (offset -17 lines). Hunk #2 succeeded at 211 (offset -17 lines). Hunk #3 succeeded at 230 (offset

[issue1685] linecache .updatecache fails on utf8 encoded files

Pablo Torres Navarrete tn.pa...@gmail.com added the comment: Cannot reproduce on Ubuntu 9.04 with py3k at revision 73267: $ ./python Python 3.1rc1+ (py3k:73267, Jun 7 2009, 14:45:03) [GCC 4.3.3] on linux2 Type help, copyright, credits or license for more information. import pdb [49404 refs

[issue6064] Add daemon argument to threading.Thread constructor

Pablo Torres Navarrete tn.pa...@gmail.com added the comment: Nope. Our working copies seem to be different. I'm uploading mine, which I just update to revision 73468. Please diff yours against that and against HEAD too, just in case. Hunk 2 on threading.py fails because your attributes use

[issue6064] Add daemon argument to threading.Thread constructor

Pablo Torres Navarrete tn.pa...@gmail.com added the comment: I'm diffing against the 2.7 branch, I guess your comes from the 3.2? *forehead meets desktop* Patch applies cleanly and all tests pass. I used it for a while and everything seemed OK. After someone else tests, I say we go

[issue6064] Add daemon argument to threading.Thread constructor

Pablo Torres Navarrete tn.pa...@gmail.com added the comment: +1 on making it a keyword-only argument. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6064

[issue5800] make wsgiref.headers.Headers accept empty constructor

Pablo Torres Navarrete tn.pa...@gmail.com added the comment: Added a pointer from #5801 to here. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5800

[issue5313] multiprocessing.process using os.close(sys.stdin.fileno) instead of sys.stdin.close()

Pablo Torres Navarrete tn.pa...@gmail.com added the comment: Wouldn't it be more pythonic to just try sys.stdin.fileno() and catch the AtributeError too? def _bootstrap(self): try: os.close(sys.stdin.fileno()) except AtributeError

[issue1184112] Missing trailing newline with comment raises SyntaxError

Pablo Torres Navarrete tn.pa...@gmail.com added the comment: Confirmed on versions 2.6.2, 3.0.1 and 3.1rc1. On the three of them, I tried this: import parser test = 'def foo():\n\tpass\n\n# comment' parser.suite(test) Traceback (most recent call last): File stdin, line 1, in module

[issue1184112] Missing trailing newline with comment raises SyntaxError

Changes by Pablo Torres Navarrete tn.pa...@gmail.com: -- versions: +Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1184112

[issue6173] Minor typo in socket.py

Changes by Pablo Torres Navarrete tn.pa...@gmail.com: -- versions: +Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6173 ___ ___ Python

[issue6173] Minor typo in socket.py

New submission from Pablo Torres Navarrete tn.pa...@gmail.com: Index: socket.py === --- socket.py (revision 73134) +++ socket.py (working copy) @@ -16,7 +16,7 @@ gethostbyname() -- map a hostname to its IP number gethostbyaddr