[issue46303] _Py_stat and _Py_wstat using incorrect type for status argument

2022-01-11 Thread Paul Campbell
Paul Campbell added the comment: Victor: The changes in the main branch gets me past this issue without having to make additional changes. -- ___ Python tracker <https://bugs.python.org/issue46

[issue46303] _Py_stat and _Py_wstat using incorrect type for status argument

2022-01-11 Thread Paul Campbell
Paul Campbell added the comment: > In Python, we are trying to provide a same C API on all platforms. If "struct > stat" is no longer considered as portable, IMO we should attempt to avoid it, > at least in the public C API. Microsoft provides stat and struct sta

[issue46303] _Py_stat and _Py_wstat using incorrect type for status argument

2022-01-11 Thread Paul Campbell
Paul Campbell added the comment: Hi Victor, I was trying to compile with clang on Windows 10. I will try to pull your 3.11 changes and test. Sorry to cause so much churn. It looked to me like a simple issue that was missed, probably because whatever was trying to compile was not normally

[issue46303] _Py_stat and _Py_wstat using incorrect type for status argument

2022-01-11 Thread Paul Campbell
Paul Campbell added the comment: I was trying to build python core (-DMS_WINDOWS -DPy_BUILD_CORE). I was using clang, which I think is unsupported looking at Windows doc. After looking at the issue though, it seemed that it was just some slight mistake which is why I filed the bug. clang

[issue46303] _Py_stat and _Py_wstat using incorrect type for status argument

2022-01-07 Thread Paul Campbell
Change by Paul Campbell : -- title: _Py_stat using incorrect type for status argument -> _Py_stat and _Py_wstat using incorrect type for status argument ___ Python tracker <https://bugs.python.org/issu

[issue46303] _Py_stat using incorrect type for status argument

2022-01-07 Thread Paul Campbell
Change by Paul Campbell : -- keywords: +patch pull_requests: +28681 stage: -> patch review pull_request: https://github.com/python/cpython/pull/30478 ___ Python tracker <https://bugs.python.org/issu

[issue46303] _Py_stat using incorrect type for status argument

2022-01-07 Thread Paul Campbell
Change by Paul Campbell : -- components: +Build, Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware type: -> compile error ___ Python tracker <https://bugs.python.org/issu

[issue46303] _Py_stat using incorrect type for status argument

2022-01-07 Thread Paul Campbell
New submission from Paul Campbell : While attempting to embed the full cpython source in my application, I found that during compilation on Windows, there was a compilation issue due to struct stat not being defined. Taking a look at the file cpython/fileutils.h, it seems that the type