Peter Edwards added the comment:
On Wed, 14 Aug 2019 at 23:13, STINNER Victor wrote:
>
> STINNER Victor added the comment:
>
> About PR 13649, I'm not sure that _PyThread_preferred_stacksize() is still
> relevant, since my change fixed test_faulthandler test_register_chain(
Peter Edwards added the comment:
On Wed, 14 Aug 2019 at 22:32, STINNER Victor wrote:
>
> We are talking abou the faulthandler_user() function of
> Modules/faulthandler.c. It is implemented in pure C, it doesn't allocate
> memory on the heap, it uses a very small set of func
Peter Edwards added the comment:
On Wed, 14 Aug 2019 at 22:34, STINNER Victor wrote:
>
> ...I'm not sure that we can fix bpo-37851 in Python 3.7.
That's totally reasonable, sure.
--
___
Python tracker
<https://bugs.python.org/i
Peter Edwards added the comment:
On Wed, 14 Aug 2019 at 14:46, STINNER Victor wrote:
>
> STINNER Victor added the comment:
>
> "On a 64-bit system, consuming 8M of address space is a drop in the ocean."
>
> Let me disagree here. Python always alloca
Peter Edwards added the comment:
The patch I originally proposed here (
https://bugs.python.org/file48353/sigaltstack-stacksize.patch ) is a pretty
minimal fix that uses the pthread stack size where available, with a
hard-coded lower bound of 1M. @Victor : if you want a minimal diff, I can
Peter Edwards added the comment:
Hi Victor, thanks for the comments. Responses inline below.
On Wed, 14 Aug 2019 at 12:25, STINNER Victor wrote:
>
> STINNER Victor added the comment:
>
> I dislike PR 13649 because it touch the thread module, only to fix a
> faulthandler
Peter Edwards added the comment:
This is likely a duplicate of issue 21131
--
nosy: +peadar
___
Python tracker
<https://bugs.python.org/issue35484>
___
___
Pytho
Change by Peter Edwards :
--
pull_requests: +13543
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/13649
___
Python tracker
<https://bugs.python.org/issu
Peter Edwards added the comment:
Ok - let me submit a pull request with your suggestions
On Tue, 28 May 2019 at 13:08, STINNER Victor wrote:
>
> STINNER Victor added the comment:
>
> +pthread_attr_t attrs;
> +pthread_attr_init();
> +(void)pthread_attr_ge
Peter Edwards added the comment:
Hi - we ran into what looks like exactly this issue on an x86_64 sporadically,
and tracked down the root cause.
When faulthandler.c uses sigaltstack(2), the stack size is set up with a buffer
of size SIGSTKSZ. That is, sadly, only 8k.
When a signal
10 matches
Mail list logo
