Changes by Senthil Kumaran <sent...@uthcode.com>:
--
pull_requests: +1193
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27973>
___
Changes by Senthil Kumaran <sent...@uthcode.com>:
--
pull_requests: +1190
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29976>
___
Changes by Senthil Kumaran <sent...@uthcode.com>:
--
nosy: +orsenthil
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29353>
___
_
Senthil Kumaran added the comment:
Looking forward to this.
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.or
Changes by Senthil Kumaran <sent...@uthcode.com>:
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
type: enhancement -> behavior
___
Python tracker <rep...@bugs.python.org>
<http:/
Senthil Kumaran added the comment:
New changeset 0f9ceaf322cc9358373167115fd4c21ab2d9ad50 by Senthil Kumaran in
branch '3.5':
bpo-29725: DOC: add text for arraysize in sqlite3.Cursor (#947) (#986)
https://github.com/python/cpython/commit/0f9ceaf322cc9358373167115fd4c21ab2d9ad50
Senthil Kumaran added the comment:
New changeset cb1e002c07622e027e80a3843d27a623d1617430 by Senthil Kumaran in
branch '3.6':
bpo-29725: DOC: add text for arraysize in sqlite3.Cursor (#947) (#985)
https://github.com/python/cpython/commit/cb1e002c07622e027e80a3843d27a623d1617430
Changes by Senthil Kumaran <sent...@uthcode.com>:
--
pull_requests: +1158
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29725>
___
Changes by Senthil Kumaran <sent...@uthcode.com>:
--
pull_requests: +1157
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29725>
___
Senthil Kumaran added the comment:
New changeset 02e12138000da834f23719521a011fa93763384d by Senthil Kumaran
(csabella) in branch 'master':
bpo-29725: DOC: add text for arraysize in sqlite3.Cursor (#947)
https://github.com/python/cpython/commit/02e12138000da834f23719521a011fa93763384d
Senthil Kumaran added the comment:
Thanks for working on this.
row_factory seems to be another parameter that can be set in the Cursor object.
https://github.com/python/cpython/blob/master/Modules/_sqlite/cursor.c#L65
This can addressed in a different issue/ pr.
--
nosy: +orsenthil
Senthil Kumaran added the comment:
https://github.com/python/cpython/pull/984 proposes a change. I'll need some
reviews on this changed text.
Note: I am aware that there is an issue (long pending), which suggests deal
away with these schemes at the top. If we get to that immediately, I
New submission from Senthil Kumaran:
urllib.parse has the following information in this module.
```
# A classification of schemes ('' means apply by default)
uses_relative = ['ftp', 'http', 'gopher', 'nntp', 'imap',
'wais', 'file', 'https', 'shttp', 'mms
Senthil Kumaran added the comment:
I have to admit, I did not see some of the negative votes in this ticket before
merging the patch. If your is opposition is strong, please comment and suggest
a better improvement over the patch. thank you
Senthil Kumaran added the comment:
I reviewed in the pull request. I agree that the wording was slightly better
than the original.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Changes by Senthil Kumaran <sent...@uthcode.com>:
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: -> behavior
___
Python tracker <rep...@bugs.python.org>
<http:/
Senthil Kumaran added the comment:
New changeset a71a3ad54d14483cfaebd8e0fb96c97c798d9e32 by Senthil Kumaran in
branch '3.6':
bpo-26947: DOC: clarify wording on hashable in glossary (#948) (#957)
https://github.com/python/cpython/commit/a71a3ad54d14483cfaebd8e0fb96c97c798d9e32
Senthil Kumaran added the comment:
New changeset 51fc7e3d6a29de7b3142e51f8caf4d31f7ac72a0 by Senthil Kumaran in
branch '3.5':
bpo-26947: DOC: clarify wording on hashable in glossary (#948) (#958)
https://github.com/python/cpython/commit/51fc7e3d6a29de7b3142e51f8caf4d31f7ac72a0
Changes by Senthil Kumaran <sent...@uthcode.com>:
--
pull_requests: +1140
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26947>
___
Changes by Senthil Kumaran <sent...@uthcode.com>:
--
pull_requests: +1139
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26947>
___
Senthil Kumaran added the comment:
New changeset 64c887ab3a400cf91bde4f0c5ef69eacc88bc5e1 by Senthil Kumaran
(csabella) in branch 'master':
bpo-26947: DOC: clarify wording on hashable in glossary (#948)
https://github.com/python/cpython/commit/64c887ab3a400cf91bde4f0c5ef69eacc88bc5e1
Changes by Senthil Kumaran <sent...@uthcode.com>:
--
resolution: -> fixed
stage: backport needed -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bu
Senthil Kumaran added the comment:
New changeset 3ceca68741f8a2d3a4436b6d54eae76aa5bcc4c5 by Senthil Kumaran in
branch '2.7':
bpo-29917: DOC: Remove link from PyMethodDef (#890) (#896)
https://github.com/python/cpython/commit/3ceca68741f8a2d3a4436b6d54eae76aa5bcc4c5
Senthil Kumaran added the comment:
New changeset d1dbbaab01354f01faa696aff1280db3b349e354 by Senthil Kumaran in
branch '3.5':
bpo-29917: DOC: Remove link from PyMethodDef (#890) (#895)
https://github.com/python/cpython/commit/d1dbbaab01354f01faa696aff1280db3b349e354
Senthil Kumaran added the comment:
New changeset da6ad2f780d187fbfdea330d1037766ae7bdb778 by Senthil Kumaran in
branch '3.6':
bpo-29917: DOC: Remove link from PyMethodDef (#890) (#894)
https://github.com/python/cpython/commit/da6ad2f780d187fbfdea330d1037766ae7bdb778
Changes by Senthil Kumaran <sent...@uthcode.com>:
--
pull_requests: +799
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29917>
___
Changes by Senthil Kumaran <sent...@uthcode.com>:
--
pull_requests: +798
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29917>
___
Changes by Senthil Kumaran <sent...@uthcode.com>:
--
pull_requests: +797
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29917>
___
Changes by Senthil Kumaran <sent...@uthcode.com>:
--
stage: needs patch -> backport needed
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Senthil Kumaran added the comment:
New changeset c3c7ef088583cc12bd218138036d1edb6de9c63f by Senthil Kumaran
(csabella) in branch 'master':
bpo-29917: DOC: Remove link from PyMethodDef (#890)
https://github.com/python/cpython/commit/c3c7ef088583cc12bd218138036d1edb6de9c63f
--
nosy
Changes by Senthil Kumaran <sent...@uthcode.com>:
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bu
Senthil Kumaran added the comment:
The .github directory needs to stay and is being used for other purposes (like
providing contributing guidelines
(https://github.com/blog/1184-contributing-guidelines)).
The old pull request template has already been deleted:
https://github.com/python
Changes by Senthil Kumaran <sent...@uthcode.com>:
--
nosy: +lemburg
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29555>
___
_
New submission from Senthil Kumaran:
In the attached patch, I updated the copyright year to 2017 at places it was
mentioned until 2016.
There was a suggestion that we remove the copyright line of Python Software
Foundation from module headers since the code is already covered 1) by top
level
Senthil Kumaran added the comment:
@martin, the patch looks good to me. Please go ahead and commit this.
--
nosy: +orsenthil
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Senthil Kumaran added the comment:
Thank you for the review, Julian.
Addressed it and the change is committed at changeset b5125e971fdd
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tra
Senthil Kumaran added the comment:
Hi Julian, here is the patch that addresses you comments. Thanks
--
Added file: http://bugs.python.org/file46430/issue29182-patch3.diff
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Senthil Kumaran added the comment:
Thank you, Mariatta.
--
nosy: +orsenthil
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Senthil Kumaran added the comment:
Here is the updated patch that addresses the comment.
--
Added file: http://bugs.python.org/file46401/issue29182_docs_fix.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Senthil Kumaran added the comment:
The original problem here was retrieving files failed (hung) when it was tried
via context-manager
1. For e.g after "reverting" the changes, if you use the original file without
the context manager, it will succeed.
fobj = urllib.request.ur
Senthil Kumaran added the comment:
I spent time digging for a proper fix for this issue.
I've come to a conclusion that this commit,
https://hg.python.org/cpython/rev/44d02a5d59fb (10 May 2016) in 2.7.12, was a
mistake and needs to be reverted.
The reason this change was made was apparently
Senthil Kumaran added the comment:
@Martin, that's a sound advice. I agree to it. I'll change it to a note
(instead of warning) which mentions about certificate verification since 2.7.9.
--
___
Python tracker <rep...@bugs.python.org>
Senthil Kumaran added the comment:
The patch looks good to me, and can committed. Thanks!
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
New submission from Senthil Kumaran:
It started as a discussion in this issue:
http://bugs.python.org/issue22417#msg284604
I think, that warning can be removed. If no one has any objections, I will
commit this attached patch.
--
assignee: orsenthil
components: Documentation
files
Senthil Kumaran added the comment:
I am going to vote for "not a bug" here. From the context is it understood that
the `ContextBaseClass` is to be provided by the user.
> Existing context managers that already have a base class can be extended by
> using ContextDecorator
Senthil Kumaran added the comment:
Just an update. We missed the last 2.7.13 release train. Sorry for that.
It's worth to fix this bug still ASAP. It's intricately related to some other
bugs like (issue25458, issue26960). I got to this and realized the dependency
and other bugs. All those
Changes by Senthil Kumaran <sent...@uthcode.com>:
--
assignee: -> orsenthil
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Senthil Kumaran added the comment:
@Sohaib,
Thanks for the ping. Yeah, I will act on it.
Your analysis in msg276795 seems plausible, On the patch itself, I will try to
reproduce this and see if I can avoid introducing this clear_buffer function.
If no other go, then it should just
Changes by Senthil Kumaran <sent...@uthcode.com>:
--
nosy: +orsenthil
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue28432>
___
_
Changes by Senthil Kumaran <sent...@uthcode.com>:
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: -> behavior
___
Python tracker <rep...@bugs.python.org>
<http:/
Senthil Kumaran added the comment:
The patch looks good to me. Thank you, Xiang. I will apply it.
--
nosy: +orsenthil
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Senthil Kumaran added the comment:
Applying on 2.7 seems alright. Bug fix.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Senthil Kumaran added the comment:
I wanted to ask, Do you know why bazel does that?
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Senthil Kumaran added the comment:
Linking __init__.py to /dev/null is very odd. Do you know bazel does that?
--
nosy: +orsenthil
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Senthil Kumaran added the comment:
The patch looks good to me.
(The test coverage for chrome browser can be improved. But that seems a like a
different change than the current one).
--
assignee: -> orsenthil
nosy: +orsenthil
versions: +Python 3.7 -Python 3.4, Python
Senthil Kumaran added the comment:
Using logging, instead of sys.stderr would be a welcome change in this module.
--
keywords: +easy, needs review
nosy: +orsenthil
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Senthil Kumaran added the comment:
Hi Sohaib,
I will get the proper fix for this issue.
A comment on the patch. Changing the API to `def open(self, fullurl, data=None,
ftp_retrieve=False):` just breaks the abstraction of the open method and may
not be the way to go for this. Any changes
Senthil Kumaran added the comment:
@Martin, I weight in 'curl's behavior for de-facto things that differ slightly
from standards. It's simply what folks have gotten used to, and sometimes
expect.
@Raymond, unit-tests will be a good addition too
Changes by Senthil Kumaran <sent...@uthcode.com>:
--
nosy: +orsenthil
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue24363>
___
_
Senthil Kumaran added the comment:
Yes, urllib.request.urlopen needs an update too. It takes those certfile and
keyfile and usage of those could be deprecated in favor of context.
--
___
Python tracker <rep...@bugs.python.org>
Changes by Senthil Kumaran <sent...@uthcode.com>:
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
versions: +Python 3.6
___
Python tracker <rep...@bugs.python.org>
<http://bu
Senthil Kumaran added the comment:
This patch fixes this. It makes the documentation consistent with the code.
--
keywords: +patch
nosy: +orsenthil
Added file: http://bugs.python.org/file44479/103351.patch
___
Python tracker <rep...@bugs.python.
Changes by Senthil Kumaran <sent...@uthcode.com>:
--
nosy: +orsenthil
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue28022>
___
_
Changes by Senthil Kumaran <sent...@uthcode.com>:
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bu
Senthil Kumaran added the comment:
Here is an updated patch that increases the coverage to 100% and has some pep8
style improvements.
shannon-2:issue11551 senthil$ ./python.exe -m test.regrtest test_dummy_thread
Run tests sequentially
0:00:00 [1/1] test_dummy_thread
1 test OK.
Total duration
Senthil Kumaran added the comment:
I've updated the patch to use unittest.mock, the removed the old style way of
exercising it.
--
nosy: +orsenthil
Added file: http://bugs.python.org/file44429/issue11551.patch
___
Python tracker <
Senthil Kumaran added the comment:
Hi Brett, I backported only portions of the patch some this issue that were
applicable to the issue that I was fixing. I will backport remain portions so
that everything will be consistent now.
--
Added file: http://bugs.python.org/file44427
Senthil Kumaran added the comment:
The documentation changes made as part of this issue were applicable to 3.5
branch too.
I had to touch the docs in this area as part of issue20842, and ended up with
two patches one for 3.5 and another 3.6.
I think, it is a good idea to backport the change
Senthil Kumaran added the comment:
Change committed.
- 3.5 * 103098:ecbad01262c8
- default * 103099:ee58ece83391
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker <rep...@bugs.pytho
Senthil Kumaran added the comment:
This is 3.3 version of patch attached.
--
Added file: http://bugs.python.org/file44383/issue20842-3.3-v5.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Senthil Kumaran added the comment:
For 3.5 version of patch, we have bring in some additional changes from
issue26896 which properly clarified finder from importer. These changes are not
required in the default branch.
--
___
Python tracker <
Senthil Kumaran added the comment:
I agree with the comment made by Oren. Not all instances of finder should be
referenced as generic finder. Some classes and functions are are still PEP 302
specific finder.
In the commit, 3987667bf98f Nick Coghlan modified the following functions to to
use
Senthil Kumaran added the comment:
Thank you and great work everyone involved with this change. Regards.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Senthil Kumaran added the comment:
(Assigning this to Martin)
I really like this patch, and I support that we land this before the feature
freeze of 3.6.
As along as the API interface to users is simple, the changes internal to
_send_output should not be a concern. Yeah, I agree
Senthil Kumaran added the comment:
Hi Hans-Peter,
In 3.3 (95b09ccc8a3e) and 3.4 (3c19023c9fec) the change completely removes any
variant of http_proxy if REQUEST_METHOD is set. The only way to have http
based proxy in cgi environment by using ProxyHandler method. This is solution
introduced
Changes by Senthil Kumaran <sent...@uthcode.com>:
--
stage: patch review -> resolved
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Senthil Kumaran added the comment:
This is also committed in 2.7 branch in ba915d561667.
This is committed in all active versions(2.7, 3.5, 3.6) and also versions which
receive security updates (3.3 and 3.4).
This issue is resolved. Thank you for the patch, Rémi.
(In msg271688, I pondered
Senthil Kumaran added the comment:
For 3.3, 3.4 it seems reasonable to backport changes from issue26804 and then
apply this patch. I will do this today.
--
assignee: -> orsenthil
___
Python tracker <rep...@bugs.python.org>
<http://bug
Senthil Kumaran added the comment:
The patch looks good to me. I am checking this in.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Senthil Kumaran added the comment:
Thanks for this patch. The CVE number assigned to python - CVE-2016-1000110.
There is redundancy in /Doc/library/urllib.request.rst change where the same
paragraph is repeated twice. See if you can have it at a single location as a
`Note` and reference
Senthil Kumaran added the comment:
I think that we use encourage everyone to use the higher level functions like
urlparse() or urlsplit() and then get the .port from the named tuple result.
Two things to do.
1. Update that Note the documentation which states a false statement that those
Senthil Kumaran added the comment:
I am unsure of the change too. I am willing to close this report as .port
attribute is already documented.
--
resolution: -> not a bug
stage: needs patch -> resolved
status: pending -> closed
___
Pytho
Senthil Kumaran added the comment:
Please use stackoverflow.com or python-tu...@python.org for assistance. This
site is for developers of python.
--
nosy: +orsenthil
resolution: -> rejected
stage: -> resolved
status: open -> closed
_
Senthil Kumaran added the comment:
Thanks. Addressed the review comments. Committing this.
--
Added file: http://bugs.python.org/file43679/issue27476-v2.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Senthil Kumaran added the comment:
Here is the patch.
--
keywords: +patch
Added file: http://bugs.python.org/file43677/issue2476.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Senthil Kumaran added the comment:
Context: https://mail.python.org/pipermail/core-workflow/2016-July/000616.html
https://github.com/python/cpython/pull/41
--
versions: +Python 3.6
___
Python tracker <rep...@bugs.python.org>
<http://bugs.p
New submission from Senthil Kumaran:
PULL_REQUEST_TEMPLATE will discourage pull requests in github repo and will
instead point to python hg repo and dev guide. This will be removed after the
hg to git migration is complete.
--
assignee: orsenthil
messages: 270124
nosy: orsenthil
Senthil Kumaran added the comment:
This is fixed in all versions of python. Thanks for the review.
--
resolution: -> fixed
status: open -> closed
type: -> behavior
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Senthil Kumaran added the comment:
Fixed the redundant import as pointed by Evelyn on IRC.
--
Added file: http://bugs.python.org/file43666/issue27466-v2.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Senthil Kumaran added the comment:
Here is the patch that fixes this issue. Patch includes unittests and NEWS
entry.
--
assignee: -> orsenthil
keywords: +patch
stage: -> patch review
Added file: http://bugs.python.org/file43659/issue27466
Senthil Kumaran added the comment:
Evelyn,
Thanks for digging in.
The code for time2netscape has been in the current form since it was originally
introduced in 2004. If this is a bug, then it has been present since the
introduction of the module. If anyone is using this module
Senthil Kumaran added the comment:
Марк, it's documented now. Thank you for the patch.
--
nosy: +orsenthil
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http
Senthil Kumaran added the comment:
Hi Adam,
Thanks for the patch. I reviewed it. It's a good change. As you mentioned in
the comments, making both HTML and Text formatter behave consistently and skip,
underscores, callables, _callables will be a good idea. Please include change.
Also
Senthil Kumaran added the comment:
Unfortunately no. 3.4 is only in security fixes mode and this doesn't qualify
as a security fix. Usually the bug fixes and feature additions are incentives
for developers to upgrade their python codebase
Senthil Kumaran added the comment:
Addressed the problem with the previous commit.
--
resolution: -> fixed
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Senthil Kumaran added the comment:
Thanks for your contribution, Jelle.
--
nosy: +orsenthil
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: -> behavior
___
Python tracker <rep...@bugs.py
Senthil Kumaran added the comment:
Thanks for the patch, Jelle Zijlstra.
We don't have warnings in Doc/faq/programming.rst now, and this issue was
specific to fix the doctests for it. I find it complete. Closing this issue.
--
nosy: +orsenthil
resolution: -> fixed
st
Senthil Kumaran added the comment:
Thanks for your contribution. It's now documented.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Senthil Kumaran added the comment:
Thanks for the explanation, Dave. Completely agree with those points. Let's go
ahead with the latest patch.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Senthil Kumaran added the comment:
Thanks Angad and Anatoly for the patches discussions.
Thank you Berker for review.
Made the changes in all active versions of python. Let this issue reset in
peace.
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -&g
301 - 400 of 2017 matches
Mail list logo
