Senthil Kumaran added the comment:
My worry is not about the timing. I can add it immediately, but are we
convinced on having a new argument (API Change) for 3.4.2 ?
--
___
Python tracker
<http://bugs.python.org/issue22
Senthil Kumaran added the comment:
Except for the minor comments made by Antoine in the review, the patch looks
good to go.
--
___
Python tracker
<http://bugs.python.org/issue22
New submission from Senthil Kumaran:
While working on issue22366, I found a tricky bit of code in:
https://hg.python.org/cpython/file/ca0aa0d89273/Lib/http/client.py#l1295
https://hg.python.org/cpython/rev/1a945fb875bf/
The statement is
if not self._context.check_hostname and self
Senthil Kumaran added the comment:
Committed this in 3.5. (Since this is adding an new argument, it should not be
backported to 3.4).
Thank you!
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: -Python 3.4
_
Senthil Kumaran added the comment:
I addressed Berker Peksag's review comments on Jame's patch, tested the local
building of docs, verified the content and looks.
Committed this in 2.7, 3.4 and 3.5.
Thank you all!
--
assignee: docs@python -> orsenthil
resolution: -
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue22417>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Thanks, fixed in all versions applicable for security release.
--
assignee: -> orsenthil
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python
Changes by Senthil Kumaran :
--
versions: +Python 2.7, Python 3.3, Python 3.4, Python 3.5
___
Python tracker
<http://bugs.python.org/issue22419>
___
___
Python-bug
Senthil Kumaran added the comment:
The patch looks good. Yeah, wsgiref server will see the benefiting of rejecting
long url with 414.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue22
Senthil Kumaran added the comment:
Reviewed the patch. Looks good to go.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue22420>
___
___
Pytho
Senthil Kumaran added the comment:
2.7 was not affected and it was binding to localhost properly.
Since it is security related issue, I have fixed it in 3.3 as well.
Fix is now present in 3.4 and 3.5
--
resolution: -> fixed
stage: patch review -> resolved
status: open -&g
Senthil Kumaran added the comment:
sys.platform is darwin since OS X 10.5. I am not sure when it's value was
'mac', So effectively the host was localhost on mac systems.
Directly setting the host value to localhost on all platforms may be right
thing to do. Here is a p
Senthil Kumaran added the comment:
The localhost breaking on your linux system might be due to improper /etc/hosts
or is localhost pointing to an ipv6 address?
That said, I think it is okay to rely on 127.0.0.1 as host for running pydoc
server. I am unsure why the initial check was done only
Changes by Senthil Kumaran :
--
assignee: -> alex
___
Python tracker
<http://bugs.python.org/issue22366>
___
___
Python-bugs-list mailing list
Unsubscrib
Senthil Kumaran added the comment:
With the final review comment addressed, this could go in. Since you have
commit rights, please feel free to commit it. (else, please assign this to me
and I will commit and follow up with the buildbots
Senthil Kumaran added the comment:
It was reproducible on my local machine too. Those errors were present and
somehow escaped me. Thanks for raising this.
Fixed these and tested in my local machine and test_urllib2_localnet was
successful.
--
assignee: -> orsenthil
resolut
Senthil Kumaran added the comment:
Interesting. I had not noticed these with my run on Mac and neither did
Buildbots report. Looks like explicit closing of wfile do_GET method can be
cause of tis problem.
--
___
Python tracker
<h
Senthil Kumaran added the comment:
This is fixed in all active versions (2.7.8+, 3.4.2? and 3.5). Thanks all!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.o
Changes by Senthil Kumaran :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue22165>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: -> resolved
___
Python tracker
<http://bugs.python.org/issue22165>
___
___
Python-bugs-list
Changes by Senthil Kumaran :
--
status: closed -> open
___
Python tracker
<http://bugs.python.org/issue22165>
___
___
Python-bugs-list mailing list
Unsubscrib
Senthil Kumaran added the comment:
Looks like we hit with an encoding issue, which is due to way os.fsdecode() and
os.listdir() decode the filenames.
>>> support.TESTFN_UNDECODABLE
b'@test_99678_tmp\xe7w\xf0'
>>> dir_list = os.listdir(self.tempdir)
>>>
Senthil Kumaran added the comment:
Attached patch looks good to me. If an unittest can be provided for this
situation in test_httpservers.py it will be comprehensive and will be good to
go.
--
nosy: +orsenthil
___
Python tracker
<h
Senthil Kumaran added the comment:
@Serhiy, yeah, I think the patch attached to issue22165 will fix one of the
buildbot failures. For this issue. there was another one with Broken PIPE which
may need a different fix.
--
___
Python tracker
<h
Senthil Kumaran added the comment:
I have backed out my changes. The buildbot failures were new as I could not
reproduce them in my local test on Mac. I will run the buildbot suite on branch
and fix it before committing.
--
___
Python tracker
Senthil Kumaran added the comment:
This bug has been open for a while and I had lost sight of it. Upon prompted
recently, I dug bit
into history and could think of a good solution.
A brief history.
1. The bug "maximum recursion depth exceeded" when doing Basic Authentication
was
Senthil Kumaran added the comment:
I have addressed the mistake where req.host is self.get_names() was done
instead of req.host in self.get_names() in the first commit as it was an
obvious problem.
I will come up with patch/solution addressing the other behavior mentioned in
this report
Senthil Kumaran added the comment:
Thanks for the report. Point 2 is definitely a bug (and an overlook by me), I
will fix it.
I think, the url[:2] == '//' check was present for ftp case which supported
file:// protocol. I can't see a clear requirement to change here.
Th
Senthil Kumaran added the comment:
The patch was good and captured what was required. I made some minor
modifications and committed it in 3.4 and 3.5
Thanks for the patch, Vajrasky Kok.
--
assignee: -> orsenthil
nosy: +orsenthil
resolution: -> fixed
stage: needs patch ->
New submission from Senthil Kumaran:
issue15588 brought the topic that quopri has ancient methods like encodestring,
decodestring, which a user might expect that will send a string, but instead
has to send bytes.
This needs to be cleaned up.
a) function name should be accurate and represent
Senthil Kumaran added the comment:
Thanks for the review, Mark. Addressed that and committed the changes in
changeset 606a18938476 (3.4)
changeset b4130b2f7748 (3.5)
--
nosy: +orsenthil
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +P
Senthil Kumaran added the comment:
Fixed in all active branches.
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
versions: +Python 2.7
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
Attached patch adds the index entry.
--
keywords: +patch
nosy: +orsenthil
Added file: http://bugs.python.org/file35703/20091.patch
___
Python tracker
<http://bugs.python.org/issue20
Senthil Kumaran added the comment:
I believe, repr() is the correct call here. You should know the proper end of
line characters like \n, \r\n which were sent in the request while debugging. A
pretty print here, while look good, might remove that capability and thus may
not add any value in
Senthil Kumaran added the comment:
Fixed these. Thanks for the report.
--
nosy: +orsenthil
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
The first patch was correct and consistent with how other Exceptions were
closing the socket. Fixed this and thanks for the patch.
--
assignee: -> orsenthil
nosy: +orsenthil
resolution: -> fixed
stage: -> resolved
status: open -> clo
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue21648>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
I could not reproduce this in 3.4 / 3.5
[localhost 21643]$ ./python.exe Tools/scripts/pyvenv --upgrade
usage: venv [-h] [--system-site-packages] [--symlinks | --copies] [--clear]
[--upgrade] [--without-pip]
ENV_DIR [ENV_DIR ...]
venv
Senthil Kumaran added the comment:
Fixed the follwing changesets.
2.7 b8655be522d4
3.4 e6dce5611dae
3.5 50c9df76bb77
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: -> behavior
___
Python tracker
<http://
Senthil Kumaran added the comment:
I see that all the patches are correct. My only worry is since 3.1,3.2 and 3.3
are in security fix only mode, we may not apply it to those.
2.7, 3.4 and 3.5 ones are okay.
--
nosy: +orsenthil
___
Python tracker
Changes by Senthil Kumaran :
--
versions: +Python 2.7
___
Python tracker
<http://bugs.python.org/issue7776>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
@dstufft - should you commit it in 3.4 branch (since the change is already in
3.5) and then wait for larry's approval or rejection?
--
___
Python tracker
<http://bugs.python.org/i
Senthil Kumaran added the comment:
I prefer we update the ensurepip in 3.4.1
That will be helpful too since 3.5 has the fix.
--
___
Python tracker
<http://bugs.python.org/issue7
Senthil Kumaran added the comment:
This is fixed in 2.7 as well here (changeset 568041fd8090).
We shall close this ticket after @dstufft pulls in the updated pip for 3.4
Thanks!
--
priority: high -> release blocker
versions: +Python 2.7
___
Pyt
Senthil Kumaran added the comment:
I am glad that issues with 3rdparty libs which dependent on the previous wrong
behavior has been resolved.
As indicated previously, I think, it makes sense to have this in 2.7 as well. I
created a patch and tested it 2.7 and it is all good. I plan to commit
Senthil Kumaran added the comment:
This is fixed in 3.4 and 3.5. I will backport to 2.7 ( I think, it is worth it).
--
resolution: -> fixed
stage: patch review -> resolved
___
Python tracker
<http://bugs.python.org/i
Changes by Senthil Kumaran :
--
nosy: -orsenthil
___
Python tracker
<http://bugs.python.org/issue2052>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
For this bug, I think, section 2.2.4 and section 2.2.5 can be moved to section
13 and inserted between section 13.1 and 13.2 as it seem to be fit in naturally
there.
--
___
Python tracker
<http://bugs.python.
Changes by Senthil Kumaran :
--
nosy: -orsenthil
___
Python tracker
<http://bugs.python.org/issue18967>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
I agree. Having tell on a file descriptor of a URL request is not going to be
of help. You can easily write to a local file and use all the local file
features, if it is things like .tell is desired.
--
resolution: -> not a bug
stage: needs pa
Senthil Kumaran added the comment:
Christian's patch is good.It helps in setting the socket.makefile file
descriptor to a well behaving well file close wrapper and thus will help us
prevent some tricky fd close issues.
I added tests for coverage to ensure that we are asserting the typ
Senthil Kumaran added the comment:
Thanks for the bug report. The documentation has been fixed in the active
versions.
--
versions: +Python 3.4, Python 3.5 -Python 2.7
___
Python tracker
<http://bugs.python.org/issue21
Senthil Kumaran added the comment:
Yes. And thanks for the patch. I applied a slight variation of it.
--
___
Python tracker
<http://bugs.python.org/issue21
Senthil Kumaran added the comment:
Éric, no preference. I thought this was explicit and if you would like to
change it back to /3/, fine, no problem with me. Just think of any redirection
issue, if we may accidentally stumble upon, that'
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
versions: +Python 3.5 -Python 2.7, Python 3.3
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
Christian , with respect to patch, I agree with the logic (using something
similar to #18879). Does all current unittests succeed with this? (I suspect
not) A unittest for coverage would be helpful.
--
___
Python
New submission from Senthil Kumaran:
It is undocumented. While fixing a doc issue issue18229 for http.server I
noticed that I referenced that function and when I looked up for the
documentation, it was lacking.
--
assignee: orsenthil
messages: 216494
nosy: orsenthil
priority: normal
Senthil Kumaran added the comment:
> I'll make another wireshark recording to get more details for me to analyze.
Thank you! That will be useful. Please test it against 3.x version as it has
seen cleanups recently.
--
___
Python tracke
Senthil Kumaran added the comment:
Ned Deily had done the correct analysis in the msg214947 and has this question
-
> I don't know whether the file descriptor read is expected to be meaningful
> for urllib2/urllib.request.
I can see that this test case was for the old behavi
Senthil Kumaran added the comment:
This is turning out be trickier than I ever thought.
fileno() returning b'' is just random error. The underlying issue is,
*directly* reading from the fp of the socket() is returning a incomplete output
at all times. The correct way to read the ou
Senthil Kumaran added the comment:
This is the best way I found to reproduce the failure.
I changed the resource to www.example.com and then ran this.
$ ./python.exe -m test -m "*fileno*" -u all -v -F test_urllibnet
--
___
Python trac
Senthil Kumaran added the comment:
I am getting to this late.
>> I don't know whether the file descriptor read is expected to be meaningful
>> for urllib2/urllib.request.
>> Senthil, what do you think?
It should be meaningful no matter what the length is. I am looking
Senthil Kumaran added the comment:
Which may be sane thing thing do.
So the docs could be made better. Like - the list of browsers specified in env
var BROWSER is tried first before looking at the platform defaults.
--
nosy: +orsenthil
___
Python
Senthil Kumaran added the comment:
Sure, here is the information on how to create a patch -
https://docs.python.org/devguide/
It could feel that there are multiple steps, but the process is easy.
--
___
Python tracker
<http://bugs.python.
Senthil Kumaran added the comment:
A simple docs patch would definitely help here. Thanks for the bug report.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue21
Senthil Kumaran added the comment:
Hello Evens,
If you can, then please attach a doc to this and we and fix this soon.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue21
Senthil Kumaran added the comment:
Yes, they indeed are. Thank you!
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
Reviewed the issue and correct rollbacks and commits were applied.
This ticket should be closed. Thanks!
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
Reading both the RFCs and requirements, I see that this is already taken care.
Note: we are actually have unencoded fragment like # and RFCs talk about
fragments with # character only. If you want the behavior of parse with
urlencoded to match un-urlencoded
Changes by Senthil Kumaran :
--
nosy: -orsenthil
___
Python tracker
<http://bugs.python.org/issue16278>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Senthil Kumaran :
--
nosy: -orsenthil
___
Python tracker
<http://bugs.python.org/issue10318>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
It may not just the be the version, but the capabilities. We have ensure that
capabilities are met/added before updated the version. Thanks for filing the
issue.
--
nosy: +orsenthil
___
Python tracker
<h
Senthil Kumaran added the comment:
Fixed:
3.5 a85606b6de32
3.4 fb5516cbc522
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
type: compile error -> behavior
___
Python tracker
<http://bugs.python
Senthil Kumaran added the comment:
Oops did not notice. Thanks for catching.
--
___
Python tracker
<http://bugs.python.org/issue21219>
___
___
Python-bugs-list m
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: test needed -> committed/rejected
versions: +Python 3.5 -Python 2.7, Python 3.3
___
Python tracker
<http://bugs.python.org/
Senthil Kumaran added the comment:
This is fixed in 3.4 and 3.5 (finally). I will port it to 2.7 as well.
--
___
Python tracker
<http://bugs.python.org/issue7
Senthil Kumaran added the comment:
I verified the patch and this indeed corrects a nasty bug in sending a wrong
header when doing it a lower level HTTPSConnection to proxy and set_tunnel (bad
term) to the end host..I was worried as why we did not observe this earlier and
it seems to me that
Senthil Kumaran added the comment:
I am reviewing this patch right now and you will see my action soon. It is
completely and I am reviewing to validating the technical details/fix. Thanks
for patch, Nikolaus.
--
___
Python tracker
<h
Senthil Kumaran added the comment:
Fixed this all active versions. Thanks for the report.
--
nosy: +orsenthil
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
The suggested patch(s) looks good to me.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue20939>
___
___
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
Senthil Kumaran added the comment:
I think, it is simply okay to mention about ResourceWarning being displayed. I
spent something thinking and going into mechanics of how it is displayed may be
an overkill for that line in unittest.rst. I'll make the change and if you see
any fu
Senthil Kumaran added the comment:
Addressed this in all active branches (2.7, 3.3 and 3.4). Thanks!
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
Fixed in:
New changeset a3e49868cfd0 by Senthil Kumaran in branch '3.3':
Issue #19092 - Raise a correct exception when cgi.FieldStorage is given an
http://hg.python.org/cpython/rev/a3e49868cfd0
New changeset 1638360eea41 by Senthil Kumaran in branc
Senthil Kumaran added the comment:
The last tracker message msg207926 is applicable to issue #19097 and not here.
Sorry for the confusion.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue19
Senthil Kumaran added the comment:
This is fixed in all active branches (2.7,3,3 and 3.4). I have addressed all
review comments. Thanks.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Senthil Kumaran added the comment:
And those examples were only in test.
Use of latin-1 to have a literal text for round trip is ok. The patch looks
good to me.
--
___
Python tracker
<http://bugs.python.org/issue20
Senthil Kumaran added the comment:
If you could point to RFC which states the list of characters which can be used
as valid query string separators, we can include that list. (Of course in 3.5)
--
nosy: +orsenthil
___
Python tracker
<h
Senthil Kumaran added the comment:
@Martin. Agree that this should have been backported. I have done that.
Thank you!
--
___
Python tracker
<http://bugs.python.org/issue12
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue19383>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Senthil Kumaran :
--
versions: +Python 2.7, Python 3.3, Python 3.4
___
Python tracker
<http://bugs.python.org/issue19350>
___
___
Python-bugs-list m
Senthil Kumaran added the comment:
Patch committed in these versions. Thank you!
2.7 -5fda64d39540
3.3 - 06b9a9e75a6c
3.4 - 060d9b2e4d5e
--
assignee: -> orsenthil
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
type:
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue19350>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Sounds good.I shall update patch (.rstify the security warning). Thank you!
--
___
Python tracker
<http://bugs.python.org/issue19
Senthil Kumaran added the comment:
The patch is good. I think, it is better to include this information in
documentation too. Please let me know if this suitable, I shall go ahead
committing this. (With credits to Vajrasky Kok)
--
assignee: -> orsenthil
nosy: +orsenthil
versi
Senthil Kumaran added the comment:
Addressing storchaka's review comments. Here is the updated patch.
--
Added file: http://bugs.python.org/file32021/19092-v2.diff
___
Python tracker
<http://bugs.python.org/is
Changes by Senthil Kumaran :
--
versions: +Python 3.3, Python 3.4 -Python 2.6
___
Python tracker
<http://bugs.python.org/issue19097>
___
___
Python-bugs-list m
Senthil Kumaran added the comment:
Hi Guido,
Agree with both your points.
Attaching a patch that fixes this issue.
1. Raises TypeError exception when header is not a Mapping or
email.message.Message type.
2. Asserts for fp.read and fp.readline() to assert that fp, the first argument
to
Senthil Kumaran added the comment:
Hi Raymond, Ezio provided some comments on improvements to the patch. Do you
mind if Ezio or I take over task of improvement. Not cause problems != no need
to improve.
TIA.
--
___
Python tracker
<h
Senthil Kumaran added the comment:
FieldStorage("foo", "bar") is invalid because the first argument is supposed to
be file-like object and second one headers. Here we are sending invalid
headers. By
default, if the headers is none, the content-type is urlencoded.
Th
501 - 600 of 2044 matches
Mail list logo