Serhiy Storchaka added the comment:
Here is a patch which fixes filename decoding error in
PyRun_SimpleFileExFlags().
--
keywords: +patch
Added file: http://bugs.python.org/file27630/pythonrun_filename_decoding.patch
___
Python tracker
<h
Changes by Serhiy Storchaka :
--
components: +Library (Lib)
nosy: +larry, serhiy.storchaka
versions: +Python 3.4
___
Python tracker
<http://bugs.python.org/issue15
Changes by Serhiy Storchaka :
--
keywords: +3.3regression
___
Python tracker
<http://bugs.python.org/issue15872>
___
___
Python-bugs-list mailing list
Unsubscribe:
Serhiy Storchaka added the comment:
In a normal loop we copy into the output buffer for each iteration the element
and the separator. As you know, the processor can copy large amounts of data
several times more efficiently than byte-for-byte. Therefore, filling the
buffer by memset more
Serhiy Storchaka added the comment:
Where we have tests for Python launch? I can't find. runpy is not affected.
--
___
Python tracker
<http://bugs.python.org/is
Serhiy Storchaka added the comment:
Here is a tests for most of fixed overflows. Some errors are difficult or
impossible to reproduce.
--
___
Python tracker
<http://bugs.python.org/issue15
Changes by Serhiy Storchaka :
Added file: http://bugs.python.org/file27632/long_aslong_overflow_tests.patch
___
Python tracker
<http://bugs.python.org/issue15989>
___
___
Serhiy Storchaka added the comment:
Patch LGTM.
Is there a new feature, not a bugfix? If yes, then I expect some documentation
changes.
--
nosy: +serhiy.storchaka
___
Python tracker
<http://bugs.python.org/issue16
Serhiy Storchaka added the comment:
> My interpretation of that is that __int__ should return an int, __float__ a
> float, __complex__ a complex number;
It's a reasonable interpretation. Changing it can be confusing.
On the other hand, int and float look like specialized subclasses
Serhiy Storchaka added the comment:
> Ok, but does it really make a difference and in which cases?
Up to 40% on Athlon and up to 70% on Atom.
> In other words, do you have benchmark numbers? :)
Attached results for AMD Athlon 64 X2 4600+ and Intel Atom N570 @ 1.66GHz
under 32-bit Linu
Changes by Serhiy Storchaka :
--
status: open -> pending
___
Python tracker
<http://bugs.python.org/issue10888>
___
___
Python-bugs-list mailing list
Unsubscri
Serhiy Storchaka added the comment:
Now shutil.rmtree has different behavior when called for non-directory on
systems with and without at-functions.
--
___
Python tracker
<http://bugs.python.org/issue15
Serhiy Storchaka added the comment:
> If rmtree fails to delete the directory tree (which will happen if one of the
> files can't be deleted), why would you want it to return succesfully?
At least it free some disk space. ;-)
--
___
Pyt
Serhiy Storchaka added the comment:
Indeed, 1-char separator is more common for strings, but I found several
b'\n'.join or b','.join even in stdlib. 3 lines of difference are only 2.3% of
Objects/stringlib/join.h.
Here is a patch with dropped the 1
Changes by Serhiy Storchaka :
Added file: http://bugs.python.org/file27636/bytes_join_optimization_3.patch
___
Python tracker
<http://bugs.python.org/issue12805>
___
___
Changes by Serhiy Storchaka :
Removed file: http://bugs.python.org/file25857/encode-utf32.patch
___
Python tracker
<http://bugs.python.org/issue15027>
___
___
Python-bug
Serhiy Storchaka added the comment:
Patch updated to 3.4.
Is anyone interested in 7x speedup of UTF-32 encoder?
--
keywords: +needs review
versions: +Python 3.4 -Python 3.3
Added file: http://bugs.python.org/file27637/encode_utf32_2.patch
___
Python
Changes by Serhiy Storchaka :
Removed file: http://bugs.python.org/file25278/decode_utf32_a.patch
___
Python tracker
<http://bugs.python.org/issue14625>
___
___
Python-bug
Changes by Serhiy Storchaka :
Removed file: http://bugs.python.org/file25279/decode_utf32_b.patch
___
Python tracker
<http://bugs.python.org/issue14625>
___
___
Python-bug
Changes by Serhiy Storchaka :
Removed file: http://bugs.python.org/file25537/decode_utf32_a_2.patch
___
Python tracker
<http://bugs.python.org/issue14625>
___
___
Pytho
Changes by Serhiy Storchaka :
Removed file: http://bugs.python.org/file25538/decode_utf32_b_2.patch
___
Python tracker
<http://bugs.python.org/issue14625>
___
___
Pytho
Serhiy Storchaka added the comment:
Patches updated to 3.4.
--
keywords: +needs review
versions: +Python 3.4 -Python 3.3
Added file: http://bugs.python.org/file27638/decode_utf32_a_3.patch
___
Python tracker
<http://bugs.python.org/issue14
Changes by Serhiy Storchaka :
--
keywords: +3.3regression
Added file: http://bugs.python.org/file27639/decode_utf32_b_3.patch
___
Python tracker
<http://bugs.python.org/issue14
Serhiy Storchaka added the comment:
I suggest apply patch A to 3.3 as it fixes performance regression (2x) and is
very simple.
--
versions: +Python 3.3
___
Python tracker
<http://bugs.python.org/issue14
Changes by Serhiy Storchaka :
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/issue14625>
___
___
Python-bugs-list mailing list
Unsubscribe:
Serhiy Storchaka added the comment:
It was too complicated code. Actually patched code is smaller.
1 file changed, 71 insertions(+), 80 deletions(-)
UTF-16 codec was modified in some way.
--
___
Python tracker
<http://bugs.python.org/issue14
Changes by Serhiy Storchaka :
--
status: open -> pending
___
Python tracker
<http://bugs.python.org/issue15186>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Serhiy Storchaka :
--
keywords: +needs review
stage: test needed ->
versions: +Python 3.4 -Python 3.1
___
Python tracker
<http://bugs.python.org/issue1
Changes by Serhiy Storchaka :
--
Removed message: http://bugs.python.org/msg162876
___
Python tracker
<http://bugs.python.org/issue1598083>
___
___
Python-bug
Changes by Serhiy Storchaka :
--
nosy: -serhiy.storchaka
___
Python tracker
<http://bugs.python.org/issue1598083>
___
___
Python-bugs-list mailing list
Unsub
Serhiy Storchaka added the comment:
I understand you, it's a patch against 2.7.
>+def readline(self, size=-1):
In io.IOBase.readline() and in io.TextIOBase.readline() this parameter named
"limit".
>+if size is not None and len(str) == size:
>+
Changes by Serhiy Storchaka :
--
resolution: -> fixed
stage: test needed -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Serhiy Storchaka added the comment:
I analyzed all 1-valued usages of Py_BuildValue and found similar bags only in
Modules/_sre.h. Here is a patch.
Bugs should be evident on big-endian platform with sizeof(int) < sizeof(size_t)
or sizeof(long) < sizeof(size_t). Standard tests should f
Changes by Serhiy Storchaka :
--
components: +Regular Expressions
nosy: +ezio.melotti, mrabarnett
___
Python tracker
<http://bugs.python.org/issue10182>
___
___
Changes by Serhiy Storchaka :
--
keywords: +needs review
___
Python tracker
<http://bugs.python.org/issue16230>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Serhiy Storchaka :
--
keywords: +needs review
___
Python tracker
<http://bugs.python.org/issue16228>
___
___
Python-bugs-list mailing list
Unsubscribe:
Serhiy Storchaka added the comment:
Some comments to patch.
+arcname = os.path.sep.join([x for x in arcname.split(os.path.sep)
+if x != '..'])
File names in zip archive should use '/' as separator, not os.path.sep.
'../spa
Serhiy Storchaka added the comment:
What about 2.7?
--
nosy: +serhiy.storchaka
versions: +Python 3.3, Python 3.4
___
Python tracker
<http://bugs.python.org/issue14
Serhiy Storchaka added the comment:
> $ ./python -m timeit -s "t = 'abcdefgh' * int(1E8)" "hash(t)"
I got another numbers (32-bit Linux, AMD Athlon 64 X2 4600+).
Python's current hash algorithm:
10 loops, best of 3: 343 msec per loop
V8's algori
Serhiy Storchaka added the comment:
As I see in pywin32 sources status.adapter_address is bytes in Python 3.
Here is a trivial patch.
--
keywords: +patch
Added file: http://bugs.python.org/file27658/uuid_netbios_getnode.patch
___
Python tracker
Serhiy Storchaka added the comment:
If the patch is good, why not commit it?
--
___
Python tracker
<http://bugs.python.org/issue16053>
___
___
Python-bugs-list m
Serhiy Storchaka added the comment:
I'm going to close this issue as a duplicate of issue6972. Issue6972 is older
and has a larger discussion.
Thank you for patch and research, Zhigang Wang. I will use it for the new patch.
--
resolution: -> duplicate
status: open -&
Serhiy Storchaka added the comment:
Here is a patch based on patch for issue10905. Test included (I have removed
some old tests as new one supersede them). Please test on Windows.
".." components, leading slashes, drive letter, etc are just dropped, as in
unzip or 7-Zip. Thanks Zh
Serhiy Storchaka added the comment:
You can use contextlib.closing() context manager (if urlopen() already does not
return a context manager).
--
nosy: +serhiy.storchaka
___
Python tracker
<http://bugs.python.org/issue16
Serhiy Storchaka added the comment:
This is wrong too.
>>> tuple('abc')
('a', 'b', 'c')
Use ((localhost(),) + thishost()))
--
nosy: +serhiy.storchaka
___
P
Serhiy Storchaka added the comment:
This issue was fixed in 3.3, but not in 2.7 or 3.2.
$ strace ./python -i &1 | grep readline
stat64("/home/serhiy/py/cpython3.3/build/lib.linux-i686-3.3/readline.cpython-33m.so",
{st_mode=S_IFREG|0755, st_size=52511, ...}) = 0
open("/home/s
Serhiy Storchaka added the comment:
3.2+ already use StringIO, there is no nonlinearity. On 2.7 I couldn't find the
nonlinearity with the texts of up to 100 MB.
Therefore the path outdated as bugfix.
However it shows 20-30x speedup on 2.7. It would be worth port it to 3.4. This
will
Serhiy Storchaka added the comment:
I understand what happens. Python 3.3+ uses getdents(), not stat() for module
search. Therefore stat() is not called for non-existed files.
> It stands that while the -S and -E option allow to disable any customization
> a user might have done (wh
Serhiy Storchaka added the comment:
There are many other cases of such issue: collections.namedtuple,
contextlib.contextmanager, profile.Profile.runcall, etc.
--
nosy: +serhiy.storchaka
___
Python tracker
<http://bugs.python.org/issue15
Changes by Serhiy Storchaka :
Removed file: http://bugs.python.org/file27661/zipfile_fix_arcname_2.patch
___
Python tracker
<http://bugs.python.org/issue6972>
___
___
Serhiy Storchaka added the comment:
Oh, I forgot docs.
--
Added file: http://bugs.python.org/file27665/zipfile_fix_arcname_2.patch
___
Python tracker
<http://bugs.python.org/issue6
Serhiy Storchaka added the comment:
You can overwrite fieldnames getter.
@property
def fieldnames(self):
if self._fieldnames is None:
try:
self._fieldnames = next(self.reader)
except StopIteration:
pass
Serhiy Storchaka added the comment:
The documentation is okay. :func:`match` returns a Match object (which have a
boolean value of True) if match and None (which have a boolean value of False)
if doesn't match.
--
nosy: +serhiy.stor
Serhiy Storchaka added the comment:
> +tmp_fileurl = 'file://localhost' + tmp_file
tmp_fileurl = 'file://localhost/' + tmp_file.replace(os.path.sep, '/')
--
___
Python tracker
&
Changes by Serhiy Storchaka :
Removed file: http://bugs.python.org/file27665/zipfile_fix_arcname_2.patch
___
Python tracker
<http://bugs.python.org/issue6972>
___
___
Serhiy Storchaka added the comment:
Patch updated. Fixed case '../C:/foo' on Windows.
--
Added file: http://bugs.python.org/file27686/zipfile_fix_arcname_3.patch
___
Python tracker
<http://bugs.python.
Serhiy Storchaka added the comment:
uid_t and gid_t converters can not be just typedefs. uid_t and gid_t can be
unsigned integral types (but including -1).
Also should be fixed Modules/grpmodule.c, Modules/pwdmodule.c and
Modules/signalmodule.c
Serhiy Storchaka added the comment:
>+- Issue #16116: Fix include and library paths to be correctwhen building C
Spaces.
--
nosy: +serhiy.storchaka
___
Python tracker
<http://bugs.python.org/issu
Serhiy Storchaka added the comment:
LGTM.
--
components: +Extension Modules
stage: -> commit review
versions: +Python 3.4
___
Python tracker
<http://bugs.python.org/issu
Changes by Serhiy Storchaka :
--
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issue10182>
___
___
Python-bugs-list mai
Changes by Serhiy Storchaka :
--
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue2005>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Serhiy Storchaka :
--
versions: +Python 3.4
___
Python tracker
<http://bugs.python.org/issue2005>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Serhiy Storchaka :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue6972>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Serhiy Storchaka :
--
stage: needs patch -> commit review
type: -> enhancement
versions: +Python 3.4
___
Python tracker
<http://bugs.python.org/i
Changes by Serhiy Storchaka :
--
keywords: +needs review
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue16102>
___
___
Python-bugs-lis
Changes by Serhiy Storchaka :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue16228>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Serhiy Storchaka :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue16230>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Serhiy Storchaka :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue14625>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Serhiy Storchaka :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue1470548>
___
___
Python-bugs-list mailing list
Un
Changes by Serhiy Storchaka :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue15027>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Serhiy Storchaka :
--
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue15872>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Serhiy Storchaka :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue15989>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Serhiy Storchaka :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue14850>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Serhiy Storchaka :
--
stage: committed/rejected -> commit review
versions: -Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/issu
Changes by Serhiy Storchaka :
--
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue13617>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Serhiy Storchaka :
--
status: open -> pending
___
Python tracker
<http://bugs.python.org/issue13572>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Serhiy Storchaka :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue9290>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Serhiy Storchaka :
--
stage: -> needs patch
type: behavior -> enhancement
___
Python tracker
<http://bugs.python.org/issue16240>
___
___
Pyth
Changes by Serhiy Storchaka :
--
stage: test needed -> needs patch
___
Python tracker
<http://bugs.python.org/issue1776674>
___
___
Python-bugs-list mai
Changes by Serhiy Storchaka :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue16215>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Serhiy Storchaka :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue16216>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Serhiy Storchaka :
--
stage: test needed -> patch review
___
Python tracker
<http://bugs.python.org/issue1634034>
___
___
Python-bugs-list mai
Changes by Serhiy Storchaka :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue13451>
___
___
Python-bugs-list mailing list
Unsubscri
Serhiy Storchaka added the comment:
Mark, can I help?
--
___
Python tracker
<http://bugs.python.org/issue14700>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Serhiy Storchaka :
--
keywords: +needs review
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue15278>
___
___
Python-bugs-lis
Changes by Serhiy Storchaka :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue15999>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Serhiy Storchaka :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue16165>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Serhiy Storchaka :
--
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue15984>
___
___
Python-bugs-list mailing list
Unsubscri
Serhiy Storchaka added the comment:
This is a bug of 2 -> 3 transition.
--
type: -> enhancement
versions: +Python 3.2, Python 3.4
___
Python tracker
<http://bugs.python.org/i
Changes by Serhiy Storchaka :
--
stage: -> needs patch
type: -> enhancement
versions: +Python 3.4
___
Python tracker
<http://bugs.python.org/issue15436>
___
__
Changes by Serhiy Storchaka :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue4997>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Serhiy Storchaka :
--
nosy: +serhiy.storchaka
type: -> enhancement
versions: +Python 3.4 -Python 3.3
___
Python tracker
<http://bugs.python.org/issu
Serhiy Storchaka added the comment:
LGTM.
--
nosy: +serhiy.storchaka
___
Python tracker
<http://bugs.python.org/issue16305>
___
___
Python-bugs-list mailin
Serhiy Storchaka added the comment:
Previous patches contain redundant code, are not protected from all symlink
loops (link -> link/x; dir/link -> ../dir/link) and when a loop is detected the
returned result differs from the current one.
The proposed patch solves this issue and some
Serhiy Storchaka added the comment:
Soon I'll post a patch, which speeds up unicode-escape and raw-unicode-escape
decoders to 1.5-3x. Also there are not yet reviewed patches for UTF-32
(issue14625) and charmap (issue14850) decoders. Will be merge conflicts.
But I will review the
Serhiy Storchaka added the comment:
I suggest use PyLong_AsLongAndOverflow/PyLong_AsLongLongAndOverflow and then
PyLong_AsUnsignedLong/PyLong_AsUnsignedLongLong in case if positive overflow.
Perhaps you need also special converters for "O&" format in PyArg_ParseTuple.
This i
Serhiy Storchaka added the comment:
Of course PyLong_AsUnsignedLong* should be used only if the type is unsigned.
In such case any negative values except -1 are invalid.
--
keywords: -easy
___
Python tracker
<http://bugs.python.org/issue2
New submission from Serhiy Storchaka:
The proposed patch adds xz compression support in additional to gzip and bzip2
in shutil module.
--
components: Library (Lib)
files: shutil-lzma.patch
keywords: patch
messages: 173707
nosy: hynek, nadeem.vawda, serhiy.storchaka, tarek
priority
Changes by Serhiy Storchaka :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue16313>
___
___
Python-bugs-list mailing list
Unsubscri
New submission from Serhiy Storchaka:
The proposed patch adds xz compression support in additional to gzip, compress
and bzip2 in distutils.
--
assignee: eric.araujo
components: Distutils
files: distutils-lzma.patch
keywords: patch
messages: 173708
nosy: eric.araujo, nadeem.vawda
1001 - 1100 of 1431 matches
Mail list logo