[issue17810] Implement PEP 3154 (pickle protocol 4)

2013-06-03 Thread Stefan Mihaila
Stefan Mihaila added the comment: On 6/3/2013 9:33 PM, Alexandre Vassalotti wrote: Alexandre Vassalotti added the comment: Stefan, could you address my review comments soon? The improved support for globals is the only big piece missing from the implementation of PEP, which I would like

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

2013-05-11 Thread Stefan Mihaila
Changes by Stefan Mihaila mstefa...@gmail.com: Added file: http://bugs.python.org/file30216/d0c3a8d4947a.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15642

[issue17810] Implement PEP 3154 (pickle protocol 4)

2013-05-10 Thread Stefan Mihaila
Changes by Stefan Mihaila mstefa...@gmail.com: -- nosy: +mstefanro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17810 ___ ___ Python-bugs-list

[issue17810] Implement PEP 3154 (pickle protocol 4)

2013-05-10 Thread Stefan Mihaila
Changes by Stefan Mihaila mstefa...@gmail.com: Added file: http://bugs.python.org/file30211/780722877a3e.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17810

[issue17810] Implement PEP 3154 (pickle protocol 4)

2013-05-10 Thread Stefan Mihaila
Changes by Stefan Mihaila mstefa...@gmail.com: Removed file: http://bugs.python.org/file30211/780722877a3e.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17810

[issue17810] Implement PEP 3154 (pickle protocol 4)

2013-05-10 Thread Stefan Mihaila
Stefan Mihaila added the comment: On 5/10/2013 11:46 PM, Stefan Mihaila wrote: Changes by Stefan Mihaila mstefa...@gmail.com: -- nosy: +mstefanro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17810

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

2013-04-22 Thread Stefan Mihaila
Stefan Mihaila added the comment: Hello. I apologize once again for not finalizing my work, but once I have started my final year of faculty and a job, I have been busy pretty much all the time. I would really like to finish this as I've really enjoyed working on it, and everything on PEP

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

2012-08-23 Thread Stefan Mihaila
Stefan Mihaila added the comment: Are there also some known techniques on tracking down memory leaks? I've played around with sys.gettotalrefcount to narrow down the place where the leaks occur, but they seem to only occur in v4, i.e. pickle.dumps(3.0+1j, 4) leaks but pickle.dumps(3.0+1j, 3

[issue15773] `is' operator returns False on classmethods

2012-08-23 Thread Stefan Mihaila
New submission from Stefan Mihaila: Here are a few counter-intuitive outputs: dict.fromkeys is dict.fromkeys False id(dict.fromkeys) == id(dict.fromkeys) True x=dict.fromkeys; id(x) == id(x) True x=dict.fromkeys; id(x) == id(dict.fromkeys) False

[issue15773] `is' operator returns False on classmethods

2012-08-23 Thread Stefan Mihaila
Changes by Stefan Mihaila mstefa...@gmail.com: -- type: - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15773 ___ ___ Python-bugs-list

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

2012-08-22 Thread Stefan Mihaila
Stefan Mihaila added the comment: - I don't really like the idea of changing the semantics of the PUT and GET opcodes. I would prefer new opcodes if possible. Well, the semantics of PUT and GET haven't really changed. It's just that the PUT opcode is not generated anymore and memoization

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

2012-08-19 Thread Stefan Mihaila
Stefan Mihaila added the comment: There are still some upcoming changes. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15642 ___ ___ Python

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

2012-08-18 Thread Stefan Mihaila
Stefan Mihaila added the comment: Maybe you can set this issue as the superseder of issue9269, because the patches there have already been applied here. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15642

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

2012-08-14 Thread Stefan Mihaila
Stefan Mihaila added the comment: Maybe we could postpone the review process for a few days until I fix some known issues -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15642

[issue633930] Nested class __name__

2012-07-29 Thread Stefan Mihaila
Stefan Mihaila added the comment: Only an issue in Python2. A.B.__qualname__ 'A.B' repr(A.B) class '__main__.A.B' -- nosy: +mstefanro versions: +Python 2.6, Python 2.7 ___ Python tracker rep...@bugs.python.org http

[issue1062277] Pickle breakage with reduction of recursive structures

2012-07-27 Thread Stefan Mihaila
Changes by Stefan Mihaila mstefa...@gmail.com: -- nosy: +mstefanro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1062277 ___ ___ Python-bugs-list

[issue9269] Cannot pickle self-referencing sets

2012-07-27 Thread Stefan Mihaila
Stefan Mihaila mstefa...@gmail.com added the comment: Attaching patch for fixing a test and adding better testing of sets. -- Added file: http://bugs.python.org/file26539/sets-test.patch ___ Python tracker rep...@bugs.python.org http

[issue9269] Cannot pickle self-referencing sets

2012-07-26 Thread Stefan Mihaila
Stefan Mihaila mstefa...@gmail.com added the comment: I have attached a fix to this issue (and implicitly issue1062277). This patch allows pickling self-referential sets by implementing a set.__reduce__ which uses states as opposed to ctor parameters. Before: s=set([1,2,3]) s.__reduce__

[issue15397] Unbinding of methods

2012-07-22 Thread Stefan Mihaila
Stefan Mihaila mstefa...@gmail.com added the comment: Richard, yes, I think that would work, I didn't think of using f.__self__'s type. You might want to replace if self is not None and not isinstance(self, types.ModuleType): with if self is not None and not isinstance(self

[issue15397] Unbinding of methods

2012-07-22 Thread Stefan Mihaila
Stefan Mihaila mstefa...@gmail.com added the comment: Andrew, thanks for creating a separate issue (the refleak was very rare and I thought I'd put it in the same place, but now I realize it was a bad idea). Richard, actually, the isinstance(self, type) check I mentioned earlier would have

[issue15397] Unbinding of methods

2012-07-19 Thread Stefan Mihaila
Changes by Stefan Mihaila mstefa...@gmail.com: -- nosy: +alexandre.vassalotti, ncoghlan, rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15397

[issue15397] Unbinding of methods

2012-07-19 Thread Stefan Mihaila
New submission from Stefan Mihaila mstefa...@gmail.com: In order to implement pickling of instance methods, a means of separating the object and the unbound method is necessary. This is easily done for Python methods (f.__self__ and f.__func__), but not all of builtins support __func__

[issue15397] Unbinding of methods

2012-07-19 Thread Stefan Mihaila
Stefan Mihaila mstefa...@gmail.com added the comment: Yes, the patch is at http://codereview.appspot.com/6425052/ The code there also contains some tests I've written for functools.unbind. -- Added file: http://bugs.python.org/file26439/unbind_test.patch

[issue15397] Unbinding of methods

2012-07-19 Thread Stefan Mihaila
Stefan Mihaila mstefa...@gmail.com added the comment: Doesn't the definition I've added at the end of methodobject.c suffice? (http://codereview.appspot.com/6425052/patch/1/10) Or should the macro be removed altogether? -- ___ Python tracker rep