[issue40833] Clarify docstring of Path.rename

2020-10-03 Thread Tal Einat
Tal Einat added the comment: New changeset f97e42ef4d97dee64f45ed65170a6e77c8e46fdf by Ram Rachum in branch 'master': bpo-40833: Clarify Path.rename doc-string regarding relative paths (GH-20554) https://github.com/python/cpython/commit/f97e42ef4d97dee64f45ed65170a6e77c8e46fdf

[issue41894] UnicodeDecodeError during load failure in non-UTF-8 locale

2020-10-02 Thread Tal Einat
Change by Tal Einat : -- versions: -Python 3.5, Python 3.6, Python 3.7 ___ Python tracker <https://bugs.python.org/issue41894> ___ ___ Python-bugs-list mailin

[issue41851] tkinter: add font equal methods

2020-09-28 Thread Tal Einat
Change by Tal Einat : -- assignee: -> docs@python components: +Documentation nosy: +docs@python ___ Python tracker <https://bugs.python.org/issue41851> ___ _

[issue40105] Updating zip comment doesn't truncate the zip file

2020-09-28 Thread Tal Einat
Tal Einat added the comment: Thanks for the report and initial PR, Yudi! Thanks for the second PR, Jan! -- nosy: -miss-islington resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracke

[issue40105] Updating zip comment doesn't truncate the zip file

2020-09-28 Thread Tal Einat
Change by Tal Einat : -- versions: +Python 3.10, Python 3.9 ___ Python tracker <https://bugs.python.org/issue40105> ___ ___ Python-bugs-list mailing list Unsub

[issue40105] Updating zip comment doesn't truncate the zip file

2020-09-28 Thread Tal Einat
Tal Einat added the comment: New changeset ff9147d93b868f0e13b9fe14e2a76c2879f6787b by Jan Mazur in branch 'master': bpo-40105: ZipFile truncate in append mode with shorter comment (GH-19337) https://github.com/python/cpython/commit/ff9147d93b868f0e13b9fe14e2a76c2879f6787b -- nosy

[issue41851] tkinter: add font equal methods

2020-09-28 Thread Tal Einat
Tal Einat added the comment: P.P.S. Re-reading that piece of code for IDLE's font config dialog, that actually looks to be intentional and correct. -- ___ Python tracker <https://bugs.python.org/issue41

[issue41851] tkinter: add font equal methods

2020-09-28 Thread Tal Einat
Tal Einat added the comment: > > I also think using [.equal] wouldn't add anything > I disagree and will stand by this one! Please do note that the full quote was "I also think using it wouldn't add anything, and would be less clear, compared to font1.actual() == font2.a

[issue41858] Fix incomplete line on optparse documentation

2020-09-27 Thread Tal Einat
Tal Einat added the comment: Thanks for the report and the PR, Emmanuel! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue41851] tkinter: add font neg and equal methods

2020-09-26 Thread Tal Einat
Tal Einat added the comment: As for an equal() method, I think that adding equal() which is different than the existing __eq__() would be a source of confusion. I also think using it wouldn't add anything, and would be less clear, compared to font1.actual() == font2.actual(). I'm

[issue41851] tkinter: add font neg and equal methods

2020-09-26 Thread Tal Einat
Tal Einat added the comment: Why would negating the font size convert it from points to pixels?? It seems to be coming straight from Tk; is this documented anywhere? I'd greatly prefer that we use a properly named property instead, e.g. .pixel_size. -- nosy: +taleinat

[issue41858] Fix incomplete line on optparse documentation

2020-09-26 Thread Tal Einat
Tal Einat added the comment: I agree with Terry that the current form is not incorrect, as well as with his suggestion to inline the commands for printing the usage info. -- nosy: +taleinat ___ Python tracker <https://bugs.python.org/issue41

[issue29940] Add follow_wrapped=True option to help()

2020-09-26 Thread Tal Einat
Tal Einat added the comment: The issue was not that __doc__ was not copied, but that help() would use the class's __doc__ when called on an instance, even if that instance had its own __doc__. See the StackOverflow question for another example. You will not see this issue with the latest

[issue29940] Add follow_wrapped=True option to help()

2020-09-25 Thread Tal Einat
Tal Einat added the comment: To clarify, to my understanding the issue here is that when using a class as a decorator, and copying the wrapped function's __doc__ to self.__doc__ in __init__, help() will pick up the wrapper class's __doc__ rather than the instance's __doc__. For example

[issue41561] test_ssl fails in Ubuntu 20.04: test_min_max_version_mismatch

2020-09-20 Thread Tal Einat
Tal Einat added the comment: Same. -- ___ Python tracker <https://bugs.python.org/issue41561> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue1207613] Idle Editor: Bottom Scroll Bar

2020-09-20 Thread Tal Einat
Tal Einat added the comment: We've run into a significant technical hurdle in trying to implement a horizontal scrollbar: The Tk text widget sets the horizontal scroll position only according to the currently visible lines! If the text was scrolled to the right, scrolling down to where

[issue41561] test_ssl fails in Ubuntu 20.04: test_min_max_version_mismatch

2020-09-20 Thread Tal Einat
Tal Einat added the comment: No, adding that after the first line of test_min_max_version_mismatch() still results in the same error: ssl.SSLError: [SSL: UNSUPPORTED_PROTOCOL] unsupported protocol (_ssl.c:1122) -- ___ Python tracker <ht

[issue21261] Teach IDLE to Autocomplete dictionary keys

2020-09-20 Thread Tal Einat
Tal Einat added the comment: People still get confused between bytes and strings, even with Python 3, especially novice programmers who are a major target audience of IDLE. I simply thought it would be confusing if string dict keys did appear in the completion list, but bytes keys did

[issue21261] Teach IDLE to Autocomplete dictionary keys

2020-09-20 Thread Tal Einat
Tal Einat added the comment: Also, please note that the PR allows using either type of quote when typing completions. -- ___ Python tracker <https://bugs.python.org/issue21

[issue12178] csv writer doesn't escape escapechar

2020-09-20 Thread Tal Einat
Tal Einat added the comment: After a great deal of delay, a fix for this has finally been merged, and will be available in Python 3.10. Thanks to everyone involved! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10 -P

[issue12178] csv writer doesn't escape escapechar

2020-09-20 Thread Tal Einat
Tal Einat added the comment: New changeset 5c0eed7375fdd791cc5e19ceabfab4170ad44062 by Berker Peksag in branch 'master': bpo-12178: Fix escaping of escapechar in csv.writer() (GH-13710) https://github.com/python/cpython/commit/5c0eed7375fdd791cc5e19ceabfab4170ad44062

[issue28657] cmd.Cmd.get_help() implementation can't see do_*() methods added dynamically by setattr()

2020-09-19 Thread Tal Einat
Tal Einat added the comment: I agree with Raymond's reasoning on this. Following the discussion, I'm closing this as wontfix. Thanks to everyone involved for the detailed, clear and focused discussion. -- nosy: +taleinat resolution: -> wont fix stage: patch review -> re

[issue37827] IDLE: Have the shell mimic terminal handling of \r and \b control characters in outputs

2020-09-19 Thread Tal Einat
Tal Einat added the comment: I will highlight the fact that IDLE's shell currently allows no way of showing a progress indicator, beyond extremely simple bar that only fill up from left to right, without any indication of the rightmost limit, a percentage indicator, or a rotating progress

[issue37849] IDLE: Completion window misplaced when shown above current line

2020-09-19 Thread Tal Einat
Change by Tal Einat : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> behavior ___ Python tracker <https://bugs.python

[issue33689] Blank lines in .pth file cause a duplicate sys.path entry

2020-09-19 Thread Tal Einat
Tal Einat added the comment: Thanks for bringing this up again Malcolm, for the original Patch Ammar, and for the work on the PR Ido! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10 -P

[issue33689] Blank lines in .pth file cause a duplicate sys.path entry

2020-09-19 Thread Tal Einat
Tal Einat added the comment: New changeset 0c71a66b53f6ea262aa5a60784c8c625ae0bb98c by idomic in branch 'master': bpo-33689: Blank lines in .pth file cause a duplicate sys.path entry (GH-20679) https://github.com/python/cpython/commit/0c71a66b53f6ea262aa5a60784c8c625ae0bb98c

[issue37827] IDLE: Have the shell mimic terminal handling of \r and \b control characters in outputs

2020-09-19 Thread Tal Einat
Tal Einat added the comment: As the creator of this issue, I'm reverting the name back to the original, since I did not propose to add a new "mode" to the IDLE shell. Such a proposal could be a separate issue. I'm unfortunately going to mark close this as "rejected&quo

[issue33689] Blank lines in .pth file cause a duplicate sys.path entry

2020-09-19 Thread Tal Einat
Tal Einat added the comment: This is certainly a bug fix, but since it may break backwards-compatibility in delicate ways, I'm not going to backport it to earlier versions. Expect this to land in 3.10. -- ___ Python tracker <ht

[issue41561] test_ssl fails in Ubuntu 20.04: test_min_max_version_mismatch

2020-09-19 Thread Tal Einat
Tal Einat added the comment: Likewise here on Ubuntu 20.04: (True, True, True, True) -1 -2 -- ___ Python tracker <https://bugs.python.org/issue41561> ___ ___

[issue12800] 'tarfile.StreamError: seeking backwards is not allowed' when extract symlink

2020-09-19 Thread Tal Einat
Tal Einat added the comment: See also another duplicate of this issue, issue40049. -- nosy: +taleinat versions: +Python 3.10, Python 3.9 ___ Python tracker <https://bugs.python.org/issue12

[issue40049] tarfile cannot extract from stdin

2020-09-19 Thread Tal Einat
Tal Einat added the comment: This is actually a duplicate of issue12800, which itself describe precisely the same issue as in issue10761, which was fixed but then the fix was lost in a bad merge. I'm closing this, as discussion should happen on the original issues. -- resolution

[issue41775] IDLE: change Shell window title

2020-09-19 Thread Tal Einat
Change by Tal Einat : -- nosy: -taleinat ___ Python tracker <https://bugs.python.org/issue41775> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40049] tarfile cannot extract from stdin

2020-09-18 Thread Tal Einat
Tal Einat added the comment: GNU tar (v1.30, Ubuntu 20.04) does indeed overwrite files with symlinks upon extracting, while both `ln -s` and `os.symlink` do not. Therefore I agree that the appropriate behavior would seem to be to overwrite this way, as in the attached PR. -- nosy

[issue38815] test_ssl: test_min_max_version() fails on FreeBSD and Fedora

2020-09-17 Thread Tal Einat
Tal Einat added the comment: Ping? -- nosy: +taleinat status: pending -> open ___ Python tracker <https://bugs.python.org/issue38815> ___ ___ Python-bugs-lis

[issue41561] test_ssl fails in Ubuntu 20.04: test_min_max_version_mismatch

2020-09-17 Thread Tal Einat
Change by Tal Einat : -- versions: +Python 3.10, Python 3.9 ___ Python tracker <https://bugs.python.org/issue41561> ___ ___ Python-bugs-list mailing list Unsub

[issue41561] test_ssl fails in Ubuntu 20.04: test_min_max_version_mismatch

2020-09-17 Thread Tal Einat
Tal Einat added the comment: I just ran into this too on Ubuntu 20.04. I don't recommend changing /etc/ssl/openssl.cnf. Instead, make a local copy, for example at $HOME/cpython-dev-openssl.cnf, with the changes suggested by Vladyslav Bondar. Then run the tests with: OPENSSL_CONF=$HOME

[issue37765] IDLE: Include longer keywords in __main__ autocomplete list

2020-07-07 Thread Tal Einat
Tal Einat added the comment: Auto-completion is not just about saving keystrokes. For example, I assume that many Python beginners just read through the completion list to see what the options are. This inconsistency would be hard to grok. I think that including only some of the keywords

[issue37765] IDLE: Include longer keywords in __main__ autocomplete list

2020-07-07 Thread Tal Einat
Tal Einat added the comment: Also, note that the keywords would only be included in the suggested completions when not in a string and when not completing an attribute. So, for example, such a change could not possibly affect the completion of dunder method names

[issue37706] IDLE: fix sidebar click-drag bug and macOS test failures

2020-06-28 Thread Tal Einat
Tal Einat added the comment: While we're on the topic, it seems wise to have our macOS buildbot workers create proper framework builds and run the GUI tests, if possible. We should also try to get a macOS 10.15 ("Catalina") machine into our buildbot fleet. Perhaps there's

[issue37706] IDLE: fix sidebar click-drag bug and macOS test failures

2020-06-28 Thread Tal Einat
Tal Einat added the comment: I had been running the GUI tests, apparently until the change Ned mentioned whereby they are only run on framework builds of Python. With Ned's help, I've finally managed to create a framework build on macOS where the GUI tests run properly. Indeed, running

[issue40511] IDLE: properly handle '(' and ')' within calls

2020-06-16 Thread Tal Einat
Tal Einat added the comment: See PR GH-20910 with a fix. -- ___ Python tracker <https://bugs.python.org/issue40511> ___ ___ Python-bugs-list mailing list Unsub

[issue40511] IDLE: properly handle '(' and ')' within calls

2020-06-16 Thread Tal Einat
Change by Tal Einat : -- keywords: +patch pull_requests: +20092 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20910 ___ Python tracker <https://bugs.python.org/issu

[issue40511] IDLE: properly handle '(' and ')' within calls

2020-06-16 Thread Tal Einat
Tal Einat added the comment: Confirmed on latest master on macOS 10.15.5 with Tcl/Tk 8.6.10. -- ___ Python tracker <https://bugs.python.org/issue40511> ___ ___

[issue40511] IDLE: properly handle '(' and ')' within calls

2020-06-16 Thread Tal Einat
Tal Einat added the comment: > OMG, request too large. I can't upload mp4 You can try to reduce the video's resolution and/or framerate in order to reduce its size. Usually screen captures are taken at high resolution and framerates by default, making the resulting video files very la

[issue40511] IDLE: properly handle '(' and ')' within calls

2020-06-16 Thread Tal Einat
Tal Einat added the comment: I agree that this should be improved. Terry, on the technical side, IDLE already has good tools for parsing the current code line/block and figuring out whether the cursor is in a string, a comment or parentheses. This should be possible to solve in a robust way

[issue40594] urljoin since 3.5 incorrectly filters out double slashes

2020-06-09 Thread Tal Einat
Tal Einat added the comment: Putting aside backwards compatibility, I would argue the opposite: Since consecutive slashes are valid, I suggest we would need to see that collapsing them into a single slash is the status quo, otherwise we should avoid such collapsing. Here's some evidence

[issue40594] urljoin since 3.5 incorrectly filters out double slashes

2020-06-09 Thread Tal Einat
Tal Einat added the comment: According to section 3.3 of RFC 3986[1], and also RFC 2396[2] which preceded it, a path is made up of zero or more consecutive "/" + section pieces, and a section may be empty. In other words, paths may include consecutive slashes. Several StackOverfl

[issue19670] SimpleCookie Generates Non-RFC6265-Compliant Cookies

2020-06-09 Thread Tal Einat
Tal Einat added the comment: It seems that the docs haven't been updated regarding this, so I don't think this should be closed. On the contrary, A PR adding a clarification to the docs would be most welcome. -- ___ Python tracker <ht

[issue19670] SimpleCookie Generates Non-RFC6265-Compliant Cookies

2020-06-09 Thread Tal Einat
Change by Tal Einat : -- versions: -Python 3.6 ___ Python tracker <https://bugs.python.org/issue19670> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19670] SimpleCookie Generates Non-RFC6265-Compliant Cookies

2020-06-09 Thread Tal Einat
Change by Tal Einat : -- components: -Library (Lib) ___ Python tracker <https://bugs.python.org/issue19670> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21756] IDLE - ParenMatch fails to find closing paren of multi-line statements

2020-06-09 Thread Tal Einat
Tal Einat added the comment: I've created a PR against current master based on the patch, see GH-20753. -- ___ Python tracker <https://bugs.python.org/issue21

[issue21756] IDLE - ParenMatch fails to find closing paren of multi-line statements

2020-06-09 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +19955 pull_request: https://github.com/python/cpython/pull/20753 ___ Python tracker <https://bugs.python.org/issue21

[issue21756] IDLE - ParenMatch fails to find closing paren of multi-line statements

2020-06-09 Thread Tal Einat
Tal Einat added the comment: > You solution is to add a new parameter to __init__ only used by 'flash'. I > would rather replace 'mustclose' with mode = 'tip', 'flash', or 'close'. I > believe that Stopatindex could be revised within the call. The problem with this s

[issue21756] IDLE - ParenMatch fails to find closing paren of multi-line statements

2020-06-09 Thread Tal Einat
Tal Einat added the comment: Terry, kudos for getting back to this! Let me make a PR for this, it will make reviewing and testing easier. -- ___ Python tracker <https://bugs.python.org/issue21

[issue40065] py39: remove deprecation note for xml.etree.cElementTree

2020-06-08 Thread Tal Einat
Tal Einat added the comment: Ah, thanks for the update Christian, I must have misunderstood your intentions. So should the deprecation note be removed in the "master" branch for 3.10? -- ___ Python tracker <https://bugs.python.o

[issue40065] py39: remove deprecation note for xml.etree.cElementTree

2020-06-08 Thread Tal Einat
Tal Einat added the comment: (My mistake! This should be done from/against the master branch, and then back-ported to 3.9, as usual.) -- ___ Python tracker <https://bugs.python.org/issue40

[issue40065] py39: remove deprecation note for xml.etree.cElementTree

2020-06-08 Thread Tal Einat
Tal Einat added the comment: (Also, please note that the "master" branch is now for version 3.10; PRs for version 3.9 should be based on the "3.9" branch, and the pull request made for that branch too.) -- ___ Py

[issue40065] py39: remove deprecation note for xml.etree.cElementTree

2020-06-08 Thread Tal Einat
Tal Einat added the comment: AFAICT from following the discussion, the decision is to hold off on a few deprecations which were causing most of the breakage. However, this does not appear to include xml.etree.cElementTree. Since that has currently been removed in the 3.9 branch, we should

[issue35885] configparser: indentation

2020-06-08 Thread Tal Einat
Tal Einat added the comment: I'm -1 on making this change. Frankly, I think there are many better modern alternatives to ConfigParser, and I think we should avoid complicating it any further. -- nosy: +taleinat ___ Python tracker <ht

[issue40856] IDLE line numbering should be light gray

2020-06-03 Thread Tal Einat
Tal Einat added the comment: I agree that the line numbers should be less prominent. Terry, why not change the the default? ISTM we should strive to have good default colors, they are what most users use and see. I also think we should improve the dark theme, but that's a separate issue

[issue38035] shared_semaphores cannot be shared across unrelated processes

2020-05-29 Thread Tal Einat
Tal Einat added the comment: Sorry this hasn't been followed up. I think this would best be discussed a bit on the Python-Ideas mailing list. Please send an email there suggesting this feature, and link to the discussion thread in the mailing list archives here

[issue37824] IDLE: Handle Shell input warnings properly.

2020-05-26 Thread Tal Einat
Change by Tal Einat : -- versions: +Python 3.10 ___ Python tracker <https://bugs.python.org/issue37824> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39724] IDLE threading + stdout/stdin observed blocking behavior

2020-05-26 Thread Tal Einat
Tal Einat added the comment: Can someone talk about the reasoning behind the nested Tk mainloop? I haven't managed to find anything useful in code comments and such. Guido? -- ___ Python tracker <https://bugs.python.org/issue39

[issue39724] IDLE threading + stdout/stdin observed blocking behavior

2020-05-26 Thread Tal Einat
Tal Einat added the comment: This seems to be at least partly intentional: When waiting for user input, IDLE starts a nested Tk mainloop (!), which is stopped by the end-of-line handler. It seems to me that this is what is causing displaying other outputs to be delayed

[issue39244] multiprocessing.get_all_start_methods() wrong default on macOS

2020-05-26 Thread Tal Einat
Tal Einat added the comment: Thanks for fixing this, Ido! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue39244] multiprocessing.get_all_start_methods() wrong default on macOS

2020-05-26 Thread Tal Einat
Tal Einat added the comment: New changeset db098bc1f05bd0773943e59f83489f05f28dedf8 by idomic in branch 'master': bpo-39244: multiprocessing return default start method first on macOS (GH-18625) https://github.com/python/cpython/commit/db098bc1f05bd0773943e59f83489f05f28dedf8

[issue39244] multiprocessing.get_all_start_methods() wrong default on macOS

2020-05-26 Thread Tal Einat
Change by Tal Einat : -- versions: +Python 3.10 ___ Python tracker <https://bugs.python.org/issue39244> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38580] select()'s documentation claims only sequences are accepted, but it allows all iterables

2020-05-26 Thread Tal Einat
Tal Einat added the comment: New changeset 3f215f35bdb9d666f5a692fc60f800da1bb1e4a9 by Tal Einat in branch '3.7': [3.7] bpo-38580: Document that select() accepts iterables, not just sequences (GH-16832) https://github.com/python/cpython/commit/3f215f35bdb9d666f5a692fc60f800da1bb1e4a9

[issue38580] select()'s documentation claims only sequences are accepted, but it allows all iterables

2020-05-26 Thread Tal Einat
Tal Einat added the comment: New changeset e3e800f3d28881cc9de38cd9bcbcf8fbdea238a6 by Tal Einat in branch '3.8': [3.8] bpo-38580: Document that select() accepts iterables, not just sequences (GH-16832) https://github.com/python/cpython/commit/e3e800f3d28881cc9de38cd9bcbcf8fbdea238a6

[issue38580] select()'s documentation claims only sequences are accepted, but it allows all iterables

2020-05-26 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +19684 pull_request: https://github.com/python/cpython/pull/20426 ___ Python tracker <https://bugs.python.org/issue38

[issue38580] select()'s documentation claims only sequences are accepted, but it allows all iterables

2020-05-26 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +19682 pull_request: https://github.com/python/cpython/pull/20424 ___ Python tracker <https://bugs.python.org/issue38

[issue40373] urlunparse does not escape slash (/) for http+unix:// in netloc field

2020-05-25 Thread Tal Einat
Tal Einat added the comment: This seems to simply be a misunderstanding: urlunparse() and urlunsplit() intentionally do not do any encoding of their components. -- resolution: -> not a bug stage: -> resolved status: open -> closed _

[issue38580] select()'s documentation claims only sequences are accepted, but it allows all iterables

2020-05-25 Thread Tal Einat
Tal Einat added the comment: Nothing further is required; I've merged the PR. Thanks! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10 ___ Python tracker <https://bugs.python.or

[issue38580] select()'s documentation claims only sequences are accepted, but it allows all iterables

2020-05-25 Thread Tal Einat
Tal Einat added the comment: New changeset 372ee27d4958302dac7ad6a8711f6fd04771b2e6 by Jakub Stasiak in branch 'master': bpo-38580: Document that select() accepts iterables, not just sequences (GH-16832) https://github.com/python/cpython/commit/372ee27d4958302dac7ad6a8711f6fd04771b2e6

[issue40452] Tkinter/IDLE: preserve clipboard on closure

2020-05-20 Thread Tal Einat
Tal Einat added the comment: Attaching the changes I made while testing as a patch file. -- Added file: https://bugs.python.org/file49173/tkinter-clipboard-on-exit.patch ___ Python tracker <https://bugs.python.org/issue40

[issue40452] Tkinter/IDLE: preserve clipboard on closure

2020-05-20 Thread Tal Einat
Tal Einat added the comment: Regarding multiple Tk instances, IMO we should try the straightforward solution first: Tcl/Tk has its own mechanisms for handling per-interpreter state, so we may not actually need to handle any of this ourselves. Regarding the title of this issue, it is indeed

[issue40452] Tkinter/IDLE: preserve clipboard on closure

2020-05-19 Thread Tal Einat
Tal Einat added the comment: epaine, if you'd like to create a new PR based on these findings, I'd be happy to review it! -- ___ Python tracker <https://bugs.python.org/issue40

[issue40452] Tkinter/IDLE: preserve clipboard on closure

2020-05-19 Thread Tal Einat
Tal Einat added the comment: Indeed, adding a simple _tkinter.destroy() method which invokes Tcl_Finalize, and calling it in the Tk.destroy() method, makes copied text remain available after closing IDLE! I did the above to test my hypothesis, but I'm not sure it would be a proper fix

[issue40452] Tkinter/IDLE: preserve clipboard on closure

2020-05-19 Thread Tal Einat
Tal Einat added the comment: During finalization, TkFinalizeThread would call DeleteWindowsExitProc (registered via TkCreateThreadExitHandler). This in turn is set as a thread-exit handler via Tcl_CreateThreadExitHandler upon the first call to TkCreateThreadExitHandler. Now we're out of Tk

[issue40452] Tkinter/IDLE: preserve clipboard on closure

2020-05-19 Thread Tal Einat
Tal Einat added the comment: Indeed, you've got that pretty much correct. The call chain is: Tk.__init__ _tkinter_create_impl (called as _tkinter.create() from Python) Tkapp_New Tkapp_New does a lot of things. In particular, it calls Tcl_CreateInterp and later Tcl_AppInit. Tcl_AppInit

[issue40452] Tkinter/IDLE: preserve clipboard on closure

2020-05-19 Thread Tal Einat
Tal Einat added the comment: Note that Tcl/Tk once had exactly the same issue on Windows, and they added specific code to "render" to the clipboard upon exit if the current app is the "clipboard owner". https://core.tcl-lang.org/tk/tktview/732662 This was fixed her

[issue40452] IDLE: preserve clipboard on closure

2020-05-19 Thread Tal Einat
Tal Einat added the comment: Looking into this further, this seems to be an issue in tkinter rather than with tcl/tk. Running `wish a.tcl` with the following simple script does leave its text in the clipboard: pack [text .t] .t insert 1.0 "Test text" clipboard clear clipboard app

[issue40452] IDLE: preserve clipboard on closure on Windows

2020-05-18 Thread Tal Einat
Tal Einat added the comment: I closed the PR but IMO this issue should remain open. I am changing the title, though, since this is not actually Windows-specific. -- ___ Python tracker <https://bugs.python.org/issue40

[issue40452] IDLE: preserve clipboard on closure

2020-05-18 Thread Tal Einat
Change by Tal Einat : -- stage: resolved -> needs patch status: closed -> open title: IDLE: preserve clipboard on closure on Windows -> IDLE: preserve clipboard on closure ___ Python tracker <https://bugs.python.or

[issue40452] IDLE: preserve clipboard on closure on Windows

2020-05-18 Thread Tal Einat
Tal Einat added the comment: I can reproduce this behavior on macOS as well, so this doesn't seem to be Windows-specific. This does not happen with other apps in general, so it is not normal behavior for apps. Testing with a minimal tkinter app (see code below) gives similar behavior, so

[issue40331] Increase test coverage for the statistics module

2020-05-13 Thread Tal Einat
Tal Einat added the comment: Steven, the conversation happened in the GitHub PR comments. The PR went through multiple iterations of code review, by both Kyle Stanley and myself, and I even waited an extra couple of weeks to see if anyone had any more comments before merging it... Perhaps

[issue40331] Increase test coverage for the statistics module

2020-05-13 Thread Tal Einat
Tal Einat added the comment: Tzanetos, thanks for the report, PR, patience iterating through several rounds of code review comments, and overall great work! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed _

[issue40331] Increase test coverage for the statistics module

2020-05-13 Thread Tal Einat
Tal Einat added the comment: New changeset b809717c1ead26b4e3693b8a5505dd8f8f666f08 by Tzanetos Balitsaris in branch 'master': bpo-40331: Increase test coverage for the statistics module (GH-19608) https://github.com/python/cpython/commit/b809717c1ead26b4e3693b8a5505dd8f8f666f08

[issue40383] weakref class name are hardcoded in reprs

2020-04-26 Thread Tal Einat
Change by Tal Einat : -- nosy: -taleinat ___ Python tracker <https://bugs.python.org/issue40383> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38580] select()'s documentation claims only sequences are accepted, but it allows all iterables

2020-04-25 Thread Tal Einat
Tal Einat added the comment: It seems pretty clear to me that we should simply update the docs as suggested. If nobody chimes in about this within a week, I intend to merge the PR (GH-16832) with the small fixes I've suggested

[issue40031] Python Configure IDLE 'Ok' and 'Apply' buttons do not seem to work.

2020-04-25 Thread Tal Einat
Tal Einat added the comment: Saaheer, it seems like you have things from older versions of IDLE in your IDLE config file (in your .idlerc directory). Specifically, the built-in extensions have all been converted to be integral parts of IDLE, and must be removed from your configuration file

[issue39089] Update IDLE's credits

2020-04-24 Thread Tal Einat
Tal Einat added the comment: Looks pretty good to me. I've been working on IDLE since... 2003/2004, beginning with a private fork of IDLE-fork. I began actually contributing to the main CPython version of IDLE in 2005. -- ___ Python tracker

[issue40031] Python Configure IDLE 'Ok' and 'Apply' buttons do not seem to work.

2020-04-24 Thread Tal Einat
Tal Einat added the comment: Saaheer, could you please run IDLE by opening a command window (Run -> cmd.exe) or PowerShell, then running `python -m idlelib`? Then when this happens, please check the command / PowerShell window to see whether an error message and/or traceback has appea

[issue38580] select()'s documentation claims only sequences are accepted, but it allows all iterables

2020-04-16 Thread Tal Einat
Tal Einat added the comment: It seems that select() does indeed support arbitrary iterables through the use of PySequence_Fast(). The commit where this was introduced, by Brett Cannon from 2003 (62dba4c2775adfb5a5a97ca012a3ab00c4e28597), doesn't seems to have intended this though

[issue28009] Fix uuid.uuid1() core logic of uuid.getnode() needs refresh

2020-03-18 Thread Tal Einat
Tal Einat added the comment: Your fix LGTM, Victor. -- ___ Python tracker <https://bugs.python.org/issue28009> ___ ___ Python-bugs-list mailing list Unsub

[issue39330] Way to build without IDLE

2020-03-13 Thread Tal Einat
Change by Tal Einat : -- nosy: -taleinat ___ Python tracker <https://bugs.python.org/issue39330> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37970] urllib.parse docstrings incomplete

2020-02-23 Thread Tal Einat
Tal Einat added the comment: Indeed. -- ___ Python tracker <https://bugs.python.org/issue37970> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39724] IDLE threading + stdout/stdin observed blocking behavior

2020-02-23 Thread Tal Einat
Tal Einat added the comment: I tend to think that we should avoid discrepancies with a simple Python command-line shell by default, and in this case I am not convinced that there is a good reason for a divergence in behavior. I'd be happy to look into debugging this issue in the next few

[issue38101] Update devguide triaging keywords

2020-02-23 Thread Tal Einat
Tal Einat added the comment: Thanks for the fix, Ido! -- nosy: +taleinat resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue38035] shared_semaphores cannot be shared across unrelated processes

2020-02-22 Thread Tal Einat
Tal Einat added the comment: I'm not convinced there is enough real need for this to justify implementing and supporting it. Using shared memory wouldn't be possible with built-in Python objects; one would have to use a special-purpose library for this, or perhaps use something like ctypes

<    1   2   3   4   5   6   7   8   9   10   >