Tal Einat added the comment:
> I *like* the CC size changes because the size indicates the indent depth.
My feeling is that you would be in a minority here. IMO most new/novice users
would find this surprising and confusing, since it is far from a customary UI
experience. Since
Tal Einat added the comment:
>> The current code and proposed changes use 'netstat -ia' to find the node
>> however if netstat needs to perform a reverse DNS query to resolve some
>> interfaces this makes using uuid1 *really* slow especially when reverse DNS
>&g
Tal Einat added the comment:
This also happens on Ubuntu 18.10, with a traceback similar to that reported on
issue #37524:
Exception ignored in:
Traceback (most recent call last):
File "Lib/idlelib/run.py", line 488, in close
File "Lib/idlelib/pyshell.py", line 1
Tal Einat added the comment:
> One way to prevent the bouncing is to fix the CC height, like it used to be.
+1 from me. I find this behavior very distracting and unnatural.
I suggest we do consider reverting rather than adding another config value
(minimum context lines), working towa
Tal Einat added the comment:
Regarding point #4, scrolling by dragging the scrollbar, note that the current
PR for adding line numbers (GH-14030) does effectively the same when dragging
on the line numbers to select lines. Therefore, if/when that PR is merged,
this will become more common
Tal Einat added the comment:
> Doesn't reproduce on Win10 with current master.
Sorry, my mistake; I meant to post that on #37551, and got mixed up.
--
___
Python tracker
<https://bugs.python.org/issu
Tal Einat added the comment:
Doesn't reproduce on Win10 with current master.
--
___
Python tracker
<https://bugs.python.org/issue37551>
___
___
Python-bug
Tal Einat added the comment:
To those following this issue, PR GH-14030 is now in a very good state, and
would benefit from more feedback.
--
___
Python tracker
<https://bugs.python.org/issue17
Tal Einat added the comment:
New changeset a2cf88efc417f1991720856f6913d16660e48941 by Tal Einat (Miss
Islington (bot)) in branch '3.7':
bpo-36390: simplify classifyws(), rename it and add unit tests (GH-14500)
https://github.com/python/cpython/commit/a2cf88efc417f1991720856f6913d16660e48941
Tal Einat added the comment:
New changeset 242ad1f375bf564c35cf99cd754b2c5819c4d056 by Tal Einat (Miss
Islington (bot)) in branch '3.8':
bpo-36390: simplify classifyws(), rename it and add unit tests (GH-14500)
https://github.com/python/cpython/commit/242ad1f375bf564c35cf99cd754b2c5819c4d056
Change by Tal Einat :
--
versions: +Python 3.7, Python 3.9
___
Python tracker
<https://bugs.python.org/issue36390>
___
___
Python-bugs-list mailing list
Unsub
Tal Einat added the comment:
> I propose to merge PR 12481 first, after review, with tests, and then include
> name change with rewrite in PR 14500.
I've gone ahead and merged PR GH-14500 into master, since it was ready to get
and a clear improvement. I've already merged this into
Tal Einat added the comment:
New changeset 9b5ce62cac27fec9dea473865d79c2c654312957 by Tal Einat in branch
'master':
bpo-36390: simplify classifyws(), rename it and add unit tests (GH-14500)
https://github.com/python/cpython/commit/9b5ce62cac27fec9dea473865d79c2c654312957
Change by Tal Einat :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Tal Einat added the comment:
New changeset 46c2eff5adca7dc309f077ec65faf95b95c47b43 by Tal Einat (Miss
Islington (bot)) in branch '2.7':
bpo-34369: make kqueue.control() docs better reflect that timeout is
positional-only (GH-9499)
https://github.com/python/cpython/commit
Tal Einat added the comment:
New changeset d3747fd8fa91b768b73b60f2e2a14044e5404afa by Tal Einat (Miss
Islington (bot)) in branch '3.7':
bpo-34369: make kqueue.control() docs better reflect that timeout is
positional-only (GH-9499)
https://github.com/python/cpython/commit
Tal Einat added the comment:
New changeset 79042ac4348ccc09344014f20dd49401579f8795 by Tal Einat in branch
'master':
bpo-34369: make kqueue.control() docs better reflect that timeout is
positional-only (GH-9499)
https://github.com/python/cpython/commit
Change by Tal Einat :
--
versions: +Python 3.8, Python 3.9 -Python 3.6
___
Python tracker
<https://bugs.python.org/issue34369>
___
___
Python-bugs-list mailin
Change by Tal Einat :
--
pull_requests: -14503
___
Python tracker
<https://bugs.python.org/issue37559>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
stage: patch review ->
type: -> behavior
___
Python tracker
<https://bugs.python.org/issue37559>
___
___
Python-bugs-list
Change by Tal Einat :
--
keywords: +patch
pull_requests: +14503
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/14030
___
Python tracker
<https://bugs.python.org/issu
New submission from Tal Einat :
With code context shown, scrolling a window by dragging the scrollbar causes
the scrollbar's tab to "jump around" and sometimes some "flashing" visual
artifacts.
The "flashing" appears to occur only before the screen is resized
Tal Einat added the comment:
Doesn't reproduce on Win10 with current master.
--
___
Python tracker
<https://bugs.python.org/issue37524>
___
___
Python-bug
New submission from Tal Einat :
Observed on macOS 10.14.5 with Python 3.8 from python.org, and with latest
master branch.
Reproduction:
1. Open IDLE
2. "New File" (Cmd-Shift-n on macOS)
3. Quit using Cmd-q ("Quit Python" from the menu doesn't cause this!)
The exception
Change by Tal Einat :
--
keywords: +patch
pull_requests: +14482
pull_request: https://github.com/python/cpython/pull/14675
___
Python tracker
<https://bugs.python.org/issue37
Tal Einat added the comment:
Thanks for helping to move this forward, Louie!
My worry with this approach is that all of the line numbers are redrawn upon
scrolling, which would be likely to make scrolling less smooth, especially on
low-end hardware (where IDLE is relatively often used
Change by Tal Einat :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Tal Einat added the comment:
New changeset fcf1d003bf4f0100c9d0921ff3d70e1127ca1b71 by Tal Einat in branch
'master':
bpo-26806: add 30 to the recursion limit in IDLE's shell (GH-13944)
https://github.com/python/cpython/commit/fcf1d003bf4f0100c9d0921ff3d70e1127ca1b71
Tal Einat added the comment:
I've made some significant improvements in several aspects:
1. Scrolling: performance and behavior
2. Selection entire lines by dragging over line numbers
3. Color config: a separate highlighting setting for line numbers, which takes
effect immediately
I've
Tal Einat added the comment:
> Looks like a black belt always on the left side, this makes me feel a bit
> oppressive.
This currently uses the same colors as the code-context panes, which is
configurable as the "context" fg/bg colors. We might find a better name for
t
Tal Einat added the comment:
Ned, thanks for taking a look!
If it is decided to go forward with this then I will make sure to make the menu
item state consistent with that of each window.
--
___
Python tracker
<https://bugs.python.org/issue17
Tal Einat added the comment:
I'm rather surprised at the lack of enthusiasm for this here and on idle-dev! I
was sure people would be happy to see this finally approaching completion after
so many years.
To clarify, all I'm waiting for now is to hear whether this change is wanted,
before I
Tal Einat added the comment:
> I propose to merge PR 12481 first, after review, with tests, and then include
> name change with rewrite in PR 14500.
I think GH-14500 is in good shape now. I'd be happy to merge either PR with
master after the other PR is merged, so please don't worry
Tal Einat added the comment:
>> one would expect passing prompt=None to result in no prompt displayed
> I wouldn't. That's not how getpass works now, or input.
Ah, thanks for the input, Steve. In that case, this should likely not be
Tal Einat added the comment:
Hi Kyle,
First off, thanks for bringing this up, and for taking our feedback so well!
> Before attempting to create any more original issues, I'll work on existing
> issues and the suggestions of others to develop a better practical
> unde
Tal Einat added the comment:
This is a subtle change with the potential to affect more than just
performance. Also, in this case, the performance is likely negligible in every
actual use-case.
This might actually be more correct, though. For example, one would expect
passing prompt=None
Tal Einat added the comment:
I agree with Serhiy: In this case, it seems to me that "explicit is better than
implicit" should be the guiding principle.
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.o
Change by Tal Einat :
--
pull_requests: +14317
pull_request: https://github.com/python/cpython/pull/14500
___
Python tracker
<https://bugs.python.org/issue36
Tal Einat added the comment:
Looking at the code yet again, there are several places where replacing
classifyws() as I suggested would make it clunkier. So let's leave it there, at
least in editor.py.
Still, the classifyws() implementation can be greatly simplified. See PR
GH-14500
Tal Einat added the comment:
> 1. The name `formatregion` could probably be improved.
FormatRegion is good enough, and is consistent with FormatParagraph.
> 2. The `classifyws` method is a module level method in editor. It's needed
> in `formatregion` also, so I made a copy (
Tal Einat added the comment:
I think there is a general flaw with the suggested implementation approach.
An infinite loop as currently suggested seems dangerous to me. For example, it
could cause a program to stall indefinitely in some unforeseen edge-case. I
don't think this would
Change by Tal Einat :
--
components: +Library (Lib)
versions: +Python 3.9 -Python 3.7
___
Python tracker
<https://bugs.python.org/issue36656>
___
___
Python-bug
Tal Einat added the comment:
Hey, I did the implementation too! :)
I'm really happy to see this fixed in time for 3.8.
--
___
Python tracker
<https://bugs.python.org/issue37
Tal Einat added the comment:
Terry, it looks like you merged a fix for this. Should this be closed?
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue36
Tal Einat added the comment:
Rémi, thanks for the great work writing the PR and quickly going through
several iterations of reviews and revisions!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Pytho
Tal Einat added the comment:
New changeset 8047e0e1c620f69cc21f9ca48b24bf2cdd5c3668 by Tal Einat (Rémi
Lapeyre) in branch 'master':
bpo-35922: Fix RobotFileParser when robots.txt has no relevant crawl delay or
request rate (GH-11791)
https://github.com/python/cpython/commit
Change by Tal Einat :
--
versions: +Python 3.9
___
Python tracker
<https://bugs.python.org/issue17535>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
In reference to previous discussion here about the effect of toggling line
numbers on future opened windows: IMO toggling shouldn't affect future windows;
those should behave according to the configured default state. The default
state should be changed only
Tal Einat added the comment:
Please see updated PR, GH-14030.
It's not 100% ready yet. At this point the goal is to have some people try it
and give feedback. So please, give it a go and let me know what you think!
--
nosy: +taleinat
___
Python
Change by Tal Einat :
--
pull_requests: +13894
stage: commit review -> patch review
pull_request: https://github.com/python/cpython/pull/14030
___
Python tracker
<https://bugs.python.org/issu
Tal Einat added the comment:
The PR is looking good, I'll likely merge it soon.
I'm quite sure this should go into 3.8, but should it be backported to 3.7?
This is certainly a bugfix, but still a slight change of behavior, so perhaps
we should avoid changing this in 3.7?
--
nosy
Tal Einat added the comment:
Now that I've looked at the PR, it should likely be merged for all relevant
branches to make the test more robust.
--
___
Python tracker
<https://bugs.python.org/issue37
Tal Einat added the comment:
Terry, we can also just revert the fix on the 2.7 branch, it's not crucial.
--
___
Python tracker
<https://bugs.python.org/issue37
Tal Einat added the comment:
Terry, I believe this can be closed now that the fix has been merged?
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue37
Tal Einat added the comment:
See PR GH-13944.
--
___
Python tracker
<https://bugs.python.org/issue26806>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
keywords: +patch
pull_requests: +13811
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/13944
___
Python tracker
<https://bugs.python.org/issu
Tal Einat added the comment:
Setting the recursion limit too low also causes issues in a plain Python
interactive session. With current master (to be 3.9) on Win10, I get issues
with values up to 6. In IDLE values up to 20 cause an immediate exception
similar to the one described by Serhiy
Tal Einat added the comment:
> 'max(n, 50)' should have been 'min(n, 50)' Tal, does you comment avove about
> the former apply when corrected to the latter?
Yes. To use your terms, I prefer incrementing over thresholding.
> This is all that is needed for getrecursionlimit.
Tal Einat added the comment:
IMO just updating the documentation would not be enough.
I suggest wrapping sys.setrecursionlimit() and *adding* 30 to the given limit,
to offset the call stack depth added by IDLE. This makes more sense to me than
max(n, 50), which I imagine would cause a lot
Change by Tal Einat :
--
components: -Documentation
versions: +Python 3.8, Python 3.9 -Python 3.5, Python 3.6
___
Python tracker
<https://bugs.python.org/issue26
Change by Tal Einat :
--
versions: +Python 3.9 -Python 3.6
___
Python tracker
<https://bugs.python.org/issue35922>
___
___
Python-bugs-list mailing list
Unsub
Tal Einat added the comment:
How about allowing '|' to be used again after '$'? Keyword arguments would be
optional by default, but if there is a '|' after the '$', then those before it
are required.
Examples:
"O|O$O|O" -- one required keyword arg and one optional one.
"
Tal Einat added the comment:
I'm not sure that changing the default value for "reuse address" justifies
breaking backwards compatibility like this. Admittedly, I'm not an expert on
networking, so perhaps there's a good reason that I'm unaware of.
As for the queue size,
Tal Einat added the comment:
The issue Irv reported happened on macOS but not on Windows. I've reproduced
his issue without this fix, and checked that this fix does indeed fix his issue.
For future reference, Irv also posted a video showing his issue on YouTube[1]
(he sent a link to idle
Tal Einat added the comment:
Given that classes already have a '__module__' attribute, using which it is
rather easy to find the filename, I don't see a good reason to add such an
attribute to classes.
IMO it would be more appropriate to directly create enhancement proposal for
IPython
Change by Tal Einat :
--
pull_requests: -13768
___
Python tracker
<https://bugs.python.org/issue37177>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
This is indeed inconsistent, but it's a minor issue that has been this way for
a long time and is easily worked around. IMO changing it would create more
problems than leaving it as-is.
IMO we should at most clarify in the docs.
--
nosy: +taleinat
Tal Einat added the comment:
The search dialog windows are now made transient relative to the editor window.
Among other things, they no longer have minimize/maximize buttons on Windows,
resolving this issue.
--
nosy: +taleinat
resolution: -> fixed
stage: patch review -> re
Change by Tal Einat :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Tal Einat added the comment:
New changeset 1b57ab5c6478b93cf4150bd8c475022252776598 by Tal Einat in branch
'2.7':
[2.7] bpo-37177: make IDLE's search dialogs transient (GH-13869)
https://github.com/python/cpython/commit/1b57ab5c6478b93cf4150bd8c475022252776598
Change by Tal Einat :
--
versions: +Python 2.7
___
Python tracker
<https://bugs.python.org/issue24039>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
pull_requests: +13758
pull_request: https://github.com/python/cpython/pull/13880
___
Python tracker
<https://bugs.python.org/issue37
Tal Einat added the comment:
New changeset 554450fb4e95066e825bdb4a2d544a490daeebdc by Tal Einat in branch
'master':
bpo-37177: make IDLE's search dialogs transient (GH-13869)
https://github.com/python/cpython/commit/554450fb4e95066e825bdb4a2d544a490daeebdc
Change by Tal Einat :
--
keywords: +patch
pull_requests: +13754
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/13869
___
Python tracker
<https://bugs.python.org/issu
Change by Tal Einat :
--
pull_requests: +13749
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/13869
___
Python tracker
<https://bugs.python.org/issu
Tal Einat added the comment:
FWIW I'm -1 on this change, due to the decision to keep IDLE simple for new
users learning Python rather than power users.
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue30
Change by Tal Einat :
--
nosy: +IrvKalb
___
Python tracker
<https://bugs.python.org/issue37177>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
See proposed fix in GH-13869.
--
___
Python tracker
<https://bugs.python.org/issue37177>
___
___
Python-bugs-list mailing list
Unsub
Change by Tal Einat :
--
keywords: +patch
pull_requests: +13745
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/13869
___
Python tracker
<https://bugs.python.org/issu
Change by Tal Einat :
--
stage: -> needs patch
type: -> behavior
versions: +Python 2.7, Python 3.7, Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/i
New submission from Tal Einat :
This issue was brought up by Irv Kalb on the idle-dev mailing list.
I haven't been able to reproduce it exactly as he described, but I have managed
to do so otherwise, and remember it happening on occasion on other computers.
This appears to happen because
Tal Einat added the comment:
Steve's suggestion sounds reasonable.
Should we just add this to the devguide, then?
--
___
Python tracker
<https://bugs.python.org/issue36
Tal Einat added the comment:
Michael, your willingness to help, and the work on this issue and PR, are
greatly appreciated!
Reading through the discussion here again, and the one referenced by Ned, I
tend to agree with the point that having *yet another* spelling for OS checking
is perhaps
Tal Einat added the comment:
See an implementation in PR GH-13678.
--
___
Python tracker
<https://bugs.python.org/issue37039>
___
___
Python-bugs-list mailin
Change by Tal Einat :
--
pull_requests: +13566
pull_request: https://github.com/python/cpython/pull/13678
___
Python tracker
<https://bugs.python.org/issue37
Tal Einat added the comment:
There a cleanly rebased PR up at GH-13648.
I'd like to get opinions from additional people about this now that the PR is
ready. Steve? Victor?
Some discussion which happened in PR comments:
Andrew Svetlov approved the changes for the asyncio tests.
Stefan
Change by Tal Einat :
--
pull_requests: +13542
pull_request: https://github.com/python/cpython/pull/13648
___
Python tracker
<https://bugs.python.org/issue36
Tal Einat added the comment:
I haven't found a way to maximize a hidden window; being "zoomed" and
"withdrawn" are both considered "states" by Tk, and apparently a window cannot
be in both states simultaneously.
An alternative is, when zooming the heigh
Tal Einat added the comment:
To get the maximum available height, does Tk's wm_maxsize() not work?
https://www.tcl.tk/man/tcl8.6/TkCmd/wm.htm#M54
Answering my own question above: No, it gives the total screen height, which
doesn't ignore e.g. taskbars.
The best way to get the actual
Tal Einat added the comment:
New changeset 390d88e49c55c15fac7cdf60b649a4b9b15d189b by Tal Einat in branch
'3.7':
[3.7] bpo-19376: Added doc mentioning `datetime.strptime()` without a year
fails for Feb 29. (GH-10243)
https://github.com/python/cpython/commit
Change by Tal Einat :
--
pull_requests: +13381
___
Python tracker
<https://bugs.python.org/issue19376>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
New changeset 6cd658b1a5cb2413230dbc2d9395d20498be8518 by Tal Einat in branch
'master':
bpo-34203: FAQ: improve wording of paragraph about 2.x vs. 3.x (GH-9821)
https://github.com/python/cpython/commit/6cd658b1a5cb2413230dbc2d9395d20498be8518
Tal Einat added the comment:
Thanks everyone for seeing this through!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Tal Einat added the comment:
Susan, I agree that similarly improving the failure message for
assert_called_with would be good.
I find the final "Not called" line unclear, though. Perhaps something like the
following:
AssertionError: expected call not found.
Expected: mock(
Tal Einat added the comment:
> Is there any update on this? Will this be fixed in the next release?
There was progress made as described on this issue, but there is yet work to be
done, and no-one seems to be taking this upon themselves at the moment.
I agree that it would be great to h
Tal Einat added the comment:
After more thought, I agree that it isn't worth changing the current wording
from "Actual" to something else.
--
___
Python tracker
<https://bugs.python.o
Tal Einat added the comment:
Karthikeyan, what do you think of the suggestions by Terry and myself to
achieve alignment by replacing the word "Actual" with a longer alternative,
such as "Observed" or "Received"?
--
Change by Tal Einat :
--
pull_requests: -11816, 11817, 11818
___
Python tracker
<https://bugs.python.org/issue35500>
___
___
Python-bugs-list mailing list
Unsub
Change by Tal Einat :
--
pull_requests: -11816, 11817
___
Python tracker
<https://bugs.python.org/issue35500>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
pull_requests: -11816
___
Python tracker
<https://bugs.python.org/issue35500>
___
___
Python-bugs-list mailing list
Unsubscribe:
501 - 600 of 1433 matches
Mail list logo
