Tim Golden added the comment:
Under the covers, subprocess is calling CreateProcess so there's really not
very much we can do here, short of writing our own PATH-handling.
As a matter of fact, passing shell=True will produce the desired effect. Since
the only thing this does is to run
Tim Golden added the comment:
Fine by me
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20709
___
___
Python-bugs-list mailing list
Unsubscribe
Tim Golden added the comment:
I think we should simply take out the example, ie the part in brackets. The
statement remains true but I don't think we need to cast around for whichever
OS / filesystem happens to implement this particular setup.
--
nosy: +tim.golden
Tim Golden added the comment:
It's right there on my to-do list which is, unfortunately, not getting
any shorter.
TJG
On 01/02/2015 19:10, Steve Dower wrote:
Steve Dower added the comment:
Definitely a dup, though I don't have the number handy. There's a patch on
the other issue waiting
Tim Golden added the comment:
I'm +0.75. I think the idea's fine in principle and the patch (by
inspection) seems to do the right things.
My only concerns are: that posixmodule.c becomes even longer and more
involved; and that the benefit might not quite be great enough to
justify the added
Tim Golden added the comment:
+1 from me, then.
--
title: Add version info to python[w].exe - Add version info to python
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23018
Changes by Tim Golden m...@timgolden.me.uk:
--
assignee: - tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22028
___
___
Python-bugs
Tim Golden added the comment:
This has just come up again over on python-list:
https://mail.python.org/pipermail/python-list/2015-January/696660.html
I'm the nearest thing we have to a mimetypes maintainer at least for Windows so
I'll try to pick Steve's patch up
Tim Golden added the comment:
Steve, could you outline the need / impact for this, please? (ie can you inform
my ignorance?).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23018
Changes by Tim Golden m...@timgolden.me.uk:
--
components: +Windows
nosy: +steve.dower, tim.golden, zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23120
Tim Golden added the comment:
Likewise.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22733
___
___
Python-bugs-list mailing list
Unsubscribe
Tim Golden added the comment:
I agree that this is a fragile assertion; it's too far removed from the
CreateFileMapping call which can generate it and almost impossible to
work around (in calling code) if it should fail in the way we're seeing
in the buildbot.
I think we're better off relying
Tim Golden added the comment:
Agree with RDM: we're just passing the path through to the Windows API (on
Windows). We don't generally carry out this kind of pre-emptive check.
--
resolution: - not a bug
stage: - resolved
status: open - closed
Tim Golden added the comment:
I very much doubt that this is a Python issue as such.
Other things being equal, I would expect Harddisk\DR1 to be a CD-ROM or
some other removable disk. Using something like winobj.exe from
sysinternals should show what it expects to be on a given machine. It's
Changes by Tim Golden m...@timgolden.me.uk:
--
resolution: - not a bug
stage: needs patch - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10937
Tim Golden added the comment:
+1
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10136
___
___
Python-bugs-list mailing list
Unsubscribe:
https
Changes by Tim Golden m...@timgolden.me.uk:
--
assignee: - tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21652
___
___
Python-bugs
Tim Golden added the comment:
Only if you have something better to put in its place! That commit was
fixing an existing problem; perhaps not your problem, but someone's. To
revert it would simply move the pain around.
I hope to be able to work on this fairly soon. If anyone else wants
Tim Golden added the comment:
Steve -- re changes to PCBuild c.: worth liaising with Zach Ware (and, to a
lesser extent, me) as he's been working through a number of things in that area
and I know has other ideas.
Just post a patch and nosy us both (zach.ware / tim.golden)
Obviously, if it's
Tim Golden added the comment:
Here's a patch against build_ssl which uses subprocess.check_output and very
slightly simplifies the output. It successfully finds ActivePerl and builds
from source; and uses the svn export files when it's not.
I've targetted the development branch; don't know
Tim Golden added the comment:
I've just looked at issue21141 which is a substantial rework of this
area. This change should be incorporated over there as well / instead.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10752
Tim Golden added the comment:
I'm at least +0 on this, not because I've ever been that bothered by the Perl
messages, but because it tidies things up a little smooths the way very
slightly for people trying to build Python on Windows and I'm always ready to
support
Tim Golden added the comment:
Thanks for the check. Committed to 3.4 default
--
resolution: - fixed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10752
Changes by Tim Golden m...@timgolden.me.uk:
--
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10752
Tim Golden added the comment:
Fixed. Thanks for the report
--
resolution: - fixed
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21452
Tim Golden added the comment:
Builds tests ok here on a fresh checkout (of cpython openssl-1.0.1g)
--
nosy: +tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21462
Tim Golden added the comment:
+1 for Kristjan's latest patch. And thanks for working this through, Kristjan:
I'd missed the fact that the microseconds conversion could itself overflow even
an unsigned long.
--
___
Python tracker rep
Tim Golden added the comment:
s/Py_LONG_LONG/PY_LONG_LONG/
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20737
___
___
Python-bugs-list mailing
Tim Golden added the comment:
What effect does your patch have on a VS2010 build? VS2010 is the official
toolset for current Python 3.x versions so any changes we make must support
that.
Also: does the same problem occur on the development branch?
(De-selecting 3.2 as it's in security-fix
Tim Golden added the comment:
I can confirm that the attached test.py times out after 2150 seconds (ie
30+ minutes) with your (tweaked) patch applied:
python test.py 2150
Running Debug|Win32 interpreter...
2014-05-08 10:33:53.670091
Expected to time out by 2014-05-08 11:09:43.670091
Timed Out
Tim Golden added the comment:
Attached project patch seems to build successfully on VS2010. It's possible
that this failed in some way on VS2008; AFAICT it hasn't been touched since
Brian first ported it two years ago.
Adding Zach Ware for a second opinion.
--
nosy: +zach.ware
Added
Tim Golden added the comment:
The attached patch adds an example to the shutil documentation showing how to
use an onerror handler to reattempt the removal of a read-only file. It's
deliberately low-tech and simply removes the attribute and retries. If there's
some other obstacle
Changes by Tim Golden m...@timgolden.me.uk:
--
keywords: +patch
Added file: http://bugs.python.org/file35168/issue19643-doc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19643
Tim Golden added the comment:
The attached patch uses DWORD (essentially: unsigned long) in
condvar.h:PyCOND_TIMEDWAIT.
Adding Kristjan as it was his code.
--
keywords: +patch
nosy: +kristjan.jonsson
Added file: http://bugs.python.org/file35169/issue20737.condvar.patch
Changes by Tim Golden m...@timgolden.me.uk:
--
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20737
___
___
Python-bugs-list
Tim Golden added the comment:
I'm at least +0.5 on this: I rather like the idea of forcing these things out
into the open.
The reason I'm not +1 is the danger of relatively benign or trivial
warnings-turned-errors getting in the way of real, possibly critical,
development
Tim Golden added the comment:
eryksun: could you essay a patch? I'd be happy to review apply it.
--
nosy: +tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13702
Tim Golden added the comment:
Thanks, Zach. Updated patch.
--
assignee: - tim.golden
Added file: http://bugs.python.org/file35170/issue19643-doc.2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19643
Tim Golden added the comment:
Thanks. I'll hold off pushing until I've had a chance to run it on a
Unix system. I'm not 100% whether it will operate in the same way there.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19643
Tim Golden added the comment:
Thanks for the feedback, Kristjan. You're obviously correct in that we
can't account for timeouts greater than DWORD-size milliseconds and your
proposed solution looks reasonable.
However, I'd like to close off *this* particular issue which turns on
the implicit
Tim Golden added the comment:
Just to be clear: the change *I'm* proposing for this issue has nothing
to do with limiting the wait, artificially or otherwise. It's simply
undoing an unintended conversion from unsigned to signed and back again,
whicih currently causes any wait of more than
Changes by Tim Golden m...@timgolden.me.uk:
--
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19643
Tim Golden added the comment:
Updated patch with unsigned long applied throughout
--
Added file: http://bugs.python.org/file35173/issue20737.condvar.2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20737
Tim Golden added the comment:
Thanks, eryksun: failed experiments are still useful data for future
reference!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18314
Tim Golden added the comment:
Use CryptReleaseContext to release Crypt handle on Windows
--
resolution: - fixed
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21393
Changes by Tim Golden m...@timgolden.me.uk:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21440
Tim Golden added the comment:
Well PyBytes_GET_SIZE is documented as returning a Py_ssize_t so I'd say it's
perfectly valid.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21442
Tim Golden added the comment:
To be honest I can't get excited about this one. The only sensible change is to
remove the rather specific comment about ValueError and just leave the fact
that only certain signals are valid.
Because the C code defines module-level constants on the basis
Tim Golden added the comment:
Ok, so to move this forward we have essentially two proposals:
1) Add a remove_readonly flag
2) Add a doc example which shows how to use the onerror handler to remove a
recalcitrant file.
I'm -0.5 on (1) because it feels like Windows-specific clutter; and +0
Tim Golden added the comment:
Fixed by issue9291
--
resolution: - duplicate
stage: - resolved
status: open - closed
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20758
Changes by Tim Golden m...@timgolden.me.uk:
--
nosy: -tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1528593
___
___
Python-bugs-list
Tim Golden added the comment:
In thread_nt.h:EnterNonRecursiveMutex the millisecond version (here: 2148000)
of the seconds you passed in are converted to microseconds (so: 214800).
This is then passed to condvar.h:PyCOND_TIMEDWAIT which expects a long, whose
32-bit limit is 2147483647. So
Tim Golden added the comment:
Fixed in 3.4 and later; 3.3 is no longer accepting patches
--
resolution: - fixed
stage: - resolved
status: open - closed
versions: +Python 3.4 -Python 3.3
___
Python tracker rep...@bugs.python.org
http
Tim Golden added the comment:
Closing, as no-one's come back after my -0 for 6 months.
--
resolution: - wont fix
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5717
Tim Golden added the comment:
Zach -- you've done most of the work on the VS projects lately. Would you mind
having a look at this one to see if it's still relevant, please?
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http
Tim Golden added the comment:
This is essentially superseded now by the work done over on distutils-sig and
by the PyPA. (Which has included considering the differeng terminology of
installation vs other paths on Windows vs Unix).
--
resolution: - wont fix
stage: needs patch
Tim Golden added the comment:
I can confirm that this crashes on Windows as well. Failure actually occurs in
gcmodule.c:finalize_garbage. Adding Guido as it looks as it's tied to asyncio.
--
nosy: +Guido.van.Rossum, tim.golden
___
Python tracker rep
Tim Golden added the comment:
Unfortunately it looks as though this wasn't the correct way to close a Crypto
handle. It isn't a conventional handle and we be using CryptReleaseContext to
close it. cf
http://msdn.microsoft.com/en-us/library/windows/desktop/aa382041%28v=vs.85%29.aspx
Changes by Tim Golden m...@timgolden.me.uk:
--
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21393
___
___
Python-bugs-list
Changes by Tim Golden m...@timgolden.me.uk:
--
resolution: fixed -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21393
___
___
Python-bugs-list
New submission from Tim Golden:
At present test_zipfile uses shutil.rmtree to remove its test artefacts. This
intermittently but frequently fails to remove cleanly on a Windows development
box. Changing it to use the test.support helper functions should reduce the
incidence
Changes by Tim Golden m...@timgolden.me.uk:
--
keywords: +patch
Added file: http://bugs.python.org/file35156/issue21440.test_zipfile.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21440
Tim Golden added the comment:
Same goes for test_tarfile (updated patch attached)
--
Added file: http://bugs.python.org/file35157/issue21440.test_tarzipfile.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21440
Tim Golden added the comment:
Adding Zach as another Windows dev
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21440
Tim Golden added the comment:
Thanks, Zach. I was aware that calloc was in the air, but I wasn't sure
if it had been committed and I'd delayed on this enough so I thought I'd
push for now. We can always revisit.
--
___
Python tracker rep
Tim Golden added the comment:
Thanks. I get them enough that it stops a test run being particularly
useful, especially when I've just touched something (eg unlink) which
might conceivably affect something like tarfile.
--
___
Python tracker rep
Tim Golden added the comment:
Buildbots seem happy. Thanks very much for the patches!
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18314
Tim Golden added the comment:
Thanks for the research, eryksun. As long as it doesn't hurt let's leave
it as is for now.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18314
Tim Golden added the comment:
The crypto stuff's not really my area. I agree that the patch looks sane.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21393
Tim Golden added the comment:
Yes, now that the custom allocator / tracing stuff is in place:
otherwise there's no way for custom allocation or tracing to occur.
Please go ahead and rework the patch when you have the time.
Also, since the setup of the reparse header is such an underdocumented
Tim Golden added the comment:
Fixed by issue9291
--
resolution: - duplicate
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21138
Tim Golden added the comment:
I updated the docs to emphasise that the file parameter to marshal.dump must be
a real file, not a wrapper.
--
assignee: - tim.golden
status: open - closed
___
Python tracker rep...@bugs.python.org
http
Changes by Tim Golden m...@timgolden.me.uk:
--
assignee: - tim.golden
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9291
Tim Golden added the comment:
I'm just pinging #python-dev to see if there's a way to request a buildbot
build from a specific server-side clone.
Meanwhile, though, I definitely introduced a change into your code which I
thought I had reverted, but clearly hadn't! The code, as committed
Tim Golden added the comment:
Committed. Thanks for the patch.
--
resolution: - fixed
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21349
Tim Golden added the comment:
Backed out the commits after all the Windows buildbots broke. Need to look
further. (No problems on a Win7 or Ubuntu build here).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18314
Tim Golden added the comment:
Here are a couple:
http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/4423
http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/8288
--
___
Python tracker rep...@bugs.python.org
Tim Golden added the comment:
I can confirm that the problem (which really is a hard crash) only applies to
2.7 and that the patch tests and fixes it. I'm happy to apply. Any objections?
--
assignee: - tim.golden
nosy: +tim.golden
___
Python
Tim Golden added the comment:
This looks like a duplicate of issue9291; could you test the latest patch over
there, please?
--
assignee: - tim.golden
nosy: +tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21138
Changes by Tim Golden m...@timgolden.me.uk:
Removed file: http://bugs.python.org/file34925/issue9291.7.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9291
Tim Golden added the comment:
Another version of the patch: this one, in addition to removing the unnecessary
encodes, also does the check for extensions before attempting to open the
registry key, and narrows down the try-catch block to just the attempt to read
the Content Type value
Tim Golden added the comment:
+1
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19962
___
___
Python-bugs-list mailing list
Unsubscribe:
https
Tim Golden added the comment:
The attached patch issue9291.7.patch (which is essentially an amalgam of
9291.patch 9291a.patch with some tweaks of my own) does appear to solve the
issue. My Windows setup is UK, so if any of the people still watching this
issue could test against a non-English
Tim Golden added the comment:
All tests pass on 3.5 and in an unelevated prompt. I'll have a closer look at
the code tomorrow.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18314
Tim Golden added the comment:
I haven't looked at the patch, but +1 to anything which brings
Tcl/Tk/Tix support into a state of default usability. Thanks for picking
this up, Zachary.
--
___
Python tracker rep...@bugs.python.org
http
Tim Golden added the comment:
Larry Hastings would have to rule on whether it could get into 3.4 at
this stage.
Paul: are you in a position to apply / test the patch? I've done no more
than glance at it but it looks, from the comments, as though it doesn't
apply cleanly
Tim Golden added the comment:
Thanks, Larry. Martin's already nosy this issue, but really we need to
see if we have a viable patch before making decisions about 3.4. I'll
take you off the nosy list.
--
___
Python tracker rep...@bugs.python.org
http
Changes by Tim Golden m...@timgolden.me.uk:
--
nosy: -larry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing
Tim Golden added the comment:
I'll have a look at this in a week or so when I'm back on-line.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18314
Tim Golden added the comment:
I'll try to look at this soonish. Thanks for bringing it back to the
surface.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9291
Changes by Tim Golden m...@timgolden.me.uk:
--
versions: -Python 2.6, Python 3.1, Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19940
Tim Golden added the comment:
Fine with your volumepathname patch. The core of the code was contributed and I
didn't check it too carefully as it clearly worked. (For some definition of
worked).
--
___
Python tracker rep...@bugs.python.org
http
Tim Golden added the comment:
Thanks, guys; I'm afraid I only watched the stable buildbots when I committed -
the AIX doesn't seem to be included.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19634
Tim Golden added the comment:
This, unfortunately, is the classic edge-case where intra-platform consistency
and inter-platform consistency clash.
I (on Windows) would certainly be surprised if a tree delete removed read-only
files without my specifying some kind of override. I understand
Tim Golden added the comment:
TBH I'm still fairly -0 and edging towards -0.5. If we didn't already
have two keyword args I might be convinced towards a jfdi=True flag.
But, as the OP described, the current params already allow for a
workaround of sorts and another param of the semantics
Tim Golden added the comment:
marshal.c does a check that the 2nd arg is a subclass of the builtin file
class. On non-Posix platforms, TemporaryFile is a wrapper class providing
context manager support for delete-on-close. This fails the subclass test.
The docs for TemporaryFile:
http
Changes by Tim Golden m...@timgolden.me.uk:
--
resolution: - wont fix
stage: - committed/rejected
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19630
Tim Golden added the comment:
On 14/11/2013 00:21, Laurent Birtz wrote:
Is it reasonable to believe that most Python programs don't care
about the legacy shell API?
No more than it is to believe that most Python programs don't care about
MSys or Cygwin ;)
For information, cmd.exe
Tim Golden added the comment:
Only just been reminded of this one; it's possible that it's been superseded by
Issue15207. At the least, that issue resulted in a code change in this area of
mimetypes. I'll have a look later.
--
nosy: +tim.golden
Tim Golden added the comment:
I've committed the changes with a variant of the pre-1900 test running on all
platforms. I think there's scope for more testing of the boundary conditions of
strftime but that would be for another issue. I want to get this one in now as
it's a crasher on Windows
101 - 200 of 601 matches
Mail list logo