Tim Golden added the comment:
Thanks: final outdated comments removed
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10197
Tim Golden added the comment:
Closing this as won't fix. The code has been reimplemented and additional
documentation has been added over at issue10197. Given that these are legacy
functions, I don't propose to do any more here.
--
resolution: - wont fix
status: open - closed
Changes by Tim Golden m...@timgolden.me.uk:
--
assignee: - tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13674
___
___
Python-bugs
Changes by Tim Golden m...@timgolden.me.uk:
--
components: +Windows
versions: +Python 3.4 -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13674
Tim Golden added the comment:
Attached is a patch with tests
--
keywords: +patch
Added file: http://bugs.python.org/file32516/issue13674.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13674
Tim Golden added the comment:
On 06/11/2013 15:23, STINNER Victor wrote:
+if (strchr(y, outbuf[1]) buf.tm_year 0)
hum... why not simply outbuf[1] == 'y' ? It would be more explicit
and less surprising.
Ummm. I have no idea what I was thinking about there. I think it was
somehow
Tim Golden added the comment:
Applied to 3.3 3.4. Thanks for the patch.
--
resolution: - fixed
stage: - committed/rejected
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19464
Changes by Tim Golden m...@timgolden.me.uk:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19464
___
___
Python-bugs-list
Tim Golden added the comment:
Code tests now work on Windows. Applied to 3.3 3.4.
--
resolution: - fixed
stage: test needed - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10197
Tim Golden added the comment:
This has nearly been fixed by the rewrite of the get[status]output code under
issue10197. There is an issue, though, with the use there of universal_newlines
mode, which forces check_output to return a string rather than bytes.
--
nosy: +tim.golden
Tim Golden added the comment:
The code I've just committed to issue10197 means that the get[status]output
functions now pass their (few) tests on all platforms. More by chance than
judgement, that change employed universal_newlines which has the effect of
forcing the output of check_output
Changes by Tim Golden m...@timgolden.me.uk:
--
assignee: - tim.golden
versions: +Python 3.3, Python 3.4 -Python 3.1, Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9922
Changes by Tim Golden m...@timgolden.me.uk:
Added file: http://bugs.python.org/file32483/issue9922.34.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9922
Tim Golden added the comment:
Good point. I've added the versionchanged tag.
The issue with bytes-string encoding goes all the way back to
Popen.communicate if universal newlines mode is used so I've simply put
in a reference to the existing notes on the subject higher up in the docs
Changes by Tim Golden m...@timgolden.me.uk:
--
assignee: - tim.golden
versions: +Python 3.4 -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10197
Tim Golden added the comment:
Patched according to Nick Coghlan's suggestion in
http://bugs.python.org/issue9922#msg150093. Ad hoc tests look ok on Windows.
I'll add tests look at *nix later.
--
Added file: http://bugs.python.org/file32450/issue10197.diff
Tim Golden added the comment:
Fixed in 3.3 / 3.4
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
versions: -Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19418
Changes by Tim Golden m...@timgolden.me.uk:
--
assignee: - tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19464
___
___
Python-bugs
Tim Golden added the comment:
Fine by me
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19433
___
___
Python-bugs-list mailing list
Unsubscribe
Tim Golden added the comment:
Fixed. Thanks for the report.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14255
Tim Golden added the comment:
Applied. Thanks for the patch.
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15792
Changes by Tim Golden m...@timgolden.me.uk:
Removed file: http://bugs.python.org/file32390/audioop.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19418
Tim Golden added the comment:
The attached patch (using Tim Peters' -1 trick) builds tests ok on Win32/64
Linux 32.
--
Added file: http://bugs.python.org/file32400/issue19418.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Tim Golden added the comment:
Good point. Updated patch.
--
Added file: http://bugs.python.org/file32401/issue19418.2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19418
Changes by Tim Golden m...@timgolden.me.uk:
Removed file: http://bugs.python.org/file32400/issue19418.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19418
Tim Golden added the comment:
If you can put together a self-contained test case which fails on
3.3/3.4 I'm quite happy to re-open this. Given the nature of the issue,
you'll have to be quite precise as to Windows version, whether 32/64,
whether running as Administrator, and exact Python
Changes by Tim Golden m...@timgolden.me.uk:
--
stage: patch review - committed/rejected
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19273
New submission from Tim Golden:
Modules/audioop.c is giving compile warnings on Windows against lines 18 437.
..\Modules\audioop.c(18): warning C4146: unary minus operator applied to
unsigned type, result still unsigned
..\Modules\audioop.c(437): warning C4146: unary minus operator applied
Tim Golden added the comment:
The attached patch appears to fix the problem.
--
keywords: +patch
Added file: http://bugs.python.org/file32390/audioop.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19418
Tim Golden added the comment:
I don't think it will, given MS description of the compiler warning:
http://msdn.microsoft.com/en-us/library/4kh09110%28v=vs.100%29.aspx
but I'll certainly give it a go.
--
___
Python tracker rep...@bugs.python.org
Tim Golden added the comment:
Good idea. I'll test against Win32/64 Linux 32
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19418
Tim Golden added the comment:
Done. Thanks for the patch.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19273
Tim Golden added the comment:
Fixed on tip. Thanks for the issue and the original patch.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4905
Tim Golden added the comment:
This is, in principle, a backwards-incompatible change as any code will stop
working which relies on exec* running useful tools in c:\bin. (I have a
c:\tools which is basically the same thing).
Frankly, I'm -0 on changing it; it does no real harm that I can see
Changes by Tim Golden m...@timgolden.me.uk:
Removed file: http://bugs.python.org/file32338/issue14255.2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14255
Tim Golden added the comment:
New patch, tested on Windows Linux
--
Added file: http://bugs.python.org/file32362/issue14255.3.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14255
Tim Golden added the comment:
Applied. Thanks for the patch.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13234
Tim Golden added the comment:
Just revisited this to see if I could close off. One thing occurred to me which
should have come up before: this situation will be aggravated by WOW64 file
redirection.
If I run 64-bit Python on 64-bit Windows I can successfully stat links in
%windir%\system32
Tim Golden added the comment:
I've looked this over and, basically, +1. We could argue the toss back and
forth over changes, but I think the changes do the right amount of
cruft-clearing and avoid the danger of being a mere reflection of one person's
aesthetic choices over another's
Tim Golden added the comment:
Retargetted patch against current tip. If no-one objects I'll commit this in
the next day or two.
--
assignee: - tim.golden
Added file: http://bugs.python.org/file32326/pcbuild.diff.2
___
Python tracker rep
Changes by Tim Golden m...@timgolden.me.uk:
--
nosy: -tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11566
___
___
Python-bugs-list
Changes by Tim Golden m...@timgolden.me.uk:
--
nosy: -tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6839
___
___
Python-bugs-list
Changes by Tim Golden m...@timgolden.me.uk:
--
nosy: -tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14112
___
___
Python-bugs-list
Changes by Tim Golden m...@timgolden.me.uk:
--
nosy: -tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6335
___
___
Python-bugs-list
Changes by Tim Golden m...@timgolden.me.uk:
--
nosy: -tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2889
___
___
Python-bugs-list
Changes by Tim Golden m...@timgolden.me.uk:
--
nosy: -tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6672
___
___
Python-bugs-list
Changes by Tim Golden m...@timgolden.me.uk:
--
nosy: -tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16472
___
___
Python-bugs-list
Tim Golden added the comment:
Just housekeeping some Windows calls: Antoine, your last comment suggests that
this is no longer an issue. I don't have a VirtualBox install to test, so can
you confirm whether this can be closed?
--
___
Python tracker
Changes by Tim Golden m...@timgolden.me.uk:
--
nosy: -tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue949667
___
___
Python-bugs-list
Changes by Tim Golden m...@timgolden.me.uk:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10179
___
___
Python-bugs-list
Changes by Tim Golden m...@timgolden.me.uk:
--
resolution: - out of date
stage: - committed/rejected
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10179
Tim Golden added the comment:
I'm running Win7 and have the same problem, with a fresh checkout and the eol
extension disabled. The attached (updated) patch does solve the issue. I can't
see any reason not to apply it, even if it's not needed in many cases.
--
Added file: http
Changes by Tim Golden m...@timgolden.me.uk:
--
resolution: - wont fix
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18221
Tim Golden added the comment:
I'm going to close this as won't fix: the underlying implementation is simply
calling GetFullPathName and removal of trailing spaces doesn't seem too
surprising a result. It is possible to manipulate such files using Windows'
special \\?\C:\... syntax.
While I
Changes by Tim Golden m...@timgolden.me.uk:
--
nosy: -tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16632
___
___
Python-bugs-list
Tim Golden added the comment:
normpath doesn't really buy anything here as abspath already has the same
effect (plus more). Patch attach removes normcase|path leaving only abspath.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Tim Golden added the comment:
If no-one objects, I'll commit in a day or two.
--
Added file: http://bugs.python.org/file32328/issue14255.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14255
Tim Golden added the comment:
Santoso Wijaya: sorry for the delay. If you'd like to retarget your patch
against the tip, I'm happy to apply. At this stage, 3.3 and 3.4 seem the
appropriate branches.
--
assignee: - tim.golden
versions: -Python 2.7, Python 3.2
Changes by Tim Golden m...@timgolden.me.uk:
--
nosy: -tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14208
___
___
Python-bugs-list
Changes by Tim Golden m...@timgolden.me.uk:
--
nosy: -tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16353
___
___
Python-bugs-list
Changes by Tim Golden m...@timgolden.me.uk:
--
nosy: -tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18199
___
___
Python-bugs-list
Changes by Tim Golden m...@timgolden.me.uk:
--
nosy: -tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14027
___
___
Python-bugs-list
Changes by Tim Golden m...@timgolden.me.uk:
--
assignee: - tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4905
___
___
Python-bugs-list
Changes by Tim Golden m...@timgolden.me.uk:
--
versions: +Python 3.4 -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4905
___
___
Python
Tim Golden added the comment:
Thanks, Zachary. Do you see this going against just tip, or should it be
backported to 3.3 / 2.7? (I'm not sure how well the latter would be
received, truth be told).
--
___
Python tracker rep...@bugs.python.org
http
Changes by Tim Golden m...@timgolden.me.uk:
Removed file: http://bugs.python.org/file32328/issue14255.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14255
Tim Golden added the comment:
Added, including a slightly surprising change needed to test_zipimport_support
(which arguably should have been there from the start for robustness).
--
assignee: - tim.golden
Added file: http://bugs.python.org/file32338/issue14255.2.diff
Tim Golden added the comment:
Fine. I'll commit it later. (Probably tomorrow at this point)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19273
Tim Golden added the comment:
Had a to-and-fro on IRC with RDM who highlighted that an inconsistency between
os.listdir and os.path.exists (the case here) is, at least, undesirable. As it
stands, our os.exists on os.stat mechanism will fail because any attempt to get
any kind of handle via
Tim Golden added the comment:
I don't feel strongly about this. However, ISTM that we work reasonably
hard to work with the vagaries of *nix toolchains so I don't see why an
unintrusive change like this shouldn't go in to support some corner
cases on the Windows front
Tim Golden added the comment:
Ok by me: build and tests all ok.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17791
___
___
Python-bugs-list
Tim Golden added the comment:
Just picking this up. Considering testing... My current proposal is to add
junction point support to _winapi, initially for the sole purpose of testing
this change, but with a view to possibly supporting it formally via the os
module. Any better ideas
Tim Golden added the comment:
Sounds like a decent plan to me. Good luck with the buffer sizing!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18314
Tim Golden added the comment:
*cough* Somehow that didn't actually get pushed. Rebased against 2.7, 3.3 3.4
and pushed.
--
assignee: - tim.golden
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
versions: -Python 3.2
Tim Golden added the comment:
This was implemented after discussion in issue1115886:
http://bugs.python.org/issue1115886
and python-dev:
https://mail.python.org/pipermail/python-dev/2007-March/071557.html
In short, it could have gone either way and it went this way.
--
nosy
Changes by Tim Golden m...@timgolden.me.uk:
--
resolution: - wont fix
stage: - committed/rejected
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19191
Tim Golden added the comment:
I was surprised that GetVersionEx would lie. But sure enough. Here:
http://social.msdn.microsoft.com/Forums/windowsdesktop/en-US/c471de52-611f-435d-ab44-56064e5fd7d5/windows-81-preview-getversionex-reports-629200
(Including a heartfelt comment by long-time Python
Tim Golden added the comment:
I've just installed a Win 8.1 VM and can (unsurprisingly) confirm the
report: The ver command shows 6.3.9600 while GetVersionEx and
consequently sys.getwindowsversion report 6.2.9200
We do use GetVersionEx in a few other places (timemodule.c,
unicodeobject.c
Tim Golden added the comment:
platform.platform platform.uname are also affected although they already use
ver-parsing in some circumstances so could presumably fallback to that
approach here as well.
--
nosy: +lemburg
___
Python tracker rep
Tim Golden added the comment:
In reality (as I'm sure you can guess) it's just that no-one's got to
the point of fixing it. I did start off, but it's not a trivial fix and
clearly it got sidelined (with no-one shouting). Sometimes that's just
the way it is.
I'll see if I can dig out whatever
Tim Golden added the comment:
Nope. Looks like a mistake. Confusingly, the header refers to VC++ 10.0
which is VS 2010 (I think). AFAICT a global s/2008/2010/ would be the
thing to do.
--
___
Python tracker rep...@bugs.python.org
http
Tim Golden added the comment:
I'll try to pick this one up over the next few days. Feel free to ping me if it
drops into silence!
--
assignee: - tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18314
Tim Golden added the comment:
It doesn't work on Python 2.x either as delivered. Usually means you
have an external readline module installed.
--
nosy: +tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19089
Tim Golden added the comment:
I'm at best +0.25, but I don't have a problem with Ctrl-D exiting on
Windows, as it doesn't do anything else!
The thing is, though, that this is all handled within
myreadline.c:my_fgets which is a call into the system fgets which errors
out with Ctrl-Z
Tim Golden added the comment:
Closing as Works for me in the absence of any clear proposal for docs
improvement.
--
resolution: - works for me
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Tim Golden added the comment:
I can confirm that 2.7.2 hard-crashes as described on Windows. I'm not
sure if I have the wherewithal to build 2.7 on this laptop to see if
it's fixed in tip.
3.3 simply raises an IOError.
--
___
Python tracker rep
Tim Golden added the comment:
Thanks for the review, Ben. Updated patches attached.
1 3) default_encoding -- Your two points appear to contradict each
other slightly. What's in the updated patches is: 3.x has no encoding
(because everything's unicode end-to-end); 2.7 attempts to apply
Tim Golden added the comment:
I attach a patch against 3.3; this is substantially Dave Chambers' original
patch with a trivial test added and a doc change. This means that HKCR is
scanned to determine extensions and these will override anything in the
mimetypes db. The doc change highlights
Tim Golden added the comment:
Here's an updated patch against trunk with tests doc changes
--
status: languishing - open
Added file: http://bugs.python.org/file31165/issue2528.2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Tim Golden added the comment:
... and to answer Amaury's question in msg109871 it creates a reasonable
consistency between the results of os.access and the user's actual ability to
read / write a file. eg, you might have no permissions whatsoever on the file
but as long as it wasn't read-only
Changes by Tim Golden m...@timgolden.me.uk:
Removed file: http://bugs.python.org/file9919/os_access-r62091.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2528
Tim Golden added the comment:
I propose to close this one: using Python 3.3 on Win7 I can successfully stat
NTFS Junctions. Is there any remaining issue?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18306
Tim Golden added the comment:
Fixed. Thanks for the patch
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9035
Changes by Tim Golden m...@timgolden.me.uk:
Removed file: http://bugs.python.org/file31092/issue9035.3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9035
Changes by Tim Golden m...@timgolden.me.uk:
Removed file: http://bugs.python.org/file31087/issue9035.2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9035
Tim Golden added the comment:
4th and hopefully final patch. Added tests for byte paths. Reworked the ismount
so it uses the original detection approach first (which is wholly lexical) and
drops back to the volume path technique only if the path doesn't appear to be a
drive or a share root
Changes by Tim Golden m...@timgolden.me.uk:
--
assignee: tim.golden -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4708
___
___
Python-bugs-list
Tim Golden added the comment:
This one seems to have been fixed by the importlib rebuild. I haven't bothered
to trace the code path, but certainly import nul returns the expected
ImportError: No module named 'nul' in both Debug Release builds.
--
resolution: - works for me
stage
Changes by Tim Golden m...@timgolden.me.uk:
--
assignee: tim.golden -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2889
___
___
Python-bugs-list
Changes by Tim Golden m...@timgolden.me.uk:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16921
201 - 300 of 601 matches
Mail list logo
