Yury Selivanov <yseliva...@gmail.com> added the comment:
> The idea which this issue represents is not rejected. It is a good one, we
> found a need for it during the dev sprint last September.
Well, not everybody thinks it is a good one. I, for instance, don't think it's
a g
Yury Selivanov <yseliva...@gmail.com> added the comment:
I think I've fixed that. Can you give me a script to repro?
--
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Change by Yury Selivanov <yseliva...@gmail.com>:
--
resolution: -> rejected
stage: patch review -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<https://bu
Yury Selivanov <yseliva...@gmail.com> added the comment:
New changeset 29fd9eae432a54c963262e895b46f081f238539a by Yury Selivanov (Miss
Islington (bot)) in branch '3.7':
Revert "bpo-31356: Add context manager to temporarily disable GC GH-5495 (#5496)
https://github.com/python/cpy
Yury Selivanov <yseliva...@gmail.com> added the comment:
New changeset 383b32fe108ea627699cc9c644fba5f8bae95d73 by Yury Selivanov in
branch 'master':
Revert "bpo-31356: Add context manager to temporarily disable GC GH-5495
https://github.com/python/cpy
Yury Selivanov <yseliva...@gmail.com> added the comment:
Since I'm going to be unavailable for the next 10 days, and I don't want this
to be accidentally forgotten, I'll do the revert myself. Opened a PR for that.
--
assignee: rhet
Change by Yury Selivanov <yseliva...@gmail.com>:
--
pull_requests: +5328
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue31356>
___
Yury Selivanov <yseliva...@gmail.com> added the comment:
New changeset 78767786a87b00925506c32b3b55cf65b56ef3d7 by Yury Selivanov (Miss
Islington (bot)) in branch '3.7':
bpo-32436: Fix compiler warning (GH-5483) (GH-5486)
https://github.com/python/cpython/
Yury Selivanov <yseliva...@gmail.com> added the comment:
New changeset 55e0839f2672e029c2b96514028c77c31ffbe41f by Yury Selivanov in
branch 'master':
bpo-32436: Fix compiler warning (#5483)
https://github.com/python/cpython/commit/55e0839f2672e029c2b96514028c77c31f
Change by Yury Selivanov <yseliva...@gmail.com>:
--
pull_requests: +5314
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32436>
___
Yury Selivanov <yseliva...@gmail.com> added the comment:
Yeah, please submit a PR
--
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Yury Selivanov <yseliva...@gmail.com> added the comment:
Andrew, I'm indifferent about this feature. It's entirely up to you if you
want to merge it in 3.7. I already used up my allowance for post-beta1 feature
merges.
--
___
Python tracke
Yury Selivanov <yseliva...@gmail.com> added the comment:
Raymond, do you need help with reverts?
--
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Yury Selivanov <yseliva...@gmail.com> added the comment:
> Let's get it into master for 3.8 first and then we'll have something to
> discuss.
The PR has a "versionadded" tag. If you plan to allow this, Andrew can
Yury Selivanov <yseliva...@gmail.com> added the comment:
The PR is LGTM. Up to Ned to allow this in 3.7. I agree that the feature is
(a) trivial, (b) new, so it's safe to go in 3.7.
--
___
Python tracker <rep...@bugs.python.or
Yury Selivanov <yseliva...@gmail.com> added the comment:
OK, makes sense. Can you submit a PR?
--
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Yury Selivanov <yseliva...@gmail.com> added the comment:
How will such test look like? I'm still not sure we need it.
--
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Yury Selivanov <yseliva...@gmail.com> added the comment:
Or to use assertWarnsRegex
--
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Yury Selivanov <yseliva...@gmail.com> added the comment:
I think assertWarns just handles it. Maybe the test should be converted to use
it?
--
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Change by Yury Selivanov <yseliva...@gmail.com>:
--
priority: normal -> high
stage: -> needs patch
type: security -> behavior
versions: -Python 3.4, Python 3.5
___
Python tracker <rep...@bugs.python.org>
<https://bu
Yury Selivanov <yseliva...@gmail.com> added the comment:
Nathaniel, this seems to be related to coro-origin-tracking.
--
nosy: +njs
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Yury Selivanov <yseliva...@gmail.com> added the comment:
> But, more importantly, this is a new feature so it doesn't break any existing
> code.
I imagine you're almost done with the beta-1 release, Ned, so I'd hate to
create more work for you here. Let's re
Yury Selivanov <yseliva...@gmail.com> added the comment:
A few thoughts:
1. The merged PR releases GIL for any Python code run in `with
gc.ensure_disabled()`. This is just plain wrong.
2. The merged PR crashes on debug build of CPython.
3. I don't actually understand this feature.
Yury Selivanov <yseliva...@gmail.com> added the comment:
> The style issues and missing error checks are easy to address. We're at
> 3.7beta1 stage, it is normal to have issues to be cleaned up in a beta
> release.
I don't understand the code. Please take
Yury Selivanov <yseliva...@gmail.com> added the comment:
IMO this needs to be pulled from 3.7. Ned?
--
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Yury Selivanov <yseliva...@gmail.com> added the comment:
Just noting here: the original PR was a little bit under-reviewed: return
values of C functions were not checked, and the code style was very far from
PEP 7.
--
___
Python tracke
Change by Yury Selivanov <yseliva...@gmail.com>:
--
pull_requests: +5288
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue31356>
___
Yury Selivanov <yseliva...@gmail.com> added the comment:
A bug found by coverity:
(PyErr_WarnEx might error out; please update the code to handle that)
*** CID 1428756: Error ha
Change by Yury Selivanov <yseliva...@gmail.com>:
--
resolution: fixed ->
stage: resolved ->
status: closed -> open
___
Python tracker <rep...@bugs.python.org>
<https://bu
Yury Selivanov <yseliva...@gmail.com> added the comment:
A couple defects reported by coverity:
** CID 1428758: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
/Modules/_xxsubinterpretersmodule.c: 45 in _coe
Yury Selivanov <yseliva...@gmail.com> added the comment:
Hm, maybe I'm mistaken here, but I have no time right now to confirm.
I'll reopen the issue so that we can consider this (and especially SEQPACKET)
for 3.8. Sorry for insta-reject :)
--
resolution: rejected ->
stage:
Yury Selivanov <yseliva...@gmail.com> added the comment:
SOCK_DGRAM is never reliable, even for AF_UNIX. It might appear reliable to
your test code, but there's no guarantee for that under any OS in Posix
standard AFAIK.
--
resolution: -> rejected
stage: -> resolved
Yury Selivanov <yseliva...@gmail.com> added the comment:
> Unless there's a burning issue, let's revisit this after beta 1.
There're no burning issues currently, last fixes to asyncio made the buildbot
happy. I'm totally fine to revisit t
Yury Selivanov <yseliva...@gmail.com> added the comment:
Duplicating my message to issue 28099 here:
TBH I don't think we need to care about OS X Tiger. I mean Apple itself
doesn't care about it anymore, the last release was 10 years ago. How about we
drop its buildbot?
I don't s
Yury Selivanov <yseliva...@gmail.com> added the comment:
TBH I don't think we need to care about OS X Tiger. I mean Apple itself
doesn't care about it anymore, the last release was 10 years ago. How about we
drop its buildbot?
--
nosy: +ysel
Change by Yury Selivanov <yseliva...@gmail.com>:
--
nosy: -yselivanov
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue20104>
___
Yury Selivanov <yseliva...@gmail.com> added the comment:
FYI
New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s)
** CID 1428733: Memory - illegal accesses (RETURN_LOCAL)
/Modules/posixmodule.c: 5281 in os_posix_spaw
Yury Selivanov <yseliva...@gmail.com> added the comment:
Closing this one now--there's no point in speeding up types.coroutine anymore.
--
resolution: -> rejected
stage: patch review -> resolved
status: open -> closed
___
Pyth
Change by Yury Selivanov <yseliva...@gmail.com>:
--
components: +Interpreter Core -asyncio
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Yury Selivanov <yseliva...@gmail.com> added the comment:
With PR https://github.com/python/cpython/pull/5410 being merged I believe this
issue can be now closed.
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Yury Selivanov <yseliva...@gmail.com> added the comment:
Merged; closing this issue.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<https://bu
Yury Selivanov <yseliva...@gmail.com> added the comment:
New changeset 2a2270db9be9bdac5ffd2d50929bf905e7391a06 by Yury Selivanov in
branch 'master':
bpo-32703: Fix coroutine resource warning in case where there's an error
(GH-5410)
https://github.com/python/cpython/
Change by Yury Selivanov <yseliva...@gmail.com>:
--
components: -asyncio
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32707>
___
Yury Selivanov <yseliva...@gmail.com> added the comment:
Hopefully the warnings will be fixed.
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<https://bu
Yury Selivanov <yseliva...@gmail.com> added the comment:
New changeset b647d7039d396b1da71ab33b101a78b53d4e6834 by Yury Selivanov in
branch 'master':
bpo-32707: Fix warnings in hamt.c (#5430)
https://github.com/python/cpython/commit/b647d7039d396b1da71ab33b101a78b53d
Yury Selivanov <yseliva...@gmail.com> added the comment:
> IMHO it's a real bug,
No. HAMT bitmap and array nodes can only store up to 32 pointers, so we use
Py_ssize_t & Py_SIZE only because those nodes are PyObject_VAR_HEAD objects.
--
stage:
Change by Yury Selivanov <yseliva...@gmail.com>:
--
keywords: +patch
pull_requests: +5265
stage: -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Yury Selivanov <yseliva...@gmail.com> added the comment:
Andrew, please take a look. I'll have very limited (to no at all) time to work
on Python in the next 2 weeks.
--
___
Python tracker <rep...@bugs.python.org>
<https://
Yury Selivanov <yseliva...@gmail.com> added the comment:
I have a feeling that using threads+IO+asyncio makes the test too unstable on
some Windows buildbots. I'll rewrite start-tls tests without using threads.
--
___
Python tracke
Yury Selivanov <yseliva...@gmail.com> added the comment:
I knew about that "if", but it never fully registered to me why it's there and
what it is protecting us from ;) So I had to debug half of ceval loop before I
stumbl
Change by Yury Selivanov <yseliva...@gmail.com>:
--
pull_requests: +5245
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue27968>
___
Yury Selivanov <yseliva...@gmail.com> added the comment:
Specifically "DeprecationWarning: get_coroutine_wrapper is deprecated" needs to
be silenced as part of this issue.
--
___
Python tracker <rep...@bugs.python.org>
&l
Yury Selivanov <yseliva...@gmail.com> added the comment:
So in issue 32703 we consider removing the check. I'll try to figure out what
to do with "coroutine ... was never awaited" warnings in test_coroutines --
probably j
Yury Selivanov <yseliva...@gmail.com> added the comment:
Nathaniel,
test_coroutines raises a bunch of Runtime and Deprecation warnings after this
PR. Could you please make a PR to silence them?
/Users/yury/dev/pydev/cpython/Lib/test/test_coroutines.py:1032: RuntimeWarning:
cor
Yury Selivanov <yseliva...@gmail.com> added the comment:
So the problem was that _PyGen_Finalize wasn't issuing any warnings if there's
any error set in the current tstate. And in Nathaniel's case, the current
error was an AttributeError('__aexit__').
This check is weird, because
Change by Yury Selivanov <yseliva...@gmail.com>:
--
keywords: +patch
pull_requests: +5243
stage: -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Yury Selivanov <yseliva...@gmail.com> added the comment:
Ah, we should never really get to WITH_CLEANUP_START; the exception should be
raised in BEFORE_ASYNC_WITH
--
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Yury Selivanov <yseliva...@gmail.com> added the comment:
So refactoring it into "c = open_file(); async with c" just prolongs the life
of the coroutine so that it's GCed outside of
WITH_CLEANUP_START/WITH_CLEANUP_FINISH block. Something weird is going o
Yury Selivanov <yseliva...@gmail.com> added the comment:
The difference between these two functions is two extra opcodes:
STORE_FAST/LOAD_FAST before BEFORE_ASYNC_WITH. With them we have a warning.
--
___
Python tracker <rep...@bugs.p
Yury Selivanov <yseliva...@gmail.com> added the comment:
Changing
async def main():
async with open_file():
pass
to
async def main():
c = open_file()
async with c:
pass
also makes it print the warning :)
Also I've made a test out of this snippet and running
Yury Selivanov <yseliva...@gmail.com> added the comment:
New changeset 1e5b25b8c0c45ccfd58da2cb82fdf231c6823fef by Yury Selivanov in
branch 'master':
bpo-23749: Make start-tls tests more stable on win7 buildbot (GH-5409)
https://github.com/python/cpython/
Change by Yury Selivanov <yseliva...@gmail.com>:
--
pull_requests: +5242
stage: resolved -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Yury Selivanov <yseliva...@gmail.com> added the comment:
New changeset 07627e9a6a5f418354ff3dc99a0f36bc5b79dcd8 by Yury Selivanov in
branch 'master':
bpo-32251: Fix docs (#5408)
https://github.com/python/cpython/commit/07627e9a6a5f418354ff3dc99a0f36bc5b
Change by Yury Selivanov <yseliva...@gmail.com>:
--
pull_requests: +5241
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32251>
___
Change by Yury Selivanov <yseliva...@gmail.com>:
--
components: +Interpreter Core -asyncio
nosy: +ncoghlan
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Change by Yury Selivanov <yseliva...@gmail.com>:
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: -> enhancement
___
Python tracker <rep...@bugs.python.org>
<https:/
Yury Selivanov <yseliva...@gmail.com> added the comment:
New changeset 9ee1bf9ab5af8233ed8ec5c53d12a29dc1bd9c9d by Yury Selivanov in
branch 'master':
bpo-32650: Add an asyncgen pdb test (#5406)
https://github.com/python/cpython/commit/9ee1bf9ab5af8233ed8ec5c53d12a29dc1
Change by Yury Selivanov <yseliva...@gmail.com>:
--
pull_requests: +5239
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32650>
___
Yury Selivanov <yseliva...@gmail.com> added the comment:
New changeset c7ab581db216aeeb1c2aa7af2f2198d2b7516383 by Yury Selivanov (Pablo
Galindo) in branch 'master':
bpo-32650 Add support for async generators and more test for coroutines in pdb
(#5403)
https://github.com/python/c
Change by Yury Selivanov <yseliva...@gmail.com>:
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<https://bu
Yury Selivanov <yseliva...@gmail.com> added the comment:
New changeset f11b460d8717fc3a5810684713b8b818f68789e8 by Yury Selivanov in
branch 'master':
bpo-32373: Add socket.getblocking() method. (#4926)
https://github.com/python/cpython/commit/f11b460d8717fc3a5810684713b8b818f6
Yury Selivanov <yseliva...@gmail.com> added the comment:
Mark, I think this still land in beta-2. Please try to figure out what's going
on on Mac OS (I have no time to take care of this myself).
--
___
Python tracker <rep...@bugs.python.or
Change by Yury Selivanov <yseliva...@gmail.com>:
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: -> enhancement
___
Python tracker <rep...@bugs.python.org>
<https:/
Yury Selivanov <yseliva...@gmail.com> added the comment:
I don't have a strong opinion on this, but I worry a bit that while the change
is trivial, it still might break something (doctests? some obscure code?) in
the next 3.6 point r
Yury Selivanov <yseliva...@gmail.com> added the comment:
New changeset 631fd38dbf04dbf0127881f3977982e401a849e4 by Yury Selivanov in
branch 'master':
bpo-32251: Implement asyncio.BufferedProtocol. (#4755)
https://github.com/python/cpython/commit/631fd38dbf04dbf0127881f3977982e401
Yury Selivanov <yseliva...@gmail.com> added the comment:
> Let's try to get it in as soon as we can, please!
Thank you, Ned! We'll get it merged in the next few days.
--
___
Python tracker <rep...@bugs.python.org>
<https
Yury Selivanov <yseliva...@gmail.com> added the comment:
New changeset 0ceb717689b04c0540d78c1ba93c0572c66c0994 by Yury Selivanov in
branch 'master':
Revert "bpo-32221: makeipaddr(): remove interface part + speedup (GH-4724)"
(#5394)
https://github.com/pytho
Yury Selivanov <yseliva...@gmail.com> added the comment:
Mark,
Two tests fail on MacOS X now (newly added tests). I'm reverting the change
for now. If you figure this out, please re-submit a PR for a quick ap
Change by Yury Selivanov <yseliva...@gmail.com>:
--
pull_requests: +5229
stage: -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Yury Selivanov <yseliva...@gmail.com> added the comment:
> Today we've all collectively made Python a better programming language.
Literally can't stop doing that for some reason... :)
--
___
Python tracker <rep...@bugs.python
Yury Selivanov <yseliva...@gmail.com> added the comment:
New changeset bec2372b7e1da5dfdbadaf242aa8e994b164cace by Yury Selivanov in
branch 'master':
bpo-32327: Revert loop.run_in_executor behaviour: return a Future. (#5392)
https://github.com/python/cpython/
Yury Selivanov <yseliva...@gmail.com> added the comment:
Why did this fix go to 3.6?
--
nosy: +yselivanov
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Change by Yury Selivanov <yseliva...@gmail.com>:
--
pull_requests: +5227
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32327>
___
Yury Selivanov <yseliva...@gmail.com> added the comment:
OK, so the trick is to first install pkg-config:
sudo port install pkgconfig
./configure
make
python -m ssl # works
I'll close the PR then, but we need to document this trick with pkg-config
som
Yury Selivanov <yseliva...@gmail.com> added the comment:
> The good news is that, since Christian's recent enhancements in Issue32598 to
> have autoconf use pkg-config to detect OpenSSL header and lib files,
> configure will now automatically find the MacPorts
Yury Selivanov <yseliva...@gmail.com> added the comment:
> It's up to the release manager, but personally it feels like you're pushing
too hard. Since you've done that frequently in the past I think we should
help you by declining your request.
NP, I totally understand.
> Now mayb
Yury Selivanov <yseliva...@gmail.com> added the comment:
> With the 3.7 beta deadline just around the corner, 3.8 will be the next
> opportunity to reconsider this idea.
Nick, Ned, Guido,
Would it be OK if we add this to 3.7beta2?
I feel kind of bad about this one... few th
Change by Yury Selivanov <yseliva...@gmail.com>:
--
keywords: +patch
pull_requests: +5223
stage: -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
New submission from Yury Selivanov <yseliva...@gmail.com>:
Not sure if we should do it or not:
1. MacPorts maintainers will create a port file for Python 3.7 and they will
just configure it with `configure --with-openssl=$PREFIX", where PREFIX is
/opt/local by default.
2. Th
Change by Yury Selivanov <yseliva...@gmail.com>:
--
components: Cross-Build
nosy: Alex.Willmer, christian.heimes, ned.deily, yselivanov
priority: normal
severity: normal
status: open
title: macos/configure: Discover OpenSSL when installed with MacPorts
type: enhancement
versions:
Yury Selivanov <yseliva...@gmail.com> added the comment:
I think we've fixed everything. Closing this for now, Victor please reopen if
buildbots misbehave.
--
resolution: -> fixed
status: open -> closed
___
Python tracker <rep...@
Change by Yury Selivanov <yseliva...@gmail.com>:
--
pull_requests: +5213
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32436>
___
Yury Selivanov <yseliva...@gmail.com> added the comment:
New changeset 2a2247ce5e1984eb2f2c41b269b38dbb795a60cf by Yury Selivanov in
branch 'master':
bpo-32622: Normalize ENOTCONN to ConnectionError on macOS (GH-5369)
https://github.com/python/cpython/
Yury Selivanov <yseliva...@gmail.com> added the comment:
Merged. Thanks, Mark!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<https://bu
Yury Selivanov <yseliva...@gmail.com> added the comment:
New changeset 47c0b1f7d4115e6f15e6776c1f91d28e7d96fe0c by Yury Selivanov
(Коренберг Марк) in branch 'master':
bpo-32221: makeipaddr(): remove interface part + speedup (GH-4724)
https://github.com/python/cpython/
Yury Selivanov <yseliva...@gmail.com> added the comment:
New changeset ee72ac0683e685b134f67cb0c6612c664ecadb65 by Yury Selivanov (Elvis
Pranskevichus) in branch 'master':
bpo-32622: Fix AbstractEventLoop.sendfile signature in documentation. (GH-5368)
https://github.com/python/cpython/
Yury Selivanov <yseliva...@gmail.com> added the comment:
> AttributeError: 'NoneType' object has no attribute 'SSLContext'
We've just pushed a fix for this.
--
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Change by Yury Selivanov <yseliva...@gmail.com>:
--
pull_requests: +5212
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32622>
___
Yury Selivanov <yseliva...@gmail.com> added the comment:
New changeset b1a6ac4c4026d648b3d948945b734a4d0f175a3c by Yury Selivanov in
branch 'master':
bpo-32622: Enforce sendfile fallback policy for FALLBACK transports (#5364)
https://github.com/python/cpython/
Change by Yury Selivanov <yseliva...@gmail.com>:
--
pull_requests: +5208
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32622>
___
801 - 900 of 3072 matches
Mail list logo
