[issue37462] Default starting directory for os.walk()

aeros167 added the comment: For any future issues, is it more appropriate to leave the issue status on pending until the proposal is approved? This may not apply if the issue was specifically mentioned or requested by a core developer, but it may be better to use pending for any original

[issue37462] Default starting directory for os.walk()

aeros167 added the comment: Oh okay, that's fair enough. I can definitely understand that assigning the current directory as the default does not provide a significant change in improved functionality, and it is not implicit that os.walk() would use the current directory as the de

[issue37462] Default starting directory for os.walk()

aeros167 added the comment: Created a new PR which sets the default value of top to the current working directory. (https://github.com/python/cpython/pull/14497) -- ___ Python tracker <https://bugs.python.org/issue37

[issue37462] Default starting directory for os.walk()

Change by aeros167 : -- keywords: +patch pull_requests: +14312 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14497 ___ Python tracker <https://bugs.python.org/issu

[issue37462] Default starting directory for os.walk()

New submission from aeros167 : As a quality of life enhancement, it would beneficial to set a default starting directory for os.walk() to use when one is not specified. I would suggest for this to be the system's current working directory. The implementation would be rather straightfo

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

aeros167 added the comment: Created a new PR replacing the deprecated method "random.choose" with "random.choice" in "test_pkg_import.py" (https://github.com/python/cpython/pull/14466). -- ___ Python tracker <h

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

Change by aeros167 : -- pull_requests: +14283 pull_request: https://github.com/python/cpython/pull/14466 ___ Python tracker <https://bugs.python.org/issue19

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

aeros167 added the comment: > Thanks for the PR, aeros167! BTW, if you want to open a new issue and > modernize the tests to use importlib directly that would be great! Sounds good, I'll definitely look into doing that after finishing up this issue. Was waiting the previous PR t

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

aeros167 added the comment: Created a PR for moving and renaming "test_pkimport". An initial approval was made, now it is awaiting core review (https://github.com/python/cpython/pull/14303). -- ___ Python tracker <https://bu

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

Change by aeros167 : -- keywords: +patch pull_requests: +14127 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/14303 ___ Python tracker <https://bugs.python.org/issu

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

aeros167 added the comment: > Yep, just make sure the tests still pass before and after the change. :) Sounds good, the first thing I had done before proposing the change was testing it in an IDE and using some logging to ensure that random.choose and random.choice were providing the s

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

aeros167 added the comment: Decided to start working on this issue, seems like a solid starting point. After submitting a minor doc contribution, I wanted to also attempt to contribute to some of the easier enhancement requests. >From my current assessment, it appears that "test_p