New submission from Shashank :
As promised in this thread
http://mail.python.org/pipermail/python-dev/2009-August/091450.html (a year
ago!), attached is a patch that replaces simple zip decryption logic written in
pure python with that in C.
As reported in the link above, this can result in
Shashank added the comment:
I have updated the patch with a check for the availability of C impl and to use
pure-py impl as a fallback.
How do you suggest would the tests change? As I had mentioned before, in my
understanding since there is no change in the API the already existing tests
Shashank added the comment:
Attached is a patch with changes in Lib/test/test_zipfile.py to test both C and
pure-py impls (on systems where the C impl is present).
Admittedly, this approach to emulating the absence of C impl is a bit hacky.
This is primarily because the changed class is not
Changes by Shashank :
Added file: http://bugs.python.org/file19197/zipdecrypt.patch
___
Python tracker
<http://bugs.python.org/issue10030>
___
___
Python-bugs-list mailin
Shashank added the comment:
>the C module should be private and therefore called _zipdecrypt
done
>if you want to avoid API mismatch, you could give a tp_call to your C
>>decrypter object, rather than a "decrypt" method
done
>- you can put all initialization code in
Shashank added the comment:
I had uploaded an incorrect patch. New corrected patch against trunk (on Mac OS
uploaded).
--
Added file: http://bugs.python.org/file19494/zipdecrypt.patch
___
Python tracker
<http://bugs.python.org/issue10
Changes by Shashank :
Removed file: http://bugs.python.org/file19494/zipdecrypt.patch
___
Python tracker
<http://bugs.python.org/issue10030>
___
___
Python-bugs-list m
Changes by Shashank :
Added file: http://bugs.python.org/file19495/zipdecrypt.patch
___
Python tracker
<http://bugs.python.org/issue10030>
___
___
Python-bugs-list mailin
New submission from Shashank :
-- Converting the discussion here
http://mail.python.org/pipermail/python-list/2010-November/1259601.html to a
bug report (+nosy for everyone that responded, quoting the initial message for
context)
Are there any promises made with regard to final state of the
Shashank added the comment:
@Raymond: I don't have a particular use case where I had a problem with this
behavior. I came across this "problem" when looking at this issue
http://bugs.python.org/issue6305.
An important problem that can happen with this behavior is that it d
Shashank added the comment:
Works fine for me in 2.6 but fails as said by OP on 2.5.
(I came across this in the course of my work and am submitting a change
in a bug for the first time, pardon me if something is inappropriate :)
I used this modified codeblock:
--
import cookielib
11 matches
Mail list logo
