[issue10019] json.dumps with indent = 0 not adding newlines

R. David Murray added the comment: Thanks, Sandro. -- assignee: bob.ippolito -> nosy: +r.david.murray resolution: accepted -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker

[issue10019] json.dumps with indent = 0 not adding newlines

Roundup Robot added the comment: New changeset 8264f68e8251 by R David Murray in branch '2.7': #10019: Fix regression relative to 2.6: add newlines if indent=0 http://hg.python.org/cpython/rev/8264f68e8251 New changeset 4a1048257995 by R David Murray in branch '3.1': #10019: Fix regression rela

[issue10019] json.dumps with indent = 0 not adding newlines

Sandro Tosi added the comment: Oh, just to say I took the version as of http://code.google.com/p/simplejson/source/detail?r=234 -- ___ Python tracker ___ __

[issue10019] json.dumps with indent = 0 not adding newlines

Changes by Sandro Tosi : Added file: http://bugs.python.org/file21632/issue10019-py2.7.patch ___ Python tracker ___ ___ Python-bugs-list maili

[issue10019] json.dumps with indent = 0 not adding newlines

Changes by Sandro Tosi : Added file: http://bugs.python.org/file21631/issue10019-py3.1.patch ___ Python tracker ___ ___ Python-bugs-list maili

[issue10019] json.dumps with indent = 0 not adding newlines

Sandro Tosi added the comment: Hi, I updated the patch, making one for 2.7, 3.1 and 3.2 (this last one applies cleanly on default too). As of merging simplejson, it's more a matter of porting it to Python 3. I'll drop an email to Bob soon, let's see how it goes. -- nosy: +sandro.tosi

[issue10019] json.dumps with indent = 0 not adding newlines

Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue10019] json.dumps with indent = 0 not adding newlines

Florent Xicluna added the comment: +1 to merge simplejson 2.1+ before 3.2 beta 1 (mid-november) -- nosy: +flox resolution: -> accepted stage: -> patch review type: -> behavior versions: +Python 3.1, Python 3.2 ___ Python tracker

[issue10019] json.dumps with indent = 0 not adding newlines

Bob Ippolito added the comment: I just applied a version of this patch with corrections to the tests here: http://code.google.com/p/simplejson/source/detail?r=234 -- ___ Python tracker

[issue10019] json.dumps with indent = 0 not adding newlines

Bob Ippolito added the comment: The test also repeats an equivalent dict to "h" in the check function. -- ___ Python tracker ___ ___

[issue10019] json.dumps with indent = 0 not adding newlines

Bob Ippolito added the comment: The test in the patch assumes a specific iteration order for the dict "h", changing the dict to have only one key would fix this problem with the test. -- ___ Python tracker __

[issue10019] json.dumps with indent = 0 not adding newlines

Amaury Forgeot d'Arc added the comment: The C encoder should not be used when indent=0. Here is a patch+test for 2.7. Note that json.dump (into a file object) already correctly emit newlines. -- keywords: +patch nosy: +amaury.forgeotdarc Added file: http://bugs.python.org/file19124/json

[issue10019] json.dumps with indent = 0 not adding newlines

Changes by Antoine Pitrou : -- assignee: -> bob.ippolito nosy: +bob.ippolito ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue10019] json.dumps with indent = 0 not adding newlines

New submission from David Janes : In Python 2.6.4, json.dumps(...,indent=0) produced newlines as documented here: http://docs.python.org/library/json.html#json.dump In Python 2.7, it no longer adds newlines. $ python Python 2.6.4 (r264:75706, Jan 13 2010, 19:41:08) [GCC 4.1.2 20080704 (Red Hat