[issue10027] os.lstat/os.stat don't set st_nlink on Windows

Brian Curtin added the comment: This code has changed a lot since originally being committed, so I'll handle backporting in #12084 which has the latest changes. -- status: open -> closed ___ Python tracker __

[issue10027] os.lstat/os.stat don't set st_nlink on Windows

Hirokazu Yamamoto added the comment: Thank you for commit! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10027] os.lstat/os.stat don't set st_nlink on Windows

Brian Curtin added the comment: Committed to py3k in r86727. I think this should be backported to the maintenance branches, but not until after the upcoming point releases. Although those branches won't have the ability to create hard links, they should have the ability to view information

[issue10027] os.lstat/os.stat don't set st_nlink on Windows

Hirokazu Yamamoto added the comment: Thank you for reply. Could you commit my last patch instead of me? I cannot commit files for a while. -- ___ Python tracker ___

[issue10027] os.lstat/os.stat don't set st_nlink on Windows

Brian Curtin added the comment: I'm not sure how that would work in terms of redistributing, and how we'd handle it within our own build process. This close to the beta I'm -1 on adding that API. -- ___ Python tracker

[issue10027] os.lstat/os.stat don't set st_nlink on Windows

Hirokazu Yamamoto added the comment: I found Win32 FileID API. With this library, it seems we can use GetFileInformationByHandleEx before Vista. We can get real file name and hard link count from handle. http://www.microsoft.com/downloads/en/details.aspx?FamilyID=1DECC547-AB00-4963-A360-E4130EC

[issue10027] os.lstat/os.stat don't set st_nlink on Windows

Brian Curtin added the comment: Works for me. I think it should be ok to commit. -- assignee: -> ocean-city ___ Python tracker ___ _

[issue10027] os.lstat/os.stat don't set st_nlink on Windows

Hirokazu Yamamoto added the comment: I created test branch "branches/py3k-stat-on-windows" and committed the new patch in r85789. This achieves msg119108. I tested this on Windows7 buildbot where symlink support exists, it seems working correct. http://www.python.org/dev/buildbot/all/builders/x8

[issue10027] os.lstat/os.stat don't set st_nlink on Windows

Hirokazu Yamamoto added the comment: I replaced my patch (almost reverted stat() part) I think st_nlink will be set via stat()/lstat(), at least. -- ___ Python tracker ___ _

[issue10027] os.lstat/os.stat don't set st_nlink on Windows

Changes by Hirokazu Yamamoto : Removed file: http://bugs.python.org/file19278/py3k_posixpath_v1.patch ___ Python tracker ___ ___ Python-bugs-l

[issue10027] os.lstat/os.stat don't set st_nlink on Windows

Changes by Hirokazu Yamamoto : Added file: http://bugs.python.org/file19290/py3k_posixpath_v1.patch ___ Python tracker ___ ___ Python-bugs-lis

[issue10027] os.lstat/os.stat don't set st_nlink on Windows

Hirokazu Yamamoto added the comment: I noticed stat() won't set S_IEXEC in stat() with my patch (py3k_posixpath_v1.patch). :-( -- ___ Python tracker ___

[issue10027] os.lstat/os.stat don't set st_nlink on Windows

Brian Curtin added the comment: I'll also give it a run on my Windows machines but won't be able to until tomorrow morning (~1300 UTC). -- ___ Python tracker ___ __

[issue10027] os.lstat/os.stat don't set st_nlink on Windows

Hirokazu Yamamoto added the comment: ... I noticed I can test this via buildbot... Probably I'll try this. -- ___ Python tracker ___

[issue10027] os.lstat/os.stat don't set st_nlink on Windows

Hirokazu Yamamoto added the comment: How about this patch? * st_nlink support for stat()/lstat(). * lstat() for junction read attributes of junction not target. * stat() for symlink of system locked file (ie: c:/pagefile.sys) should read attributes from target locked file not of symlink eve

[issue10027] os.lstat/os.stat don't set st_nlink on Windows

Jason R. Coombs added the comment: I'm unsure. I think when I addressed the issue, I was only concerned with symlinks. The Vista behavior sounds correct to me, so it may be that XP was left with the legacy behavior as it doesn't have native symlink support. It sounds as if the behavior on XP

[issue10027] os.lstat/os.stat don't set st_nlink on Windows

Brian Curtin added the comment: Jason, any idea on #2? -- nosy: +jaraco ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue10027] os.lstat/os.stat don't set st_nlink on Windows

Hirokazu Yamamoto added the comment: P.S. Thank you for acceptance. I really wanted to commit that code! -- ___ Python tracker ___ __

[issue10027] os.lstat/os.stat don't set st_nlink on Windows

Hirokazu Yamamoto added the comment: There are some questions. 1. About my patch, I noticed it removed following code. Isn't this needed? I like clean code, but I don't want to break anything. /* Get WIN32_FIND_DATA structure for the path to determine if it is a symlink */

[issue10027] os.lstat/os.stat don't set st_nlink on Windows

Brian Curtin added the comment: Overall I think this looks like a reasonable restructuring, and it works in a few manual tests of existing hardlinks on my system. Until #8879 goes in, we can't really add tests for this. Hirokazu, do you want to commit this since you came up with it?

[issue10027] os.lstat/os.stat don't set st_nlink on Windows

New submission from Brian Curtin : In msg117834 on #8879 it was noticed that os.lstat and os.stat don't set st_nlink on Windows, which is causing the patch on that issue to fail test_tarfile. Attached is a stripped down version of the patch Hirokazu Yamamoto proposed on #8879, containing just