[issue10099] socket.fromfd() documentation problem

Changes by Éric Araujo : -- resolution: invalid -> works for me ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10099] socket.fromfd() documentation problem

Senthil Kumaran added the comment: So, I assume that we just leave it as such and close the issue. I was thinking if anything needs to be updated for function __doc__ but even there 'the duplicate' word is explained. -- resolution: -> invalid stage: -> committed/rejected status: open

[issue10099] socket.fromfd() documentation problem

Gergely Kálmán added the comment: You are perfectly right, the docs are pretty clear. Although fromfd means (or at least to me) to "attach object to fd" and not "duplicate then attach to the duplicate". If someone forgets this particular behaviour and thinks that the function works as the nam

[issue10099] socket.fromfd() documentation problem

Senthil Kumaran added the comment: I think, the original docs *is* pretty intuitive. It says "Duplicate the file descriptor fd and build a socket object". No one will think that the this method will close the original fd. Person using this method might of course, explicitly close the origina

[issue10099] socket.fromfd() documentation problem

Changes by Daniel Stutzbach : -- nosy: +stutzbach ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue10099] socket.fromfd() documentation problem

Kálmán Gergely added the comment: Forgot to add that the changes should be applied to all versions if accepted. synapse -- ___ Python tracker ___ __

[issue10099] socket.fromfd() documentation problem

New submission from Kálmán Gergely : socket.fromfd()'s behaviour is somewhat counter-intutive and should contain a note to warn the user that it'll leave the original FD open. This is important if someone forgets to manually close the file descriptor as it might lead to FD leaks (and kernel me