[issue10252] Fix resource warnings in distutils

Roundup Robot added the comment: New changeset c02c78d93a2e by Éric Araujo in branch '2.7': Fix double use of f.close(). http://hg.python.org/cpython/rev/c02c78d93a2e -- ___ Python tracker

[issue10252] Fix resource warnings in distutils

Roundup Robot added the comment: New changeset 85fefd41ef5d by Éric Araujo in branch '3.2': Fix double use of f.close(). http://hg.python.org/cpython/rev/85fefd41ef5d -- nosy: +python-dev ___ Python tracker __

[issue10252] Fix resource warnings in distutils

Éric Araujo added the comment: These constructs don’t generate warnings at present but should IMO use the with statement too: ./distutils/command/upload.py:128: open(filename+".asc").read()) ./distutils/command/bdist_rpm.py:514: spec_fil

[issue10252] Fix resource warnings in distutils

Éric Araujo added the comment: No file object was created for stdin, so my patch was buggy. Fixed in r86438, r86439, r86440. Thanks to Antoine and Brian. -- ___ Python tracker __

[issue10252] Fix resource warnings in distutils

Éric Araujo added the comment: Ported to 3.1 and 2.7 in r86433 and r86434. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker _

[issue10252] Fix resource warnings in distutils

Éric Araujo added the comment: Thanks for the patch. r86276 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10252] Fix resource warnings in distutils

Changes by Brian Curtin : Added file: http://bugs.python.org/file19524/fix_pipe_close.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue10252] Fix resource warnings in distutils

Éric Araujo added the comment: Committed to py3k in r86274, after “LGTM” from Brian on IRC. Will backport if buildbots don’t scream at me. -- ___ Python tracker ___ __

[issue10252] Fix resource warnings in distutils

Changes by Éric Araujo : -- resolution: fixed -> stage: committed/rejected -> patch review status: closed -> open ___ Python tracker ___

[issue10252] Fix resource warnings in distutils

Éric Araujo added the comment: The tests don’t pass on a Windows buildbot (thanks Antoine): I was mistaken about subprocess.Popen, it has no close method like os.popen objects. Attached patch should fix it, can someone kindly review and/or test it? -- nosy: +pitrou Added file: http:/

[issue10252] Fix resource warnings in distutils

Éric Araujo added the comment: [Pp]open objects closed in r86234. All fixes ported to 3.1 in r86237, 2.7 in r86238. Cheers! -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed versions: +Python 2.7, Python 3.1

[issue10252] Fix resource warnings in distutils

Éric Araujo added the comment: (Not closing yet: Some calls of os.popen and subprocess.Popen are still to be fixed, and then there’s the backport.) -- ___ Python tracker ___ __

[issue10252] Fix resource warnings in distutils

Éric Araujo added the comment: Fixed in the py3k branch in r86223, r86224 and r86226. Thanks for the report and starting patch. Eric: This compatibility policy was instated because a newer version of distutils may be used/is often used to install distributions for older Pythons. In the 2.x

[issue10252] Fix resource warnings in distutils

Eric Smith added the comment: Is it really true that 3.x's distutils is source compatible with 2.3? For 3.x I'd like to see the with statement used. -- nosy: +eric.smith ___ Python tracker ___

[issue10252] Fix resource warnings in distutils

Brian Brazil added the comment: I don't see your patch on the other bug, so I've updated mine not to use with. -- Added file: http://bugs.python.org/file19470/distutils_fd_leak_v2.patch ___ Python tracker

[issue10252] Fix resource warnings in distutils

Brian Curtin added the comment: The patch shouldn't use context managers, as distutils claims to support 2.3. #10290 contains a similar patch which doesn't use 'with'. (Sorry to duplicate efforts here, forgot to search...) -- nosy: +brian.curtin status: pending -> open __

[issue10252] Fix resource warnings in distutils

Éric Araujo added the comment: Thanks for the patch, I’ll review it and commit it soon. -- assignee: tarek -> eric.araujo status: open -> pending title: Fix resource warnings in distutil tests -> Fix resource warnings in distutils ___ Python tracker