[issue10340] asyncore doesn't properly handle EINVAL on OSX

Brett Cannon added the comment: I'm assuming that the buildbots stabilized so I'm going to go ahead and close this. -- nosy: +brett.cannon status: open -> closed ___ Python tracker

[issue10340] asyncore doesn't properly handle EINVAL on OSX

Devin Cook added the comment: This looks resolved. Can it be closed? -- nosy: +devin ___ Python tracker ___ ___ Python-bugs-list maili

[issue10340] asyncore doesn't properly handle EINVAL on OSX

Giampaolo Rodola' added the comment: http://hg.python.org/cpython/rev/0b960e41e533 Let's see how it goes. -- ___ Python tracker ___ _

[issue10340] asyncore doesn't properly handle EINVAL on OSX

R. David Murray added the comment: Better, but not stable: http://www.python.org/dev/buildbot/all/builders/AMD64%20OpenIndiana%203.2/builds/984/steps/test/logs/stdio http://www.python.org/dev/buildbot/all/builders/x86%20OpenIndiana%203.2/builds/998/steps/test/logs/stdio -- __

[issue10340] asyncore doesn't properly handle EINVAL on OSX

Giampaolo Rodola' added the comment: Sorry about that. It should now be fixed. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue10340] asyncore doesn't properly handle EINVAL on OSX

Roundup Robot added the comment: New changeset e35a5bbb0b91 by Giampaolo Rodola' in branch 'default': fix failing asyncore test as per http://bugs.python.org/issue10340#msg156586 http://hg.python.org/cpython/rev/e35a5bbb0b91 -- ___ Python tracker

[issue10340] asyncore doesn't properly handle EINVAL on OSX

R. David Murray added the comment: This appears to be causing buildbot failures: http://www.python.org/dev/buildbot/all/builders/x86%20debian%20parallel%203.x/builds/4077 http://www.python.org/dev/buildbot/all/builders/AMD64%20Gentoo%20Wide%203.x/builds/3520 -- keywords: +buildbot sta

[issue10340] asyncore doesn't properly handle EINVAL on OSX

Changes by Giampaolo Rodola' : -- assignee: -> giampaolo.rodola priority: high -> normal resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker __

[issue10340] asyncore doesn't properly handle EINVAL on OSX

Roundup Robot added the comment: New changeset 13cefcbcc7da by Giampaolo Rodola' in branch 'default': fix #10340: properly handle EINVAL on OSX and also avoid to call handle_connect() in case of a disconnetected socket which is not meant to connect. http://hg.python.org/cpython/rev/13cefcbcc7d

[issue10340] asyncore doesn't properly handle EINVAL on OSX

Roundup Robot added the comment: New changeset 8c1fd9276b25 by Giampaolo Rodola' in branch '3.2': issue 10340 - forgot to update Misc/NEWS http://hg.python.org/cpython/rev/8c1fd9276b25 -- ___ Python tracker __

[issue10340] asyncore doesn't properly handle EINVAL on OSX

Roundup Robot added the comment: New changeset e2cddb3f4526 by Giampaolo Rodola' in branch '3.2': fix #10340: properly handle EINVAL on OSX and also avoid to call handle_connect() in case of a disconnetected socket which is not meant to connect. http://hg.python.org/cpython/rev/e2cddb3f4526 N

[issue10340] asyncore doesn't properly handle EINVAL on OSX

Roundup Robot added the comment: New changeset 8c19c9914c22 by Giampaolo Rodola' in branch '2.7': fix #10340: properly handle EINVAL on OSX and also avoid to call handle_connect() in case of a disconnetected socket which is not meant to connect. http://hg.python.org/cpython/rev/8c19c9914c22 -

[issue10340] asyncore doesn't properly handle EINVAL on OSX

Changes by Terry J. Reedy : -- versions: +Python 3.3 -Python 3.1 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10340] asyncore doesn't properly handle EINVAL on OSX

R. David Murray added the comment: "Might even make sense" to backport doesn't sound like a definite, so I've removed 2.6 and 2.5 from versions. You'll want to ask the release managers for a decision if you want to backport. -- nosy: +r.david.murray _

[issue10340] asyncore doesn't properly handle EINVAL on OSX

Changes by R. David Murray : -- versions: -Python 2.5, Python 2.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue10340] asyncore doesn't properly handle EINVAL on OSX

Giampaolo Rodola' added the comment: Forgot to attach the patch. -- Added file: http://bugs.python.org/file19523/asyncore.patch ___ Python tracker ___ __

[issue10340] asyncore doesn't properly handle EINVAL on OSX

Changes by Giampaolo Rodola' : -- nosy: +josiah.carlson versions: +Python 2.5 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue10340] asyncore doesn't properly handle EINVAL on OSX

Giampaolo Rodola' added the comment: While writing a test case for this I found out another problem in asyncore: handle_connect was erroneously called when the dispatcher delegates the connection to a handler resulting in ENOTCONN being raised. Patch in attachment targeted for python 2.7 shoul

[issue10340] asyncore doesn't properly handle EINVAL on OSX

Stephen Hansen added the comment: I can verify the problem exists in asyncore at release27-maint on the mac, and that the below patch fixes it. After applying, I ran a full regrtest and nothing new broke. -- ___ Python tracker

[issue10340] asyncore doesn't properly handle EINVAL on OSX

New submission from Giampaolo Rodola' : http://code.google.com/p/pyftpdlib/issues/detail?id=143 This comes from a user who sent me a report via e-mail. Unfortunately I don't have an OSX box to test against. Code which should replicate the problem is this: import socket, struct s = socket.socke