Berker Peksag added the comment:
This has been fixed in issue 12853. The relevant line is here:
https://hg.python.org/cpython/file/2.7/Lib/distutils/command/upload.py#l179
Closing this one as a duplicate.
--
nosy: +berker.peksag
resolution: -> duplicate
stage: needs patch -> resolved
Changes by Nilovna Bascunan-Vasquez cont...@nilovna.com:
--
nosy: +nilovna
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10367
___
___
Éric Araujo mer...@netwok.org added the comment:
Sorry for overlooking this. The test is good, I could trigger the bug with it
and then fix it with the patch.
Would you mind adding the same test for upload_docs? The code was originally
copied from upload, so we should test it too.
Philip:
Daniel Tavares danielmtava...@gmail.com added the comment:
Hey Éric,
Just wanted to check with you about the status of this issue. Any chance this
could be reviewed? It's been idle since December and it's still listed as
needs patch.
Thanks,
Daniel
--
Changes by R. David Murray rdmur...@bitdance.com:
--
priority: - normal
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10367
___
___
Daniel Tavares danielmtava...@gmail.com added the comment:
Here goes the test. Feel free to make any comments, critiques or suggestions,
since this is my first take on this code base.
--
versions: -3rd party
Added file: http://bugs.python.org/file19981/test_10367.diff
Phillip J. Eby p...@telecommunity.com added the comment:
Given that this is a pure bugfix to revert a problem in 2.7 -- where no *new*
development is being done -- a test isn't actually needed for this patch.
There is no point in holding up a distutils1 fix for distutils2's benefit.
Daniel:
Phillip J. Eby p...@telecommunity.com added the comment:
Committed Daniel's patch to r86978 in the 2.7 maintenance branch.
(The 2.x trunk still has this bug, but is permanently closed to new checkins.)
--
stage: needs patch - committed/rejected
versions: -3rd party, Python 3.1, Python
Brian Curtin cur...@acm.org added the comment:
a test isn't actually needed for this patch.
This is incorrect.
--
nosy: +brian.curtin
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10367
Tarek Ziadé ziade.ta...@gmail.com added the comment:
Philip, Eric is currently assigned to this issue, and was working on a test,
obviously.
It means that commiting a fix without a test without asking him first is is
quite rude.
He and I are maintaining Distutils. Your help is welcome but
Daniel Tavares danielmtava...@gmail.com added the comment:
I'll gladly work on the test, unless someone is working on it already. I
apologize for not sending it originally along with the patch. Since Eric
only requested the diff, I thought a test wasn't needed.
Cheers,
Daniel
On Fri, Dec 3,
Changes by Éric Araujo mer...@netwok.org:
Removed file: http://bugs.python.org/file19930/unnamed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10367
___
Éric Araujo mer...@netwok.org added the comment:
Thanks Daniel. The links in my last message should get you started, and any
questions are welcome.
You may be interested in this sprint:
http://wiki.montrealpython.org/index.php/Packaging_no.10 I will be on IRC for
some hours that night.
Phillip J. Eby p...@telecommunity.com added the comment:
Whoops, my bad... I misread Eric's earlier message as throwing it back onto
*Daniel* to produce a test, not that *he* (Eric) was working on the test.
IOW, I thought that progress had been stalled a second time on this, and went
ahead
Éric Araujo mer...@netwok.org added the comment:
You understood right: I asked for a test using the mock PyPI server in
distutils2. “I can’t do it” is a valid reply, in which case it would have been
picked up by someone else or me.
You could say that progress has stalled, but there was no
Tarek Ziadé ziade.ta...@gmail.com added the comment:
Ugh sorry I thought Eric was working on a test. I misunderstood.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10367
___
Phillip J. Eby p...@telecommunity.com added the comment:
The urgency was only that I didn't want the other contributors to this issue to
feel as though the bar on their contributions were being raised higher every
time they jumped the previous bar.
IOW, I did it to make them feel like
Daniel Tavares danielmtava...@gmail.com added the comment:
Here's an updated patch, which fixes the passing of multiple arguments to
self.announce, based on Priscila's fix.
--
nosy: +daniel.tavares
Added file: http://bugs.python.org/file19913/10367.diff
Éric Araujo mer...@netwok.org added the comment:
Thanks Daniel. I have good and bad news for this patch.
The bad news is that I don’t want to accept patches without tests. We need to
stop guessing or experimenting with the real PyPI to fix bugs.
The good news is that we have a mock PyPI
Priscila Manhaes pmnh...@gmail.com added the comment:
Well, I fixed the problem moving the if that instances result even though
it getting HTTPError into the try.
--
# send the data
try:
result = urlopen(request)
Éric Araujo mer...@netwok.org added the comment:
Thank you for the fix Priscila. Can you submit it as a diff file? (guidelines
on http://www.python.org/dev/patches/)
Tarek: I wonder if we should backport pydoc_server from d2 to test behavior
bugs like this one.
--
Changes by Priscila Manhaes pmnh...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file19690/10367.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10367
___
Phillip J. Eby p...@telecommunity.com added the comment:
It looks to me as though this patch reintroduces issue9199, as it passes
multiple arguments to self.announce() once again. The patch needs to be made
against the SVN version of Python, not the released version.
--
Changes by Éric Araujo mer...@netwok.org:
--
superseder: distutils upload command crashes when displaying server response -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10367
___
Phillip J. Eby p...@telecommunity.com added the comment:
To better show what the problem is, here's a change that would fix the problem
(albeit in an ugly way):
--- upload.py 2010-07-07 20:16:33.0 -0400
+++ /home/pje/upload.new2010-11-09 14:30:21.0 -0500
@@ -167,6
New submission from Jesús Cea Avión j...@jcea.es:
Uploading a new release of one of my libraries to PYPI I got this error:
Submitting dist/bsddb3-5.1.1.tar.gz to http://pypi.python.org/pypi
Upload failed (400): A file named bsddb3-5.1.1.tar.gz already exists for
bsddb3-5.1.1. To fix problems
Éric Araujo mer...@netwok.org added the comment:
Thanks for the report. Can you paste your message and exact Python version on
#9199?
--
nosy: +eric.araujo
resolution: - duplicate
stage: needs patch - committed/rejected
status: open - closed
superseder: - distutils upload command
Jesús Cea Avión j...@jcea.es added the comment:
This is not issue9199, even covering the same line code.
In this case the problem is an exception leaving a local variable undefined,
crashing later.
--
___
Python tracker rep...@bugs.python.org
28 matches
Mail list logo
