Terry J. Reedy tjre...@udel.edu added the comment:
Added tweak to .__chain_b to avoid creating list of b2j.keys and .items be
deleting from b2j in separate loop after creating sets. Test with timeit
suggests time about same with 1% deletion. r87276
--
resolution: - fixed
status: open
Terry J. Reedy tjre...@udel.edu added the comment:
Added version-added and committed. r86983
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10534
___
Changes by Terry J. Reedy tjre...@udel.edu:
--
stage: commit review - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10534
___
___
Terry J. Reedy tjre...@udel.edu added the comment:
Deprecated isbjunk and isbpopular methods, ran doc and unit tests, and
committed as r87000. Still need to add 'gone in 3.3 test' when revise unittests.
--
___
Python tracker rep...@bugs.python.org
Terry J. Reedy tjre...@udel.edu added the comment:
News entry for both commits: r87001
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10534
___
Eli Bendersky eli...@gmail.com added the comment:
Terry,
Attaching a patch with the following:
1. Added unittest assertions for bjunk and bpopular data attributes.
2. Minor markup formatting fixes in one paragraph of the doc difflib.rst
--
Added file:
Terry J. Reedy tjre...@udel.edu added the comment:
Here is a pretty minimal patch to expose bjunk and bpopular as attributes and
document them along with b2j, which is already exposed but not documented.
I suppose the proposed paragraph could be formatted as a list, perhaps after
Georg Brandl ge...@python.org added the comment:
Don't worry about doc additions too much; all doc changes can be considered bug
fixes.
In this patch, it appears that two of the three attributes are new? They
should get a versionadded.
--
___
New submission from Terry J. Reedy tjre...@udel.edu:
Expose and document the junk and popular sets as attributes of the
SequenceMatcher object.
self.junk = junk
self.popular = popular
Deprecate the then unneeded and undocumented isbjunk and isbpopular functions,
currently defined as
