[issue10637] Calling CloseHandle twice (Modules/posixmodule.c)

Hirokazu Yamamoto added the comment: Committed in r87117(py3k). -- priority: release blocker -> resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue10637] Calling CloseHandle twice (Modules/posixmodule.c)

Changes by Hirokazu Yamamoto : -- Removed message: http://bugs.python.org/msg123461 ___ Python tracker ___ ___ Python-bugs-list mailin

[issue10637] Calling CloseHandle twice (Modules/posixmodule.c)

Hirokazu Yamamoto added the comment: Well, I'm not sure. I didn't realize it while running python_d.exe. I just realized it while re-reading source code. MSDN says, (http://msdn.microsoft.com/en-us/library/ms724211%28VS.85%29.aspx) > If the application is running under a debugger, the function

[issue10637] Calling CloseHandle twice (Modules/posixmodule.c)

Georg Brandl added the comment: OK, I would say this is an acceptable bug in a beta release. Will fix it after the release is done. -- ___ Python tracker ___ _

[issue10637] Calling CloseHandle twice (Modules/posixmodule.c)

Martin v. Löwis added the comment: quick followup: there is a chance that this closes the wrong file due to race conditions, in case a different thread opens a file in-between that gets the same handle. Due to the GIL, this is unlikely -- ___ Pytho

[issue10637] Calling CloseHandle twice (Modules/posixmodule.c)

Martin v. Löwis added the comment: The second CloseHandle call will fail. As we are not checking the CloseHandle result, this has no further consequences, AFAICT. -- ___ Python tracker ___

[issue10637] Calling CloseHandle twice (Modules/posixmodule.c)

Georg Brandl added the comment: What is the result of calling it twice? -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue10637] Calling CloseHandle twice (Modules/posixmodule.c)

Martin v. Löwis added the comment: > Very sorry, I created the bug calling CloseHandle twice > in Modules/posixmodule.c. I think this should be fixed > before beta1 released. Can I commit it? Even if you commit it now, it won't get into beta1: the Windows binaries for that are already built. -

[issue10637] Calling CloseHandle twice (Modules/posixmodule.c)

New submission from Hirokazu Yamamoto : Very sorry, I created the bug calling CloseHandle twice in Modules/posixmodule.c. I think this should be fixed before beta1 released. Can I commit it? -- components: None files: posixmodule.diff keywords: needs review, patch messages: 123452 nosy: