[issue10740] sqlite3 module should allow DDL statements in transactions

2013-04-04 Thread mike bayer
Changes by mike bayer mike...@zzzcomputing.com: -- nosy: +zzzeek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10740 ___ ___ Python-bugs-list

[issue10740] sqlite3 module should allow DDL statements in transactions

2013-01-26 Thread Tshepang Lekhonkhobe
Changes by Tshepang Lekhonkhobe tshep...@gmail.com: -- nosy: +tshepang ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10740 ___ ___

[issue10740] sqlite3 module should allow DDL statements in transactions

2012-10-18 Thread Jeremy Banks
Changes by Jeremy Banks jer...@jeremybanks.ca: -- nosy: +Jeremy Banks ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10740 ___ ___ Python-bugs-list

[issue10740] sqlite3 module should allow DDL statements in transactions

2011-09-17 Thread Mark Bucciarelli
Mark Bucciarelli m...@crosscutmedia.com added the comment: Opened http://bugs.python.org/issue12997 in case there is a way to solve the foreign_key PRAGMA issue with a less disruptive fix. -- nosy: +Mark.Bucciarelli ___ Python tracker

[issue10740] sqlite3 module should allow DDL statements in transactions

2011-05-20 Thread Torsten Landschoff
Torsten Landschoff t.landsch...@gmx.net added the comment: I updated the patch for upstream pysqlite2. Available at http://code.google.com/p/pysqlite/issues/detail?id=24 Patch over there is for Python 2 (tested with our production Python 2.6). --

[issue10740] sqlite3 module should allow DDL statements in transactions

2011-03-30 Thread Torsten Landschoff
Torsten Landschoff t.landsch...@gmx.net added the comment: The attached patch is an updated version which adds a bit of documentation. -- Added file: http://bugs.python.org/file21479/sqlite_transaction_config_v2.diff ___ Python tracker

[issue10740] sqlite3 module should allow DDL statements in transactions

2011-03-29 Thread Torsten Landschoff
Torsten Landschoff t.landsch...@gmx.net added the comment: Torsten basically you are suggesting that PRAGMA would never work at all with my 'do not strcmp() the sql at all, always begin a transaction' approach? No. Most pragmas should still work and getting the current setting of a pragma

[issue10740] sqlite3 module should allow DDL statements in transactions

2011-03-28 Thread dholth
dholth dho...@fastmail.fm added the comment: Torsten basically you are suggesting that PRAGMA would never work at all with my 'do not strcmp() the sql at all, always begin a transaction' approach? -- ___ Python tracker rep...@bugs.python.org

[issue10740] sqlite3 module should allow DDL statements in transactions

2011-03-26 Thread Torsten Landschoff
Torsten Landschoff t.landsch...@gmx.net added the comment: The attached patch is my take on this issue. I ran into the problem that during schema upgrades dropping a table was not rolled back. In another instance, renaming a table was not rolled back. This greatly increases the risk of data

[issue10740] sqlite3 module should allow DDL statements in transactions

2011-03-26 Thread Torsten Landschoff
Torsten Landschoff t.landsch...@gmx.net added the comment: Same patch for Python 3. In fact, this also adds a missing Py_XDECREF. -- Added file: http://bugs.python.org/file21418/sqlite_transaction_config_py3.diff ___ Python tracker

[issue10740] sqlite3 module should allow DDL statements in transactions

2011-03-26 Thread Torsten Landschoff
Changes by Torsten Landschoff t.landsch...@gmx.net: Added file: http://bugs.python.org/file21419/sqlite_transaction_config_py27.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10740 ___

[issue10740] sqlite3 module should allow DDL statements in transactions

2011-02-18 Thread dholth
dholth dho...@fastmail.fm added the comment: I want transactional DDL too. I was tremendously surprised that I could not duplicate the way sqlite3 behaves on the command line from witin pysqlite. Instead of this patch, I would rather be able to instruct pysqlite to always begin a transaction

[issue10740] sqlite3 module should allow DDL statements in transactions

2010-12-20 Thread Scott Urban
New submission from Scott Urban scott.ur...@isilon.com: The python sqlite module automatically commits open transactions when it encounters a DDL statement. This is unnecessary; DDL is transactional in my testing (see attached). Attached patch addresses the issue. Patch is against 2.6.1, but

[issue10740] sqlite3 module should allow DDL statements in transactions

2010-12-20 Thread Scott Urban
Scott Urban scott.ur...@isilon.com added the comment: Here are some tests. -- Added file: http://bugs.python.org/file20119/test_sqlite_ddl.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10740

[issue10740] sqlite3 module should allow DDL statements in transactions

2010-12-20 Thread R. David Murray
R. David Murray rdmur...@bitdance.com added the comment: See also Issue 8145. It would be nice if someone could sort all this out, but I'm not knowledgeable enough to do so. For this patch, it would be a significant change it behaviour. Therefore it would have to be a new feature controlled

[issue10740] sqlite3 module should allow DDL statements in transactions

2010-12-20 Thread Scott Urban
Scott Urban scott.ur...@isilon.com added the comment: I find the way that the sqlite3 module handles transactions pretty surprising in general, but I agree that someone who got used to DDL not rolling back could in theory find this patch surprising. We will apply this patch to our python build

[issue10740] sqlite3 module should allow DDL statements in transactions

2010-12-20 Thread Andrew Svetlov
Changes by Andrew Svetlov andrew.svet...@gmail.com: -- nosy: +asvetlov ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10740 ___ ___