[issue10752] build_ssl.py is relying on unreliable behaviour of os.popen

Changes by Tim Golden : -- stage: commit review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing

[issue10752] build_ssl.py is relying on unreliable behaviour of os.popen

Tim Golden added the comment: Thanks for the check. Committed to 3.4 & default -- resolution: -> fixed ___ Python tracker ___ ___ Pyt

[issue10752] build_ssl.py is relying on unreliable behaviour of os.popen

Roundup Robot added the comment: New changeset 160f32753b0c by Tim Golden in branch '3.4': Issue10752 Be more robust when finding a PERL interpreter to build OpenSSL. Initial patch by Gabi Davar http://hg.python.org/cpython/rev/160f32753b0c New changeset e492d0ac9abb by Tim Golden in branch 'de

[issue10752] build_ssl.py is relying on unreliable behaviour of os.popen

Zachary Ware added the comment: The patch looks good to me (only tested on a Perl-less machine, though). It applies cleanly on 3.4, which I think is worth committing. It still merges forward cleanly to default, post-#21141. I suspect it would even apply fairly cleanly to 2.7, but I'm not to

[issue10752] build_ssl.py is relying on unreliable behaviour of os.popen

Tim Golden added the comment: I've just looked at issue21141 which is a substantial rework of this area. This change should be incorporated over there as well / instead. -- ___ Python tracker __

[issue10752] build_ssl.py is relying on unreliable behaviour of os.popen

Tim Golden added the comment: Here's a patch against build_ssl which uses subprocess.check_output and very slightly simplifies the output. It successfully finds ActivePerl and builds from source; and uses the svn export files when it's not. I've targetted the development branch; don't know if

[issue10752] build_ssl.py is relying on unreliable behaviour of os.popen

Zachary Ware added the comment: Still relevant, insofar as having Perl available is relevant. That is, you only need Perl available if you're using vanilla OpenSSL sources, not if you're using sources pulled from svn.python.org (which most people should do, I would think). I have never had a

[issue10752] build_ssl.py is relying on unreliable behaviour of os.popen

Tim Golden added the comment: Zach -- you've done most of the work on the VS projects lately. Would you mind having a look at this one to see if it's still relevant, please? -- nosy: +zach.ware ___ Python tracker

[issue10752] build_ssl.py is relying on unreliable behaviour of os.popen

Changes by Antoine Pitrou : -- assignee: ocean-city -> nosy: +tim.peters versions: +Python 3.4 -Python 3.2 ___ Python tracker ___ ___

[issue10752] build_ssl.py is relying on unreliable behaviour of os.popen

Waffle Souffle added the comment: Replicated with Perl being discovered as follows: ['C:\\perl\\bin\\perl.exe', 'c:\\cygwin\\bin\\perl.exe', 'c:\\perl\\bin\\perl.exe'] C:\perl\bin\perl.exe is installed from ActivePerl-5.16.3.1603-MSWin32-x86-296746.msi Attempting to compile Python 2.7.6. Inst

[issue10752] build_ssl.py is relying on unreliable behaviour of os.popen

Gabi Davar added the comment: possibly better patch - uses subprocess' quoting logic for argument handling: diff -r 6fc9103d55f0 PCbuild/build_ssl.py --- a/PCbuild/build_ssl.py Sun Mar 24 14:54:25 2013 -0700 +++ b/PCbuild/build_ssl.py Mon Mar 25 17:28:19 2013 +0200 @@ -47,10 +47,10 @@

[issue10752] build_ssl.py is relying on unreliable behaviour of os.popen

Changes by Antoine Pitrou : -- nosy: +brian.curtin, tim.golden stage: -> patch review versions: +Python 3.3 ___ Python tracker ___ __

[issue10752] build_ssl.py is relying on unreliable behaviour of os.popen

Sébastien Sablé added the comment: I had the same issue while compiling Python 2.7 with ActivePerl on windows, and I can confirm that the proposed patch solves the issue. -- nosy: +sable versions: +Python 2.7 ___ Python tracker

[issue10752] build_ssl.py is relying on unreliable behaviour of os.popen

Changes by Antoine Pitrou : -- assignee: -> ocean-city nosy: +loewis, ocean-city ___ Python tracker ___ ___ Python-bugs-list mailing

[issue10752] build_ssl.py is relying on unreliable behaviour of os.popen

New submission from Sridhar Ratnakumar : I noticed that despite ActivePerl being installed, `os.popen(...).close()` returned 1 (see find_working_perl in build_ssl.py), while in actuality that command executed successfully with return code 0; I verified this by using the subprocess module. Her