[issue10775] assertRaises as a context manager should accept a 'msg' keyword argument.

Ezio Melotti added the comment: Done, thanks for the patch! -- resolution: -> accepted stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ _

[issue10775] assertRaises as a context manager should accept a 'msg' keyword argument.

Roundup Robot added the comment: New changeset 8fc801ca9ea1 by Ezio Melotti in branch 'default': Issue #10775: assertRaises, assertRaisesRegex, assertWarns, and assertWarnsRegex now accept a keyword argument 'msg' when used as context managers. Initial patch by Winston Ewert. http://hg.python

[issue10775] assertRaises as a context manager should accept a 'msg' keyword argument.

Michael Foord added the comment: New patch by Ezio looks good to me. Go ahead and commit. Please raise a separate issue for error reporting when invalid argument combinations are used. (i.e. additional keyword arguments but no callable.) -- ___ Pyt

[issue10775] assertRaises as a context manager should accept a 'msg' keyword argument.

Changes by Nick Coghlan : -- nosy: -ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue10775] assertRaises as a context manager should accept a 'msg' keyword argument.

Changes by Ezio Melotti : Removed file: http://bugs.python.org/file21840/issue10775-2.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue10775] assertRaises as a context manager should accept a 'msg' keyword argument.

Changes by Ezio Melotti : Added file: http://bugs.python.org/file21840/issue10775-2.diff ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue10775] assertRaises as a context manager should accept a 'msg' keyword argument.

Ezio Melotti added the comment: Attached a revised patch. While I agree that an error should be raised when extra args are provided in the context manager form, this is out of the scope of the issue, so I didn't include those changes. -- stage: needs patch -> patch review Added file:

[issue10775] assertRaises as a context manager should accept a 'msg' keyword argument.

Changes by Ezio Melotti : -- assignee: michael.foord -> ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue10775] assertRaises as a context manager should accept a 'msg' keyword argument.

Changes by Michael Foord : -- assignee: -> michael.foord ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue10775] assertRaises as a context manager should accept a 'msg' keyword argument.

Winston Ewert added the comment: The public methods were using both callable_obj and callableObj. Perhaps the patch should standardize on callableObj and accept callable_obj with a warning? -- ___ Python tracker

[issue10775] assertRaises as a context manager should accept a 'msg' keyword argument.

Brian Curtin added the comment: I showed robquad how to do the review stuff at PyCon but I forgot about the publish part. Robbie, if you hit "Publish + Mail Comments" near the top of the page after you've left comments, it'll send them out. What he noticed was that changing to callable_obj i

[issue10775] assertRaises as a context manager should accept a 'msg' keyword argument.

SilentGhost added the comment: > I left a comment on the review. You need to publish your comment if you want others to see it. -- nosy: +SilentGhost ___ Python tracker ___

[issue10775] assertRaises as a context manager should accept a 'msg' keyword argument.

Nick Coghlan added the comment: Michael pointed out that I had completely missed the point of what the "msg" argument was about. Sorry for the noise. -- ___ Python tracker ___

[issue10775] assertRaises as a context manager should accept a 'msg' keyword argument.

Winston Ewert added the comment: robquad mentions having left a comment on the review, but I'm not seeing how to view it. Can somebody explain? It wasn't necessary to change the callable_obj bit, but both form were being used so I thought it best to standardize. Neither version of the paramet

[issue10775] assertRaises as a context manager should accept a 'msg' keyword argument.

R. David Murray added the comment: How does assertRaisesRegex address the use case in issue 3583? -- ___ Python tracker ___ ___ Pytho

[issue10775] assertRaises as a context manager should accept a 'msg' keyword argument.

Nick Coghlan added the comment: Aren't such use cases already covered by assertRaisesRegex? -- nosy: +ncoghlan ___ Python tracker ___ ___

[issue10775] assertRaises as a context manager should accept a 'msg' keyword argument.

Robbie Clemons added the comment: Changing callableObj to callable_obj in assertRaises will break for anyone that's upgrading to 3.3. I left a comment on the review. -- nosy: +robquad ___ Python tracker

[issue10775] assertRaises as a context manager should accept a 'msg' keyword argument.

Winston Ewert added the comment: I decided to try my hand at writing a patch for python. I ended up implementing the behavior for assertRaises, assertRaisesRegex, assertWarns, and assertWarnsRegex. I also made those functions complain about other arguments rather then just ignoring them. ---

[issue10775] assertRaises as a context manager should accept a 'msg' keyword argument.

Changes by Daniel Urban : -- nosy: +durban ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue10775] assertRaises as a context manager should accept a 'msg' keyword argument.

Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue10775] assertRaises as a context manager should accept a 'msg' keyword argument.

Michael Foord added the comment: I'm fine with this functionality being added in 3.3. -- ___ Python tracker ___ ___ Python-bugs-list

[issue10775] assertRaises as a context manager should accept a 'msg' keyword argument.

New submission from R. David Murray : assertRaises used as a method can't take a msg keyword argument because all args and keywords are passed to the callable. But in context manager form it could, and this can be useful. See, for example, issue 3583. -- keywords: easy messages: 1246