[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters

Roundup Robot added the comment: New changeset 33b7428e65b4 by Victor Stinner in branch '3.1': Issue #10801: Fix test_unicode_filenames() of test_zipfile http://hg.python.org/cpython/rev/33b7428e65b4 -- ___ Python tracker

[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters

Georg Brandl added the comment: Victor: you should have a look at . -- ___ Python tracker ___ __

[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters

STINNER Victor added the comment: > These changes cause test failure on 3.1 branch when verbose mode is disabled What a shame! I commited a debug "print()": 1.39 +print(fname) It should be fixed by my last commit. -- ___ Python tracker

[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters

Roundup Robot added the comment: New changeset 9ef8fc5454cb by Victor Stinner in branch '3.1': Issue #10801: Remove a debug print() from test_zipfile http://hg.python.org/cpython/rev/9ef8fc5454cb -- ___ Python tracker

[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters

Arfrever Frehtes Taifersar Arahesis added the comment: These changes cause test failure on 3.1 branch when verbose mode is disabled: # python3.1 -m test.regrtest test_zipfile test_zipfile test test_zipfile produced unexpected output: *

[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters

Roundup Robot added the comment: New changeset 243c78fbbb49 by Victor Stinner in branch '3.1': Ooops, add the missing file of the backport of commit 33543b4e0e5d from Python http://hg.python.org/cpython/rev/243c78fbbb49 -- ___ Python tracker

[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters

Roundup Robot added the comment: New changeset 1f0f0e317873 by Victor Stinner in branch '3.1': Backport commit 33543b4e0e5d from Python 3.2: #10801: In zipfile, support http://hg.python.org/cpython/rev/1f0f0e317873 -- nosy: +python-dev ___ Python tra

[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters

STINNER Victor added the comment: Issue #12048 is a duplicate of this bug, but with Python 3.1. Should we backport the fix to Python 3.1? -- ___ Python tracker ___

[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters

Georg Brandl added the comment: Well, it looks like the filesystem encoding is set to ASCII on these machines. -- ___ Python tracker ___

[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters

Eli Bendersky added the comment: Georg, did you figure out the root cause of the problem on that buildbot? Seeing it fails in open(targetpath, "wb"), extracting the file may have failed if the bot had no write permissions to the current directory, but the ascii encoding error is not what I'd

[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters

Georg Brandl added the comment: OK, I think r87606 fixed it: it doesn't extract the files, instead calls only open(). -- status: open -> closed ___ Python tracker ___ _

[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters

Georg Brandl added the comment: OK, looks like there is a problem on some buildbots: http://www.python.org/dev/buildbot/all/builders/AMD64%20Gentoo%20Wide%203.x/builds/863/steps/test/logs/stdio -- status: closed -> open ___ Python tracker

[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters

Georg Brandl added the comment: Committed patch and test in r87604. -- nosy: +georg.brandl resolution: -> accepted status: open -> closed ___ Python tracker ___ ___

[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters

Changes by Eli Bendersky : Added file: http://bugs.python.org/file20211/issue10801_test.1.patch ___ Python tracker ___ ___ Python-bugs-list ma

[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters

Changes by Eli Bendersky : Removed file: http://bugs.python.org/file20210/issue10801_test.1.patch ___ Python tracker ___ ___ Python-bugs-list

[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters

Eli Bendersky added the comment: I'm attaching a patch with a test for Martin's fix. I had trouble programmatically generating a "bad" zip for this bug, since it has different encodings for the header and filename (probably created by WinZip?). So I created a directory in test/ and placed the

[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters

Eli Bendersky added the comment: I'll try to produce a test in the next hour or two -- nosy: +eli.bendersky ___ Python tracker ___ __

[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters

R. David Murray added the comment: FWIW, having just looked at related code in zipfile recently, this patch looks correct to me. -- nosy: +r.david.murray ___ Python tracker ___

[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters

Martin v. Löwis added the comment: The attached patch fixes it for me. No time to write tests right now. -- keywords: +patch Added file: http://bugs.python.org/file20205/zipfile.diff ___ Python tracker ___

[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters

Changes by Antoine Pitrou : -- nosy: +amaury.forgeotdarc, haypo, loewis ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue10801] zipfile.ZipFile().extractall() header mismatch for non-ASCII characters

New submission from M. Z. : Trying to unpack a ZIP file where some packet files contain danish letters results in: zipfile.BadZipFile: File name in directory 'filename_with_æoå.txt' and header b'filename_with_\x91o\x86.txt' differ. Using Py 3.2b2 on Win7. Unpack the attached ZIP file