[issue10806] Subprocess error if fds 0,1,2 are closed

Antoine Pitrou added the comment: Committed in r87695 (3.2), r87696 (3.1) and r87697 (2.7). -- resolution: -> fixed stage: -> committed/rejected status: open -> closed versions: +Python 2.7, Python 3.1 ___ Python tracker

[issue10806] Subprocess error if fds 0,1,2 are closed

Antoine Pitrou added the comment: This new patch makes tests more comprehensive (closes all combinations of the three standard fds). -- Added file: http://bugs.python.org/file20242/sp3.patch ___ Python tracker __

[issue10806] Subprocess error if fds 0,1,2 are closed

STINNER Victor added the comment: See also #6610 which has a patch with another test. -- nosy: +haypo ___ Python tracker ___ ___ Pyth

[issue10806] Subprocess error if fds 0,1,2 are closed

Antoine Pitrou added the comment: This further patch also addresses issue9905 (incorporating Ross' tests). -- Added file: http://bugs.python.org/file20234/sp2.patch ___ Python tracker _

[issue10806] Subprocess error if fds 0,1,2 are closed

Antoine Pitrou added the comment: Patch works fine, thank you. Here is an attempt at a slightly more readable code by refactoring. -- Added file: http://bugs.python.org/file20230/sp.patch ___ Python tracker _

[issue10806] Subprocess error if fds 0,1,2 are closed

Antoine Pitrou added the comment: > Updated patch for debug mode. Does this also need to be applied for 3.1? Yes, but we can port it ourselves (unless you're really motivated) -- ___ Python tracker __

[issue10806] Subprocess error if fds 0,1,2 are closed

Ross Lagerwall added the comment: Updated patch for debug mode. Does this also need to be applied for 3.1? -- Added file: http://bugs.python.org/file20228/subprocess_v2.patch ___ Python tracker ___

[issue10806] Subprocess error if fds 0,1,2 are closed

Antoine Pitrou added the comment: > Attached is a patch which basically uses fcntl if necessary to remove > the close-on-exec flag, and tests. Python adds extra output at the end of stderr when compiled in debug mode. Therefore you first have to strip that output, like this: out, e

[issue10806] Subprocess error if fds 0,1,2 are closed

New submission from Ross Lagerwall : There is an issue where if a python program closes all the std. file descriptors (e.g. a daemon) and then uses the subprocess module, the file descriptors may not be set up properly in the subprocess. This may actually be a fairly common use case in a daemo