Ronald Oussoren added the comment:
msg126598 says that waitid is broken on MacOSX. In what way it is broken?
The code is currently disabled for OSX without any indication why this is so,
that makes it hard to know how to test if new OSX releases (like the just
released OSX 10.8) fix waitid.
Ronald Oussoren added the comment:
To elaborate: when I remove the !defined(__APPLE__) tests from
posixmodule.c test_posix passes on OSX 10.8, including test_waitid.
I have no idea if this means that waitid is no longer broken in OSX 10.8 or
that test_posix doesn't trigger the issue.
Ross Lagerwall added the comment:
I can't actually remember why I disabled waitid for OS X - that was message was
rather a long time ago :-(
Unfortunately, I don't currently have access to an OS X machine to test it.
A google search shows the following comment in the v8 javascript engine:
//
Ronald Oussoren added the comment:
I have VMs with earlier versions of OSX (at least 10.5 and 10.6). I cannot run
those right now because they use enough resources to interfere with other
activities. I'll try to test later this week.
BTW. I'd prefer to make waitid available on OSX unless it
Roundup Robot devnull@devnull added the comment:
New changeset 96e09d039433 by Ross Lagerwall in branch 'default':
Fix refleak introduced by #10812.
http://hg.python.org/cpython/rev/96e09d039433
--
___
Python tracker rep...@bugs.python.org
Roundup Robot devnull@devnull added the comment:
New changeset 525320df8afb by Ross Lagerwall in branch 'default':
Issue #10812: Add some extra posix functions to the os module.
http://hg.python.org/cpython/rev/525320df8afb
--
nosy: +python-dev
___
Changes by Ross Lagerwall rosslagerw...@gmail.com:
--
assignee: - rosslagerwall
resolution: - accepted
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10812
Roundup Robot devnull@devnull added the comment:
New changeset 8945e087a5a6 by Ross Lagerwall in branch 'default':
Issue #10812: Revert os.lseek change.
http://hg.python.org/cpython/rev/8945e087a5a6
--
___
Python tracker rep...@bugs.python.org
Ross Lagerwall rosslagerw...@gmail.com added the comment:
PyParse_off_t was already added when sendfile() was added as was the
iovec_setup stuff.
I'll upload a patch soon which updates it to take this and the other comments
into account.
--
___
Martin v. Löwis mar...@v.loewis.de added the comment:
v6 was created against an unknown mercurial repository (most likely
code.python.org). It actually doesn't apply cleanly anymore so it would be best
to regenerate it it (or go on with any v7 that may result out of the review).
--
Ross Lagerwall rosslagerw...@gmail.com added the comment:
This new patch, updated against the tip for 3.3:
Shares the iov_setup and iov_cleanup code, py_parse_off_t with sendfile().
Removes gethostid and sethostid since they're deprecated.
I think I was correct with referring to utime() since
Ross Lagerwall rosslagerw...@gmail.com added the comment:
Forgot to attach the patch
--
Added file: http://bugs.python.org/file21250/10812_v7.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10812
Gregory P. Smith g...@krypto.org added the comment:
I added some comments on the review for 10812_v5.patch. not sure why v6
doesn't have a review link. Overall, very nice after addressing the few
comments I had.
btw, can you sync this up with the hg tip (3.3) now while addressing the above?
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10812
___
Ross Lagerwall rosslagerw...@gmail.com added the comment:
A few small fixes for OS X:
It has no return value for sethostid() and sets different errno if permission
denied,
waitid() is broken - so its disabled,
the timeval struct used in futimes and lutimes is defined slightly differently.
Changes by Ned Deily n...@acm.org:
--
nosy: +ned.deily
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10812
___
___
Python-bugs-list mailing list
Ross Lagerwall rosslagerw...@gmail.com added the comment:
it's a bit asymmetric that gethostname is in the socket
module and supports Windows, and sethostname is in the POSIX
module. It would be useful to have a gethostname in the POSIX
module also which is a) POSIX only and b) supports
Ross Lagerwall rosslagerw...@gmail.com added the comment:
Thanks for the comments.
I implemented sethostid() - its not actually in the posix spec, but linux/*bsd
have it although the signature for FreeBSD is a bit different.
I implemented gethostname(). Both get/sethostname() now use FSDefault
Martin v. Löwis mar...@v.loewis.de added the comment:
According to the spec for gethostname(), the hostname that it returns
is null-terminated so it won't support embedded NUL bytes. Should we
still add it anyway?
Oops, I misread the spec. No, gethostname should then not be duplicated.
Martin v. Löwis mar...@v.loewis.de added the comment:
According to the spec, gethostid does not set errno - it now checks anyway.
Sorry, I misread that also. Leaving the check is fine; reverting it to
the previous code would be fine as well.
--
___
Ross Lagerwall rosslagerw...@gmail.com added the comment:
This patch takes out sethostname() and gethostname(). I'll open up a new issue
to add sethostname() to the socket module.
--
Added file: http://bugs.python.org/file20311/10812_v5.patch
___
Ross Lagerwall rosslagerw...@gmail.com added the comment:
This new patch reuses iov allocation code between readv writev.
It reuses code between exec, execve fexecve.
It reuses code for parsing off_t types.
I've tried where possible to reuse code but I think though that the code seems
pretty
Martin v. Löwis mar...@v.loewis.de added the comment:
Patch looks mostly good. Some comments:
- sethostname supports names with embedded null bytes, so
wrapper should not use strlen
- it's a bit asymmetric that gethostname is in the socket
module and supports Windows, and sethostname is in
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
The patch contains a lot of repeated boilerplate code. I wonder if some of it
can be factored out and reused. For example iov buffer allocation code appears
to be identical in writev and readv.
--
nosy:
Ross Lagerwall rosslagerw...@gmail.com added the comment:
This patch:
Fixes test_lutimes(),
Ignores a posix_fallocate() failure on Solaris due to ZFS,
Changes readv() writev() signatures such that they take sequences instead of
tuples,
Changes readv() so that it takes a number of writable
New submission from Ross Lagerwall rosslagerw...@gmail.com:
Here's a patch that adds a bunch of posix functions that are missing from the
posix module. Includes tests documentation.
Tested on Linux FreeBSD.
Specifically:
futimes
lutimes
futimens
fexecve
Antoine Pitrou pit...@free.fr added the comment:
First couple comments:
- you don't have to modify Misc/NEWS yourself; it will probably make patch
maintenance easier
- it would seem more natural for readv() to take a sequence of writable buffers
(such as bytearrays) instead; I don't think the
Antoine Pitrou pit...@free.fr added the comment:
For the record, I get the following failures under OpenSolaris:
==
ERROR: test_lutimes (test.test_posix.PosixTester)
Antoine Pitrou pit...@free.fr added the comment:
According to the posix_fallocate() man page under OpenSolaris:
EINVALThe len argument is less than or equal to zero, or
the offset argument is less than zero, or the
underlying file system does not
29 matches
Mail list logo
