Pat LaVarre added the comment:
Works for me.
I tried python-trunk-vistaplatform-v2.patch in one sample of 2006-11
RTM Vista plus 2.5.1 Python plus this patch. I quote:
import platform
platform.uname()
('Windows', '[redacted]', 'Vista', '6.0.6000', '', '')
platform.system()
'Windows'
Pat LaVarre added the comment:
--- USAGE:
I agree we should let people in future write:
if not platform.system('Windows'):
rather than:
if not (platform.system() in ('Microsoft', 'Windows')):
now that our people can no longer rely on Python in Vista correctly
understanding the plain human
Marc-Andre Lemburg added the comment:
Pat, we already have system_alias() for exactly the purpose you suggested.
Software relying on platform.system() reporting Vista will have to use
Python 2.5.2 as minimum Python version system requirement - pretty much
the same as with all other bug fixes.
Pat LaVarre added the comment:
Thanks for the cultural education of 2.5.1 isn't supposed to work, I
didn't know that.
Also I'm glad to hear this is fixed for 2.5.2 already.
Sorry I'm too new ignorant to understand why you believe this is
fixed. I don't see that we already have a way to say
Sean Reifschneider added the comment:
Attached a patch which I *THINK* fixes this, but I don't run Windows.
Can someone else check this?
--
assignee: - lemburg
nosy: +jafo, lemburg
priority: - normal
__
Tracker [EMAIL PROTECTED]
Sean Reifschneider added the comment:
Supplied patch passes make test, BTW.
--
keywords: +patch
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1082
__
___
Pat LaVarre added the comment:
I recommend we reject this first draft of the python-trunk-
vistaplatform.patch.
I reason as follows ...
ACTUAL RESULTS OF 2.5.1 PLUS PATCH IN VISTA WINDOWS:
import platform
...
platform.uname()
('Microsoft', '[redacted]', 'Windows', '6.0.6000', '', '')
Sean Reifschneider added the comment:
Attached is a patch that fixes uname() instead of the individual
helpers. I agree that is the better way to do it. Again, not tested on
Windows because I don't have it.
What about adding a isWindows() sort of method that does the right
thing, or
Marc-Andre Lemburg added the comment:
A couple of notes:
* platform.uname() needs to be fixed, not the individual query functions.
* The third entry of uname() should return Vista instead of
Microsoft on MS Vista.
* A patch should go on trunk and into 2.5.2, since this is a real bug
and not a
Sean Reifschneider added the comment:
Shall I commit my v2 patch then, to 2.5.2 and trunk? It has the code
in the uname() method, as you say.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1082
__
Changes by Sean Reifschneider:
--
versions: +Python 2.6
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1082
__
___
Python-bugs-list mailing list
Unsubscribe:
Sean Reifschneider added the comment:
Commited in trunk revision 58183 and 25-maint revision 58184.
--
resolution: - accepted
status: open - closed
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1082
__
New submission from Pat LaVarre:
SUMMARY:
'Microsoft' is the platform.system() of Vista Windows, whereas 'Windows'
was the platform.system() of XP Windows, whoops.
STEPS TO REPRODUCE ACTUAL RESULTS:
Run 2.5.1 Python in a Vista and see:
import platform
platform.system()
'Microsoft'
Bill Janssen added the comment:
Wow. I think that platform.system() should return Windows for both XP
and Vista, and platform.release() should return either Vista or XP.
Seems like a patch to make this happen would be a good idea.
--
nosy: +janssen
14 matches
Mail list logo
