[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

STINNER Victor added the comment: The distutils bdist_wininst command has been removed in Python 3.10: see bpo-42802. -- resolution: -> wont fix stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

STINNER Victor added the comment: Lib/distutils/tests/test_bdist_wininst.py contains an interesting comment linking to bpo-5731: # issue5731: command was broken on non-windows platforms # this test makes sure it works now for every platform # let's create a

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

STINNER Victor added the comment: Follow-up issue: bpo-37468 "Don't install wininst*.exe on non-Windows platforms". -- ___ Python tracker ___

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

miss-islington added the comment: New changeset be5bb52f5f2d4da4b9d6f42399f7275ab47910f3 by Miss Islington (bot) in branch '3.8': bpo-10945: Drop support for bdist_wininst on non-Windows systems (GH-14506) https://github.com/python/cpython/commit/be5bb52f5f2d4da4b9d6f42399f7275ab47910f3 ---

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

miss-islington added the comment: New changeset 45c10da40912e04c0d0de02af4b23438ed0de49b by Miss Islington (bot) in branch '3.7': bpo-10945: Drop support for bdist_wininst on non-Windows systems (GH-14506) https://github.com/python/cpython/commit/45c10da40912e04c0d0de02af4b23438ed0de49b ---

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

Change by miss-islington : -- pull_requests: +14326 pull_request: https://github.com/python/cpython/pull/14510 ___ Python tracker ___ __

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

STINNER Victor added the comment: New changeset 72cd653c4ed7a4f8f8fb06ac364b08a97085a2b5 by Victor Stinner (Miro Hrončok) in branch 'master': bpo-10945: Drop support for bdist_wininst on non-Windows systems (GH-14506) https://github.com/python/cpython/commit/72cd653c4ed7a4f8f8fb06ac364b08a9708

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

Change by miss-islington : -- pull_requests: +14325 pull_request: https://github.com/python/cpython/pull/14509 ___ Python tracker ___ __

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

STINNER Victor added the comment: I started a discussion on the Packaging list: "Deprecate bdist_wininst" https://discuss.python.org/t/deprecate-bdist-wininst/1929 -- ___ Python tracker ___

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

STINNER Victor added the comment: > I've opened a PR thet removes the support for bdist_wininst on non-Windows. > Apparently, it was broken since the beginning of Py3k anyway. The support can > be reintroduced once it is actually fixed (or never). It would be better to use the Unicode (wide

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

Miro Hrončok added the comment: I've opened a PR thet removes the support for bdist_wininst on non-Windows. Apparently, it was broken since the beginning of Py3k anyway. The support can be reintroduced once it is actually fixed (or never). https://github.com/python/cpython/pull/14506 ---

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

Change by Miro Hrončok : -- keywords: +patch pull_requests: +14322 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/14506 ___ Python tracker _

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

Changes by Jelmer Vernooij : -- nosy: +Jelmer Vernooij, jelmer ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

Changes by Arfrever Frehtes Taifersar Arahesis : -- title: bdist_wininst depends on MBCS codec, unavailable on non-Windows -> bdist_wininst depends on MBCS codec, unavailable on non-Windows ___ Python tracker

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

STINNER Victor added the comment: > Would the proposed change mean that a bdist_wininst built > with 3.2.0 won’t work with a patched 3.2.3? The installer doesn't use distutils to read its configuration, so such binary runs with any installed Python version. > bdist_msi decodes data read from

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

Éric Araujo added the comment: The proposition of using other C functions and changing the bdist_wininst code looks risky to me, especially as I don’t know how compatibility would be affected (see my previous message). We are free to improve the wininst code in distutils2, or discuss a repla

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

Éric Araujo added the comment: Would the proposed change mean that a bdist_wininst built with 3.2.0 won’t work with a patched 3.2.3? -- ___ Python tracker ___ _

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

Martin v. Löwis added the comment: > Do we need to keep backward compatibility if we change the format of the > config > data? Or wininst-xx.exe are only usable with trailing config data in the .exe > file? The wininst.exe belongs to the version of distutils it is released with. So if we cha

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

STINNER Victor added the comment: > The problem is that the config file is parsed using > GetPrivateProfileString, and the result is then passed to TextOut, > SetDlgItemText, CreateWindow, etc. all of which are defined to accept MBCS > strings. I agree that this can't work correctly in the gener

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

Martin v. Löwis added the comment: The problem is that the config file is parsed using GetPrivateProfileString, and the result is then passed to TextOut, SetDlgItemText, CreateWindow, etc. all of which are defined to accept MBCS strings. I agree that this can't work correctly in the general c

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

Éric Araujo added the comment: >> It is not code under the users’ control (i.e. setup.py) >> that uses MBCS, but the bdist_wininst command itself. > bdist_command append configuration data to a wininst-xxx.exe binary. Are you sure? The string that’s encoded with mbcs comes from the get_inidata

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

STINNER Victor added the comment: > It is not code under the users’ control (i.e. setup.py) > that uses MBCS, but the bdist_wininst command itself. bdist_command append configuration data to a wininst-xxx.exe binary. Where does this file come from? Can we modify wininst-xxx.exe binaries? If

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

Éric Araujo added the comment: haypo: > Can't you only work with Unicode and avoid the MBCS encoding? It is not code under the users’ control (i.e. setup.py) that uses MBCS, but the bdist_wininst command itself. It used to be runnable from linux, which is great to provide binary installers fo

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

Ralf Schlatterbeck added the comment: On Thu, Jul 07, 2011 at 10:52:51AM +, STINNER Victor wrote: > > Can't you only work with Unicode and avoid the MBCS encoding? I'm trying to build a windows binary package on Linux. This usually works fine -- as long as the package description doesn't c

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

STINNER Victor added the comment: Can't you only work with Unicode and avoid the MBCS encoding? -- nosy: +haypo ___ Python tracker ___ __

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

Amaury Forgeot d'Arc added the comment: The mbcs codec depends on the Windows installation. On most Western Windows it is similar to cp1252, Japanese Windows will use cp932, and so on. If we were to provide mbcs on non-windows platform, it should be an alias to ascii. -- nosy: +amaury

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

Ralf Schlatterbeck added the comment: I've just been bitten by this when trying to do a new release of roundup, why not make the mbcs codec available on non-windows platforms as has been proposed (and rejected) in issue1251921 -- any non-technical reasons for not including this codec on other

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

Éric Araujo added the comment: > Please don't ask me about patches. Core devs won't accept them. One of your patches for diff has been accepted; some distutils bugs have patches from you (for which we are grateful) that are in various review stages. The only thing preventing acceptance where I

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

anatoly techtonik added the comment: Please don't ask me about patches. Core devs won't accept them. -- ___ Python tracker ___ ___ Py

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

Éric Araujo added the comment: We don’t commit failing tests :) If you mean you want to write a test case, please go ahead and attach a patch or changeset URI. -- ___ Python tracker _

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

anatoly techtonik added the comment: I believe it is better to start and commit a testcase . -- nosy: +techtonik ___ Python tracker ___ _

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

New submission from Éric Araujo : If distutils.commands.bdist_wininst.bdist_wininst.get_inidata returns a unicode string (which is always the case in 3.x and can happen in 2.x if if you pass a unicode object as one setup argument), bdist_wininst will try to use the MBCS codec, which is not ava