Brett Cannon br...@python.org added the comment:
r88467 has it for 3.3.
--
resolution: accepted - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10990
Brett Cannon br...@python.org added the comment:
Updated patch that applies cleanly.
--
Added file: http://bugs.python.org/file20718/issue10990.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10990
Changes by Brett Cannon br...@python.org:
Removed file: http://bugs.python.org/file20620/issue_10990.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10990
___
Changes by Brett Cannon br...@python.org:
Removed file: http://bugs.python.org/file20581/issue10990.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10990
___
Brett Cannon br...@python.org added the comment:
Sorry about that. New patch attached.
--
Added file: http://bugs.python.org/file20620/issue_10990.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10990
Brett Cannon br...@python.org added the comment:
Attached is a fixed copy of Kristian's patch; error in test_trace where
self.settrace was being called.
--
Added file: http://bugs.python.org/file20581/issue10990.diff
___
Python tracker
Changes by Brett Cannon br...@python.org:
Removed file: http://bugs.python.org/file20561/issue10990.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10990
___
Changes by Brett Cannon br...@python.org:
Removed file: http://bugs.python.org/file20525/trace_fxn_protected.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10990
___
Kristian Vlaardingerbroek kristian.vlaardingerbr...@gmail.com added the
comment:
Cleaned up patch file. Removed non-related diffs and redundant updates.
refcount_test decorator is still in there.
--
Added file: http://bugs.python.org/file20561/issue10990.diff
Kristian Vlaardingerbroek kristian.vlaardingerbr...@gmail.com added the
comment:
test_trace can be added to this list, each call to runfunc does a sys.settrace()
121:self.tracer.runfunc(traced_func_loop, 2, 3)
133:self.tracer.runfunc(traced_func_importing, 2, 5)
145:
Brett Cannon br...@python.org added the comment:
Thanks for the diagnosis, Kristian. Attached is a patch for test_trace which
fixes its over-zealous setting of the trace function (doesn't address the
failures, though).
--
Added file: http://bugs.python.org/file20516/test_trace.diff
Brett Cannon br...@python.org added the comment:
Here is a patch for test_pdb; the context manager made this dirt-simple to fix.
--
Added file: http://bugs.python.org/file20517/test_gdb.diff
___
Python tracker rep...@bugs.python.org
Brett Cannon br...@python.org added the comment:
Patch for doctest/test_doctest (yes, both files were wiping out the trace
function.
--
Added file: http://bugs.python.org/file20518/test_doctest.diff
___
Python tracker rep...@bugs.python.org
Brett Cannon br...@python.org added the comment:
And with this patch for test_zipimport_support to work thanks to the
test_doctest changes, all of the test suites blasting the trace function
*should* be fixed.
--
Added file: http://bugs.python.org/file20519/test_zipimport_support.diff
Brett Cannon br...@python.org added the comment:
I have a patch that I am testing right now which deals which fixes all the test
suites.
--
assignee: - brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10990
Brett Cannon br...@python.org added the comment:
OK, here is a single patch (from `hg outgoing --patch`) that fixes all the
tests by introducing the test.support.no_tracing decorator.
--
Added file: http://bugs.python.org/file20523/trace_fxn_protected.diff
Changes by Brett Cannon br...@python.org:
Removed file: http://bugs.python.org/file20498/sys_gettrace_monitor.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10990
___
Changes by Brett Cannon br...@python.org:
Removed file: http://bugs.python.org/file20508/test_scope.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10990
___
Changes by Brett Cannon br...@python.org:
Removed file: http://bugs.python.org/file20509/test_sys_settrace.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10990
___
Changes by Brett Cannon br...@python.org:
Removed file: http://bugs.python.org/file20516/test_trace.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10990
___
Changes by Brett Cannon br...@python.org:
Removed file: http://bugs.python.org/file20517/test_gdb.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10990
___
Changes by Brett Cannon br...@python.org:
Removed file: http://bugs.python.org/file20518/test_doctest.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10990
___
Changes by Brett Cannon br...@python.org:
Removed file: http://bugs.python.org/file20519/test_zipimport_support.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10990
___
Changes by Brett Cannon br...@python.org:
Removed file: http://bugs.python.org/file20523/trace_fxn_protected.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10990
___
Brett Cannon br...@python.org added the comment:
OK, here is an updated patch that fixes the introduced failure in
test_sys_settrace. This should be ready to go for Python 3.3 once the tree
opens up (unless someone reviews it and finds a problem).
--
resolution: - accepted
stage: -
Changes by Kristian Vlaardingerbroek kristian.vlaardingerbr...@gmail.com:
--
nosy: +Kristian.Vlaardingerbroek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10990
___
Brett Cannon br...@python.org added the comment:
Cinder on IRC found that test_exception's RuntimeError test triggers a
trace_trampoline() line of code which resets the trace function as an exception
gets triggered in the trace function itself.
test_doctest is being messy and setting pdb's
Kristian Vlaardingerbroek kristian.vlaardingerbr...@gmail.com added the
comment:
test_pickle and test_pickletools both call test_bad_getattr in
pickletester.py:1005
This results in a RuntimeError which leads to the same result as test_exceptions
--
Brett Cannon br...@python.org added the comment:
test_pdb uses pdb.set_trace() w/o putting the original trace function back.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10990
___
Brett Cannon br...@python.org added the comment:
test_scope blindly resets the trace function to None.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10990
___
Brett Cannon br...@python.org added the comment:
And here is a revelation: test_sys_settrace clobbers the trace function blindly.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10990
___
Brett Cannon br...@python.org added the comment:
test_zipimport_support fails because test_doctest fails; it re-runs the tests
from a zipfile.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10990
Brett Cannon br...@python.org added the comment:
test_io is causing coverage.py to complain thanks to the TextIOWrapperTests,
and the regrtest check is complaining about SignalsTests. Don't know why
specifically for either.
--
___
Python tracker
Brett Cannon br...@python.org added the comment:
test_runpy fails because of a recursion depth test (test_main_recursion_error).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10990
___
Brett Cannon br...@python.org added the comment:
test_richcmp is failing because of a recursion test (test_recursion)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10990
___
Brett Cannon br...@python.org added the comment:
For test_io.*SignalsTests, its all the tests calling check_interrupted_write().
For TestIOWrapperTests its test_threads_write() (although only coverage.py is
complaining, not regrtest).
--
___
Python
Brett Cannon br...@python.org added the comment:
OK, now that all the modules have been analyzed, let's see what is what.
The modules not playing nicely with others by blindly reseting the trace module:
test_doctest
test_pdb
test_scope
test_sys_settrace
test_zipimport_support (because of
Brett Cannon br...@python.org added the comment:
Here is a patch that fixes test_scope.
--
Added file: http://bugs.python.org/file20508/test_scope.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10990
Brett Cannon br...@python.org added the comment:
Here is a partial patch for test_sys_settrace. It fails on
test_19_no_jump_without_trace_function for some reason I don't understand. It
also doesn't protect against it being CPython-only as that is a function
decorator and basically the whole
New submission from Brett Cannon br...@python.org:
The attached patch adds resource monitoring to test.regrtest to detect which
tests are changing the trace function w/o putting back to what it was
previously. The tests listed below are thus all being naughty. This is a
meta-issue to help
40 matches
Mail list logo
