Eli Bendersky eli...@gmail.com added the comment:
Can this be committed and closed? [it's still an annoying problem for some
Windows users who want to compile Python]
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11034
Martin v. Löwis mar...@v.loewis.de added the comment:
I'm closing it as rejected. Python doesn't use subversion anymore.
--
resolution: - rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11034
Eli Bendersky eli...@gmail.com added the comment:
After some investigation of running make_buildinfo standalone, it boils down to
this:
When it executes the path with quotes around the last argument:
C:\Program Files\TortoiseSVN\bin\subwcrev.exe .. ..\Modules\getbuildinfo.c
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
Could this be some bizzarre bug in the quote parser of cmd.exe?
Yes, this is even documented with cmd /?:
[...]If you specify /c or /k, cmd processes the remainder of string and
quotation marks are preserved only if all of the
Eli Bendersky eli...@gmail.com added the comment:
Amaury, seems like it - thanks. So I suppose the fix would be just to remove
the quotes in make_buildinfo.c
I wonder why it worked for others buildbots?
--
___
Python tracker rep...@bugs.python.org
Changes by Eli Bendersky eli...@gmail.com:
--
priority: normal - high
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11034
___
___
Python-bugs-list
Changes by Eli Bendersky eli...@gmail.com:
--
nosy: +krisvale
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11034
___
___
Python-bugs-list mailing
Martin gzl...@googlemail.com added the comment:
Removing the quotes rebreaks the case where tmppath contains a space.
Instead, either:
* Call subwcrev.exe directly without going through COMSPEC: switch 'system' to
'CreateProcess'.
* More quotes! Change `A .. B` to `A .. B` which when it hits
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
Bizarre indeed.
I think more quotes is the answer, since it is simpler to implement.
But the question remains, why has it worked until now?
--
___
Python tracker rep...@bugs.python.org
Martin gzl...@googlemail.com added the comment:
This bug only hits people who:
1) Have TortoiseSVN installed (buildbots won't, I don't)
2) ...on a path that needs quoting.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11034
Eli Bendersky eli...@gmail.com added the comment:
Martin,
This makes sense, but keep in mind that:
1) Many, if indeed not *most* Windows SVN users use TortoiseSVN (and our dev
guide recommends it, IIRC)
2) When TortoiseSVN *is* installed, it almost always goes into Program Files
(its default
Martin v. Löwis mar...@v.loewis.de added the comment:
Kristján - will you submit a patch for review? (this issue seems like
a release blocker to me - but I'll leave it to Georg to decide on
setting its priority)
I wouldn't say it's a release blocker: I can build Python just fine,
so the
Martin gzl...@googlemail.com added the comment:
Eli, was just answering your question about why this didn't fail for other
people.
Try the attached patch to see if it fixes the problem for you.
--
keywords: +patch
Added file: http://bugs.python.org/file20571/issue11034.patch
Martin gzl...@googlemail.com added the comment:
...and this apparently came up on the mailinglist as well with Prasun providing
nearly exactly the same patch:
http://mail.python.org/pipermail/python-dev/2011-January/107599.html
--
___
Python
Eli Bendersky eli...@gmail.com added the comment:
Martin, the patch fixed the problem for me and the code looks good.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11034
___
New submission from Eli Bendersky eli...@gmail.com:
On a clean checkout of py3k, I try to open PCBuild/pcbuild.sln with my MSVC++
Express 2008. When opening, a message box pops saying:
Solution folders are not supported in this version of the application.
Solution folder Solution Items
Eli Bendersky eli...@gmail.com added the comment:
I tried running make_buildinfo.exe manually from a VC command prompt, and I get
an error for invoking subwcrev.exe:
D:\eli\python-py3k-trunk\PCbuildmake_buildinfo.exe Debug Win32-temp-Debug
C:\Program Files\TortoiseSVN\bin\subwcrev.exe ..
17 matches
Mail list logo