[issue11104] distutils sdist ignores MANIFEST

Éric Araujo added the comment: Obviously I can’t fix past releases. Sometimes the time machine is not available :) -- resolution: -> fixed status: open -> closed ___ Python tracker _

[issue11104] distutils sdist ignores MANIFEST

Stephen Thorne added the comment: Yep - 2.7.2 was released 11th June 2011, the fix was committed Aug 1st 2011. So it won't be in the current 2.7 release. -- ___ Python tracker

[issue11104] distutils sdist ignores MANIFEST

Éric Araujo added the comment: > The changesets are not in the release27-maint branch. Where did you look? This looks like a Subversion branch name, but now we’re using Mercurial. If you look a few messages up, you’ll see that a changeset was committed to the 2.7 branch and will be included

[issue11104] distutils sdist ignores MANIFEST

John Dennis added the comment: The changesets are not in the release27-maint branch. sdist still does not generate a correct archive for release, this is a very serious regression. -- resolution: fixed -> status: closed -> open ___ Python tracker

[issue11104] distutils sdist ignores MANIFEST

Éric Araujo added the comment: I did some more work on the patch and committed. Thanks again to both of you. I also thought again about this remark: > Changeset r83996 was introduced to prevent sdist from overwriting a > project maintained manifest by testing for a comment at the head of > th

[issue11104] distutils sdist ignores MANIFEST

Roundup Robot added the comment: New changeset 21feea7f35e5 by Éric Araujo in branch '2.7': Fix regression with distutils MANIFEST handing (#11104, #8688). http://hg.python.org/cpython/rev/21feea7f35e5 -- ___ Python tracker

[issue11104] distutils sdist ignores MANIFEST

Roundup Robot added the comment: New changeset 5d3e22d69d4f by Éric Araujo in branch '3.2': Fix regression with distutils MANIFEST handing (#11104, #8688). http://hg.python.org/cpython/rev/5d3e22d69d4f -- nosy: +python-dev ___ Python tracker

[issue11104] distutils sdist ignores MANIFEST

Éric Araujo added the comment: Thanks for your work. I will make a final test and review and commit it in the coming days. I’ll adapt the versionchanged text, since I won’t commit this in 3.1 (in security mode now, not bugfix mode). -- priority: normal -> high _

[issue11104] distutils sdist ignores MANIFEST

Stephen Thorne added the comment: Éric mentioned that i should check that this behaviour matches the documentation. I have gone and looked for all instances of MANIFEST in the documentation and found one place which was inconsistent. I've added the doc patch to the patch. Please review this n

[issue11104] distutils sdist ignores MANIFEST

Éric Araujo added the comment: Thanks for your work, the code can now be fixed; I’ll have time to commit in a few days. Can you check if the documentation still accurately describes the behavior? (search for MANIFEST in Doc/distutils/*) -- stage: -> commit review versions: +Python

[issue11104] distutils sdist ignores MANIFEST

Stephen Thorne added the comment: Updated the patch to address the 'why not use .strip()' question. I used .rstrip('\r\n') on the basis that filenames may have leading or trailing spaces, and if you need that, you need to be able to specify that in a MANIFEST, but it is perfectly logical to d

[issue11104] distutils sdist ignores MANIFEST

Stephen Thorne added the comment: This patch is an updated patch that fixes the things noted in the review from eric.araujo. -- Added file: http://bugs.python.org/file22437/manifest-respect-3 ___ Python tracker _

[issue11104] distutils sdist ignores MANIFEST

Stephen Thorne added the comment: Oh! I didn't see any notification that there was a review done. Thanks, I'll attend to that. -- ___ Python tracker ___ ___

[issue11104] distutils sdist ignores MANIFEST

Éric Araujo added the comment: I have outstanding comments and questions on the review page (follow the review link on the right of the 3.x patch). -- ___ Python tracker ___ __

[issue11104] distutils sdist ignores MANIFEST

Stephen Thorne added the comment: I have 2 patches, with tests, that applies on python2.7 and the python3 series of branches, attached this ticket. I have also got a signed contributor agreement lodged with the PSF. Can I please have someone either apply my patches or tell me what I need to d

[issue11104] distutils sdist ignores MANIFEST

Stephen Thorne added the comment: This patch is tested against the 3.1 and default branches, the previous patch attached was against the 2.7 branch. -- Added file: http://bugs.python.org/file22243/manifest-respect-3.patch ___ Python tracker

[issue11104] distutils sdist ignores MANIFEST

Stephen Thorne added the comment: I've taken the sdist.patch and wrote some tests for it. The resulting patch is attached as 'manifest-respect.patch'. -- nosy: +jerub Added file: http://bugs.python.org/file22242/manifest-respect.patch ___ Python tra

[issue11104] distutils sdist ignores MANIFEST

Changes by John Dennis : -- nosy: +dmalcolm ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue11104] distutils sdist ignores MANIFEST

Éric Araujo added the comment: I didn’t mean to imply you had to, I just asked if you wanted to. Reporting the bug is a valuable contribution indeed, I’ll take over for the rest. -- ___ Python tracker __

[issue11104] distutils sdist ignores MANIFEST

John Dennis added the comment: No, I don't think I'm going to turn the tarball into a unit test, etc. I didn't break the code but I did report the problem, researched the history, provided a clear explanation, a reproducer and a patch to fix the problem. I think I've done my part as a communi

[issue11104] distutils sdist ignores MANIFEST

Éric Araujo added the comment: Thank you, the bug is clear now. To fix this regression, the first step is to turn your tarball and instructions into a unit test and then fix the logic in the code. If you want to do it, there are some process guidelines at http://wiki.python.org/moin/Distuti

[issue11104] distutils sdist ignores MANIFEST

John Dennis added the comment: $ tar xzf distutils_bug.tar.gz $ cd distutils_bug $ ./setup.py sdist $ ./setup.py sdist running sdist running check warning: sdist: manifest template 'MANIFEST.in' does not exist (using default file list) not writing to manually maintained manifest file 'MANIFES

[issue11104] distutils sdist ignores MANIFEST

Éric Araujo added the comment: This behavior change is actually present in 2.7.1, 3.1.3 and 3.2. I’m concerned that you’ve found a bug with it (thanks for the report), and that we may have to change behavior again. First, could you open another report about comment handling in read_manifest?

[issue11104] distutils sdist ignores MANIFEST

Changes by John Dennis : Added file: http://bugs.python.org/file20659/sdist_new ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue11104] distutils sdist ignores MANIFEST

Changes by John Dennis : Added file: http://bugs.python.org/file20658/sdist.patch ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue11104] distutils sdist ignores MANIFEST

Changes by John Dennis : Removed file: http://bugs.python.org/file20656/sdist_new ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue11104] distutils sdist ignores MANIFEST

Changes by John Dennis : Removed file: http://bugs.python.org/file20655/sdist.patch ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue11104] distutils sdist ignores MANIFEST

Changes by John Dennis : Added file: http://bugs.python.org/file20656/sdist_new ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue11104] distutils sdist ignores MANIFEST

Changes by John Dennis : -- keywords: +patch Added file: http://bugs.python.org/file20655/sdist.patch ___ Python tracker ___ ___ Pytho

[issue11104] distutils sdist ignores MANIFEST

New submission from John Dennis : The behaviour of sdist has changed dramatically in Python 2.7. Some projects prefer to maintain their own manifest file instead of utilizing automatic manifest generation from a template. The defined behaviour of sdist is to check for the presence of both a te