Senthil Kumaran sent...@uthcode.com added the comment:
anikom15's first patch seems correct. In the multiprocessing.py, the the arg
'obj' can be safely replaced with 'item' to be consistent with the docs. As
this is not a keyword arg, it does not stand any chance of breaking any
backwards
Senthil Kumaran sent...@uthcode.com added the comment:
Well, I should take back my previous comment. I realized that the positional
arg in this case can be called as keyword arg. It would be wrong to change
multiprocessing.py and it is correct to change the docs.
--
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset c6d4d4d64405 by Senthil Kumaran in branch '3.2':
Fix closes Issue11155 - Correct the multiprocessing.Queue.put's arg (replace
'item' with 'obj') in the docs. Patch by Westley Martínez.
Westley Martínez aniko...@gmail.com added the comment:
¡Hola!
Just checking in. The documentation is still incorrect for all versions.
There's a patch that fixes it ready to be reviewed.
--
___
Python tracker rep...@bugs.python.org
Changes by Eli Bendersky eli...@gmail.com:
--
nosy: +eli.bendersky
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11155
___
___
Python-bugs-list
Westley Martínez aniko...@gmail.com added the comment:
Can this patch be commited?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11155
___
___
Ezio Melotti ezio.melo...@gmail.com added the comment:
Technically this is a backward-incompatible change, because it breaks code that
uses obj=foo explicitly.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11155
Westley Martínez aniko...@gmail.com added the comment:
In that case, I've made a patch that changes the documentation so that item
is now obj. for Queue.put and Queue.put_nowait.
--
Added file: http://bugs.python.org/file21484/doc-11155.diff
___
Westley Martínez aniko...@gmail.com added the comment:
Well it's been quite some time and no response yet.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11155
___
Erik Cederstrand e...@1calendar.dk added the comment:
I'm not sure if I was supposed to respond. The patch looks straight-forward to
me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11155
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11155
___
___
Erik Cederstrand e...@1calendar.dk added the comment:
Just checked on Python 2.7.1 with the same result. Test script attached.
--
Added file: http://bugs.python.org/file21459/q.py
___
Python tracker rep...@bugs.python.org
Changes by Erik Cederstrand e...@1calendar.dk:
--
versions: +Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11155
___
___
New submission from Erik Cederstrand e...@1calendar.dk:
In Python 2.6.6 on OSX:
import inspect
from multiprocessing import Queue
q = Queue()
print(inspect.getargspec(q.put))
ArgSpec(args=['self', 'obj', 'block', 'timeout'], varargs=None, keywords=None,
defaults=(True, None))
from Queue
Westley Martínez aniko...@gmail.com added the comment:
I've gone through Lib/multiproccing/queues.py and have replaced obj with item.
Here's the patch.
--
keywords: +patch
nosy: +anikom15
Added file: http://bugs.python.org/file20720/multiprocessing-11155.diff
15 matches
Mail list logo
