[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Senthil Kumaran added the comment: Updated the NEWS entry. -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mail

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Roundup Robot added the comment: New changeset 1b261f3bef09 by Senthil Kumaran in branch '2.7': Update NEWS for Issue11236. http://hg.python.org/cpython/rev/1b261f3bef09 -- ___ Python tracker _

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Roundup Robot added the comment: New changeset f799530dbde7 by Senthil Kumaran in branch '3.1': Update News entry for Issue11236 http://hg.python.org/cpython/rev/f799530dbde7 -- ___ Python tracker

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Senthil Kumaran added the comment: I have made the changes in 3.3,3.2,3.1 and 2.7 codeline. The behavior is aligned with the 2.5 (and earlier) behaviors. I cannot change this 2.6 because this is not a security issue to be back-ported. (rather it was misinterpreted problem and resulted in chan

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Roundup Robot added the comment: New changeset a3b4887edba4 by Senthil Kumaran in branch '2.7': issue11236 getpass.getpass to respond ctrl-c or ctrl-z http://hg.python.org/cpython/rev/a3b4887edba4 -- ___ Python tracker

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Roundup Robot added the comment: New changeset 154b323e0e7f by Senthil Kumaran in branch '3.1': Fix for issue11236 getpass.getpass to respond ctrl-c or ctrl-z http://hg.python.org/cpython/rev/154b323e0e7f -- ___ Python tracker

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Changes by Antoine Pitrou : -- nosy: -pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Martin v. Löwis added the comment: Greg: Can you please comment what the original motivation was for removing ISIG from the flags? This is your change, from issue 7208, AFAICT. -- nosy: +loewis ___ Python tracker

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Guido van Rossum added the comment: Is there any reason to assume this is not a bug? I think it should be fixed in all versions. -- nosy: +gvanrossum ___ Python tracker ___ ___

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Merlijn van Deen added the comment: @orsenthil > Close similarity with getpass.c 's behavior had lent some to support to this > change in 2.6. Changing now in older codeline has some chances of breaking > others code. > Someone who has been affected by this change in behavior should provide so

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Roundup Robot added the comment: New changeset c177faafec51 by Senthil Kumaran in branch 'default': issue11236 getpass.getpass to respond ctrl-c or ctrl-z http://hg.python.org/cpython/rev/c177faafec51 -- nosy: +python-dev ___ Python tracker

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Senthil Kumaran added the comment: Agree to removing of termios.ISIG so that we get a KeyBoardInterrupt exception raised when CNTL-C is pressed. Looking at discussion more carefully, it does not present any security risk. Should this be fixed in 3.3 only with NEWS detailing the change in beha

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Steffen Daode Nurpmeso added the comment: By the way, in another thread i've seen a link to issue960406, where Guido van Rossum states (in msg46074): Ideally, ^C should always cause the signal handler for SIGINT to be called, and the KeyboardInterrupt should be generated by the def

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Changes by Andrew Svetlov : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Steffen Daode Nurpmeso added the comment: The attached 11236.depend.patch updates Merlijn's patch so that it applies cleanly just in case the #11466.5.patch is used in the end. -- Added file: http://bugs.python.org/file21298/11236.depend.patch ___ P

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Éric Araujo added the comment: If this bugs needs to be solved before #11466 can be fixed, let’s mark it as a dependency. -- ___ Python tracker ___

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Changes by Éric Araujo : -- Removed message: http://bugs.python.org/msg130613 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Éric Araujo added the comment: Please do not mix issues. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Steffen Daode Nurpmeso added the comment: I do consider this as a bug, too (you hit ^C - and it doesn't help!)! I've opened #11466 due to a different problem, but since raising (the expected) KeyboardInterrupt would trigger that problem, too, i've included stripping termios.ISIG in file21081. -

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Merlijn van Deen added the comment: No, I do not, for several reasons. First of all, this is not a change *from* previous behaviour, but a change *back to* previous behaviour. And sensible behaviour, too. Secondly, I have tested what getpass does on windows (Python 2.7.1 (r271:86832, Nov 27

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Senthil Kumaran added the comment: I fail to see the bug here. Python's getpass.py is mimicing the behavior of getpass.c

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Éric Araujo added the comment: Patch fixes the bug for 3.2 on my Debian (Linux-2.6.32-5-amd64-x86_64-with-debian-wheezy-sid). getpass currently has no unit tests. -- ___ Python tracker _

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Merlijn van Deen added the comment: Linux-2.6.22.18-co-0.7.4-i686-with-Ubuntu-10.04-lucid (the 'on linux2' versions) and Solaris-2.10-i86pc-i386-32bit-ELF (the 'on sunos5'). -- ___ Python tracker

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Éric Araujo added the comment: BTW, on which platforms did you notice the bug? (python -m platform) -- ___ Python tracker ___ ___ Py

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Éric Araujo added the comment: Thanks for the patch. Someone will write a test and we’ll check that it works correctly on all supported platforms. -- keywords: +needs review nosy: +belopolsky, gregory.p.smith, p...@fodder.org.uk, pitrou stage: needs patch -> test needed _

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Merlijn van Deen added the comment: Sorry, I'm not going to run my patch through the entire test suite, I've got better things to do with my time than setting up a working python-development-test-bench. Especially for a one-line-revert. The result now is: valhallasw@dorthonion:~/src/pythonpa

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Éric Araujo added the comment: Thanks for the report. Would you like to contribute a patch? If so, guidelines are found at http://docs.python.org/devguide/ -- nosy: +eric.araujo ___ Python tracker _

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Changes by R. David Murray : -- nosy: +benjamin.peterson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Changes by Éric Araujo : -- stage: -> needs patch versions: +Python 3.2, Python 3.3 -Python 2.6 ___ Python tracker ___ ___ Python-bug

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

Merlijn van Deen added the comment: To allow people to cancel at the password prompt, we added a manual post-check. Although this check runs after return is pressed, it's better than nothing. Index: branches/rewrite/pywikibot/userinterfaces/terminal_interface.py ===

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

New submission from Merlijn van Deen : In python 2.5, entering ^C in a getpass prompt yields a KeyboardInterrupt. In later versions, nothing happens, and '\x03' is returned after pressing return. In python 2.5, entering ^Z in a getpass prompt suspends the process. In later versions, nothing hap