Steffen Daode Nurpmeso sdao...@googlemail.com added the comment:
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Please try to provide a patch which fixes (as in makes the test pass) this
specific issue only. As for other changes such as the code restyling you can
open a separate
Giampaolo Rodola' g.rod...@gmail.com added the comment:
issue11351-5.patch no longer applies cleanly and I don't have an OSX box to
test against at the moment.
Could you please update your patch? If you tell me it's gonna fix the test I'm
going to commit it assuming everything is fine.
Steffen Daode Nurpmeso sdao...@googlemail.com added the comment:
Giampaolo Rodola' g.rod...@gmail.com added the comment:
issue11351-5.patch no longer applies cleanly and I don't have an OSX box to
test against at the moment.
Could you please update your patch? If you tell me it's gonna
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +ned.deily
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11351
___
___
Python-bugs-list mailing
Steffen Daode Nurpmeso sdao...@googlemail.com added the comment:
It's ok, but for the statistics:
16:59 ~/arena/code.extern.repos/py3k.hg $ hg identify
e79364a6bed8 (py3k) tip
16:59 ~/arena/code.extern.repos/py3k.hg $ hg slog -r tip
Changeset: 10021:e79364a6bed8
branch: py3k
tag:
Giampaolo Rodola' g.rod...@gmail.com added the comment:
I'm at e79364a6bed8/[svn r88726].
issue11351-5.patch applies and the test is ok, at least in respect
to sendfile:
Sorry, I'm still not used to the whole svn/mercurial change.
I applied your patch in r88729.
Let's see how the buildbot
Steffen Daode Nurpmeso sdao...@googlemail.com added the comment:
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Let's see how the buildbot goes.
Italian Espressi are the best!
(Our local classical radio station plays Respighi's Pini di Roma
almost every day ...)
--
Giampaolo Rodola' g.rod...@gmail.com added the comment:
=)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11351
___
___
Python-bugs-list mailing
Steffen Daode Nurpmeso sdao...@googlemail.com added the comment:
Buildbot ok, i hope it's ok for you all
that i close this heavy-load issue.
More fun further on up the road ...
from a non-MQ user.
--
___
Python tracker rep...@bugs.python.org
Changes by Steffen Daode Nurpmeso sdao...@googlemail.com:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11351
___
___
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
resolution: - fixed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11351
___
___
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11351
___
___
Python-bugs-list
Ned Deily n...@acm.org added the comment:
Looks good to me and the test does now run successfully.
Note that sendfile() was introduced with OS X 10.5 so, like a number of other
similar calls, os.sendfile() will not be present on 32-bit-only OS X installer
builds which are built with a minimum
Steffen Daode Nurpmeso sdao...@googlemail.com added the comment:
I'm trashing your mailbox, but
http://bugs.python.org/file20949/issue11351-2.patch should do
'total+=blen' not 'total+=len'.
Anyway i attach yet a third patch which does some code cleanup in
general and is a bit more of my very
Antoine Pitrou pit...@free.fr added the comment:
Well the third patch has a lot of spurious style changes that make it harder to
spot the actual changes.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11351
Steffen Daode Nurpmeso sdao...@googlemail.com added the comment:
Aah, unfortunately - what a shame, this beautiful language ...
But do i need to re-post the real (ouch!) issue11351-2.patch, i.e. with
'total+=blen' instead of 'total+=len'?
Or is it sufficient now with these comments (for
Steffen Daode Nurpmeso sdao...@googlemail.com added the comment:
Maybe Giampaolo' should at least replace these two
PyArg_ParseTupleAndKeywords() near (unpatched) line 5942,
because doing it like this is messes up (at least) vim(1) group
detection, resulting in a lot of bold red mis-brace
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Please try to provide a patch which fixes (as in makes the test pass) this
specific issue only. As for other changes such as the code restyling you can
open a separate ticket with another patch.
--
Antoine Pitrou pit...@free.fr added the comment:
Maybe Giampaolo' should at least replace these two
PyArg_ParseTupleAndKeywords() near (unpatched) line 5942,
because doing it like this is messes up (at least) vim(1) group
detection, resulting in a lot of bold red mis-brace warnings
Steffen Daode Nurpmeso sdao...@googlemail.com added the comment:
So this is fixed -2.patch supplemented only with
PyArg_ParseTupleAndKeywords() fixed in a way that re-enables
correct syntax highlighting.
--
Added file: http://bugs.python.org/file20959/issue11351-4.patch
Steffen Daode Nurpmeso sdao...@googlemail.com added the comment:
(GMail imposes a five minute or so delay when used over SMTP, so
the timeline sometimes looks unfortunate.)
So, finally, -2.patch only fixed with 'blen' for 'len'.
Compiles and test ok.
Giampaolo Rodola' g.rod...@gmail.com added
Steffen Daode Nurpmeso sdao...@googlemail.com added the comment:
But, dear Antoine, i don't know *any* editor that is capable to
handle the following code correctly:
#ifdef __APPLE__
if (!PyArg_ParseTupleAndKeywords(args, kwdict, iiOO|OOi:sendfile,
keywords, out, in, _parse_off_t,
Changes by Steffen Daode Nurpmeso sdao...@googlemail.com:
Removed file: http://bugs.python.org/file20943/posixmodule.naive-apple-patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11351
___
Changes by Steffen Daode Nurpmeso sdao...@googlemail.com:
Removed file: http://bugs.python.org/file20946/issue11351.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11351
___
Changes by Steffen Daode Nurpmeso sdao...@googlemail.com:
Removed file: http://bugs.python.org/file20949/issue11351-2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11351
___
Antoine Pitrou pit...@free.fr added the comment:
But, dear Antoine, i don't know *any* editor that is capable to
handle the following code correctly:
#ifdef __APPLE__
if (!PyArg_ParseTupleAndKeywords(args, kwdict, iiOO|OOi:sendfile,
keywords, out, in, _parse_off_t, offset,
Steffen Daode Nurpmeso sdao...@googlemail.com added the comment:
I agree with that.
Antoine Pitrou pit...@free.fr added the comment:
If you are asking your editor to simply edit test, it should work fine.
--
___
Python tracker
Changes by Steffen Daode Nurpmeso sdao...@googlemail.com:
--
title: (test_os) os.sendfile() error - Mac OS X os.sendfile()
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11351
___
Antoine Pitrou pit...@free.fr added the comment:
Likely explanation is http://bugs.python.org/issue10882#msg129555.
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11351
Steffen Daode Nurpmeso sdao...@googlemail.com added the comment:
(But see msg12970. And the test runs fine with my patch applied.)
On Mon, Feb 28, 2011 at 02:17:46PM +, Antoine Pitrou wrote:
Antoine Pitrou pit...@free.fr added the comment:
Likely explanation is
Steffen Daode Nurpmeso sdao...@googlemail.com added the comment:
(Should have been msg129706, sorry.)
P.S.: yes, you're right.
But now: issue 10882 is on adding os.sendfile(), not on fixing
errors on os.sendfile(). ;-)
--
___
Python tracker
Antoine Pitrou pit...@free.fr added the comment:
Your patch is not cleaned up. There are strange things like:
+ret ^= ret;
(while would you xor an off_t?)
and
+do {off_t x = (*buf)[i].len;
+(*iov)[i].iov_len = x;
+ret += x;
+}
Steffen Daode Nurpmeso sdao...@googlemail.com added the comment:
Will this do? Otherwise feel free to adjust the patch the way
Python needs it, i'll learn from that, then, for possible future
things. (I need to go down now.)
On Mon, Feb 28, 2011 at 02:37:16PM +, Antoine Pitrou wrote:
Changes by Antoine Pitrou pit...@free.fr:
--
assignee: - giampaolo.rodola
nosy: +rosslagerwall
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11351
___
Steffen Daode Nurpmeso sdao...@googlemail.com added the comment:
This version uses Py_ssize_t for the lengths and seems to be more
Python-style beside that, too.
It compiles clean and the test is ok.
--
Added file: http://bugs.python.org/file20949/issue11351-2.patch
35 matches
Mail list logo
