[issue11437] IDLE crash on startup with typo in config-keys.cfg

Change by Tal Einat : -- nosy: -taleinat ___ Python tracker ___ ___ Python-bugs-list

[issue11437] IDLE crash on startup with typo in config-keys.cfg

Terry J. Reedy added the comment: Tal's comments from Rietveld review (see msg220391); 529: Does this have to be a separate, new Tk instance? Wouldn't a temporary widget under the current Tk be just as good? Creating a new Tk instance could take a relatively large amount of time time and

[issue11437] IDLE crash on startup with typo in config-keys.cfg

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue11437] IDLE crash on startup with typo in config-keys.cfg

Terry J. Reedy added the comment: I closed #25662 in favor of this. -- ___ Python tracker ___ ___

[issue11437] IDLE crash on startup with typo in config-keys.cfg

Terry J. Reedy added the comment: https://stackoverflow.com/questions/25750477/python-2-7-8-idle-will-not-open-on-mavericks -- because one of the two files has 'shift' instead of Shift. When I make a change in either file (with custom keys being used), the traceback ends slightly differently

[issue11437] IDLE crash on startup with typo in config-keys.cfg

Tal Einat added the comment: I don't think the patch should currently be committed. I agree with Terry: we should first fix the issue whereby the key config is read repeatedly. Given such a fix, the problematic known_invalid workaround in the patch would no longer be necessary. As a side

[issue11437] IDLE crash on startup with typo in config-keys.cfg

Mark Lawrence added the comment: @Roger, Andrew could you pick this up again? -- nosy: +BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11437 ___

[issue11437] IDLE crash on startup with typo in config-keys.cfg

Changes by Saimadhav Heblikar saimadhavhebli...@gmail.com: -- nosy: +sahutd ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11437 ___ ___

[issue11437] IDLE crash on startup with typo in config-keys.cfg

Terry J. Reedy added the comment: Mark, they are both inactive at the moment. There are a number of issue around configuration, especially key bindings. I think the whole process needs review and redoing. For instance, I understand Roger as saying that the problematical known-invalid list

[issue11437] IDLE crash on startup with typo in config-keys.cfg

Changes by Terry J. Reedy tjre...@udel.edu: -- stage: needs patch - patch review versions: +Python 3.4, Python 3.5 -Python 3.2, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11437

[issue11437] IDLE crash on startup with typo in config-keys.cfg

Andrew Svetlov andrew.svet...@gmail.com added the comment: I reproduced the bug. Roger Serwy, your patch looks working, but can you describe: 1. Why do you need `self.known_invalid` list? 2. Why do you always extend that list (`known_invalid` variable is just shared alias for

[issue11437] IDLE crash on startup with typo in config-keys.cfg

Roger Serwy roger.se...@gmail.com added the comment: Without the known_invalid list, each call to GetCurrentKeySet would cause an error message to appear. The effect of keeping track of these bad key bindings is that the user receives a notification only once about a particular bad key

[issue11437] IDLE crash on startup with typo in config-keys.cfg

Andrew Svetlov andrew.svet...@gmail.com added the comment: Ok -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11437 ___ ___ Python-bugs-list

[issue11437] IDLE crash on startup with typo in config-keys.cfg

Roger Serwy roger.se...@gmail.com added the comment: I just realized that if the user, for whatever reason, fixes a bad key binding and then rebinds it to the previously bad one, no error message would appear. This can occur if the user is switching between key sets where one key set contains

[issue11437] IDLE crash on startup with typo in config-keys.cfg

Andrew Svetlov andrew.svet...@gmail.com added the comment: You right. That was my concern. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11437 ___

[issue11437] IDLE crash on startup with typo in config-keys.cfg

Andrew Svetlov andrew.svet...@gmail.com added the comment: Roger, can you help me? What steps should I do to reproduce the issue? Pushing config from George.Dhoore into ~/.idlerc does nothing. IDLE starts fine as usual. -- ___ Python tracker

[issue11437] IDLE crash on startup with typo in config-keys.cfg

Roger Serwy roger.se...@gmail.com added the comment: Andrew, after placing config-keys.cfg into .idlerc, launch IDLE and change the key map to Xip's keyset. You'll get a traceback on the terminal when you click ok. -- ___ Python tracker

[issue11437] IDLE crash on startup with typo in config-keys.cfg

Changes by Andrew Svetlov andrew.svet...@gmail.com: -- assignee: - asvetlov nosy: +asvetlov ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11437 ___

[issue11437] IDLE crash on startup with typo in config-keys.cfg

Roger Serwy roger.se...@gmail.com added the comment: Attached is a patch against 3.3a0 to validate the active key set in the configuration handler. It validates each key binding and then presents a dialog with a list of incorrect keys if there are any. In developing this patch I found that

[issue11437] IDLE crash on startup with typo in config-keys.cfg

Terry J. Reedy tjre...@udel.edu added the comment: #13864 is a duplicate, where I mentioned the remedy of deleting the bad file. This is similar to #5707, but I am not sure if exactly the same. The patch there fixed one problem but not the bad key binding problem. -- nosy: +serwy

[issue11437] IDLE crash on startup with typo in config-keys.cfg

Terry J. Reedy tjre...@udel.edu added the comment: #13071 is another duplicate closed in favor of this. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11437 ___

[issue11437] IDLE crash on startup with typo in config-keys.cfg

Terry J. Reedy tjre...@udel.edu added the comment: I presume 'silently' means when starting with an icon or shortcut, so that there is no window left to contain the traceback. The standard key customization is by clicking, which makes errors impossible. How did you get the error? By using the

[issue11437] IDLE crash on startup with typo in config-keys.cfg

New submission from George Dhoore georgie...@gmail.com: If the user makes a typo when setting a custom keybind (in this case Alt-Key-up instead of Alt-Key-Up) IDLE will silently crash. From the command-line the error shows as: Traceback (most recent call last): File

[issue11437] IDLE crash on startup with typo in config-keys.cfg

Changes by Ned Deily n...@acm.org: -- nosy: +ned.deily stage: - needs patch type: crash - behavior versions: +Python 2.7, Python 3.1, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11437