[issue11503] Expand test coverage in posixpath

Roundup Robot added the comment: New changeset f11da6cecffd by Michael Foord in branch '3.2': Closes issue 11503. Improves test coverage of posixpath. http://hg.python.org/cpython/rev/f11da6cecffd -- nosy: +python-dev resolution: -> fixed stage: patch review -> committed/rejected statu

[issue11503] Expand test coverage in posixpath

Brian Curtin added the comment: Tested the patch on Windows -- all tests pass. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue11503] Expand test coverage in posixpath

Evan Dandrea added the comment: I haven't used addCleanup here, but have noted it for the future. In this case, using it would require adding another function to handle the reassignment, which I think is a bit more messy than the extra bit of indentation. -- ___

[issue11503] Expand test coverage in posixpath

Evan Dandrea added the comment: I've looked at the sameopenfile code, and can see no reason why it would not work on Windows. I've asked Brian to verify this. -- ___ Python tracker __

[issue11503] Expand test coverage in posixpath

Evan Dandrea added the comment: Updated the patch to address Michael's concerns. -- Added file: http://bugs.python.org/file21221/test_posixpath_with_same_device.patch ___ Python tracker __

[issue11503] Expand test coverage in posixpath

Michael Foord added the comment: Will posixpath.sameopenfile work on Windows? That may need skipping. -- ___ Python tracker ___ ___ P

[issue11503] Expand test coverage in posixpath

Michael Foord added the comment: Scratch the comment about symlink - in test_mount. I see you already protect that code with "if support.can_symlink()". -- ___ Python tracker _

[issue11503] Expand test coverage in posixpath

Michael Foord added the comment: Note that instead of try finally constructs you can create a cleanup function and call self.addCleanup(...). This reduces extra levels of indentation in your test code. In the new code in "test_ismount", from "# Non-existent mountpoint" on, I would turn this

[issue11503] Expand test coverage in posixpath

Michael Foord added the comment: The patch includes an unconditional "import posix" that will fail on Windows. posixpath is available on windows (although not *all* its functionality makes sense), so the whole test should not be skipped - but it is reasonable to skip just the new tests using

[issue11503] Expand test coverage in posixpath

Changes by Michael Foord : Removed file: http://bugs.python.org/file21122/test_posixpath.patch ___ Python tracker ___ ___ Python-bugs-list mai

[issue11503] Expand test coverage in posixpath

Changes by Michael Foord : Removed file: http://bugs.python.org/file21124/test_posixpath.patch ___ Python tracker ___ ___ Python-bugs-list mai

[issue11503] Expand test coverage in posixpath

Changes by Michael Foord : Removed file: http://bugs.python.org/file21125/test_posixpath_with_same_device.patch ___ Python tracker ___ ___ Py

[issue11503] Expand test coverage in posixpath

Changes by Brian Curtin : -- keywords: +needs review nosy: +brian.curtin stage: -> patch review ___ Python tracker ___ ___ Python-bug

[issue11503] Expand test coverage in posixpath

Evan Dandrea added the comment: It's probably best to give the fake stats inode numbers, so if the code does fail to check the st_dev fields, it will fail the test. I've updated the patch with this. -- Added file: http://bugs.python.org/file21128/test_posixpath_with_same_device.patc

[issue11503] Expand test coverage in posixpath

Evan Dandrea added the comment: Added an updated patch that includes testing whether ismount would succeed by faking path being on a different device from its parent. -- Added file: http://bugs.python.org/file21125/test_posixpath_with_same_device.patch ___

[issue11503] Expand test coverage in posixpath

Evan Dandrea added the comment: Fixed a typo in the previous patch. -- Added file: http://bugs.python.org/file21124/test_posixpath.patch ___ Python tracker ___ _

[issue11503] Expand test coverage in posixpath

Changes by Evan Dandrea : -- nosy: +michael.foord ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue11503] Expand test coverage in posixpath

New submission from Evan Dandrea : I've expanded the coverage of the posixpath test. The following scenarios have been added: - lexists with a non-existent file. - ismount with binary data. - ismount with a directory that is not a mountpoint. - ismount with a non-existent file. - ismount w