[issue1172711] long long support for array module

STINNER Victor added the comment: > New changeset 672b63aff0f4 by Meador Inge in branch 'default' Woops, I wrote the wrong module name. Thanks for fixing it. -- ___ Python tracker __

[issue1172711] long long support for array module

Roundup Robot added the comment: New changeset 672b63aff0f4 by Meador Inge in branch 'default': Issue #1172711: Update What's New in Python 3.3 document for the array module. http://hg.python.org/cpython/rev/672b63aff0f4 -- ___ Python tracker

[issue1172711] long long support for array module

Roundup Robot added the comment: New changeset 3c56e546dc60 by Victor Stinner in branch 'default': Issue #1172711: Update What's New in Python 3.3 document for the struct module http://hg.python.org/cpython/rev/3c56e546dc60 -- ___ Python tracker

[issue1172711] long long support for array module

Changes by Meador Inge : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ __

[issue1172711] long long support for array module

Roundup Robot added the comment: New changeset 15659e0e2b2e by Meador Inge in branch 'default': Issue #1172711: Add 'long long' support to the array module. http://hg.python.org/cpython/rev/15659e0e2b2e -- nosy: +python-dev ___ Python tracker

[issue1172711] long long support for array module

Mark Dickinson added the comment: Agreed. Commit first; worry about __int__ and __index__ later. -- ___ Python tracker ___ ___ Py

[issue1172711] long long support for array module

Stefan Krah added the comment: > I am OK with applying the fix for this issue first. I also think this should be committed first. -- ___ Python tracker ___ __

[issue1172711] long long support for array module

STINNER Victor added the comment: @meadori: please write the version of your patch directly in the filename. For example, I use the pattern: name.patch, name-2.patch, name-3.patch, ... -- ___ Python tracker ___

[issue1172711] long long support for array module

Meador Inge added the comment: Updated patch with the 'Py_ssize_t' fixes. -- Added file: http://bugs.python.org/file23148/issue-1172711.patch ___ Python tracker ___ __

[issue1172711] long long support for array module

Meador Inge added the comment: > Okay, understood.  But the new 'long long' support provided by this patch > still allows for __int__-based duck typing, right? Yes, but ... > That's the new duck typing I meant.  I see this acceptance of things with an > __int__ method as a mistake, and my gu

[issue1172711] long long support for array module

Mark Dickinson added the comment: > Mark, just to clarify a bit, the behavior is already there in the array module Okay, understood. But the new 'long long' support provided by this patch still allows for __int__-based duck typing, right? >>> array('Q', [1, 2, Decimal(3.2)]) array('Q', [1, 2

[issue1172711] long long support for array module

Meador Inge added the comment: > Yes, please let's not add any new __int__-based duck typing here; Mark, just to clarify a bit, the behavior is already there in the array module (by way of 'PyLong_AsLong'). The fact that it is there was picked up on a code review for this issue. Anyway, I t

[issue1172711] long long support for array module

Mark Dickinson added the comment: Yes, please let's not add any new __int__-based duck typing here; IMO, we should be moving away from such uses of __int__. I'd be fine with __index__ based duck-typing. -- ___ Python tracker

[issue1172711] long long support for array module

Changes by Mark Dickinson : -- versions: +Python 3.3 -Python 3.2 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue1172711] long long support for array module

Meador Inge added the comment: import array, struct a = array.array('L', [1,2,3]) class T(object): > ...     def __init__(self, value): > ...         self.value = value > ...     def __int__(self): > ...          return self.value > ... a = array.array('L', [1,2,3]) stru

[issue1172711] long long support for array module

Stefan Krah added the comment: I made the observation on Rietveld that the following code is never executed by the test suite. The same applies to similar existing passages in arraymodule.c: http://bugs.python.org/review/1172711/diff/3310/10310#newcode394 Meador correctly pointed out that the

[issue1172711] long long support for array module

Stefan Krah added the comment: I left some remarks on Rietveld. -- nosy: +skrah ___ Python tracker ___ ___ Python-bugs-list mailing

[issue1172711] long long support for array module

Meador Inge added the comment: Victor, I like the decorator approach much better. Thanks. Attached is a new patch with that update. -- ___ Python tracker ___ __

[issue1172711] long long support for array module

Changes by Meador Inge : Added file: http://bugs.python.org/file23121/issue-1172711.patch ___ Python tracker ___ ___ Python-bugs-list mailin

[issue1172711] long long support for array module

STINNER Victor added the comment: +if have_long_long: +class LongLongTest(SignedNumberTest): +... It is maybe better to use @unittest.skipIf(not have_long_long, 'need long long support'). Except of this nit, the patch looks correct. -- nosy: +haypo ___

[issue1172711] long long support for array module

Changes by Armin Rigo : -- nosy: -arigo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue1172711] long long support for array module

Meador Inge added the comment: Here is a refresh of this patch for 3.3. Please review. -- Added file: http://bugs.python.org/file23100/issue-1172711.patch ___ Python tracker

[issue1172711] long long support for array module

Matt Chaput added the comment: This is an important feature to me. Now I get to redo a bunch of code to have two completely different code paths to do the same thing because nobody could be bothered to keep array up-to-date. -- nosy: +mattchaput __

[issue1172711] long long support for array module

Meador Inge added the comment: Overall the patch looks good. I don't think it is an extremely important feature, but similar support is already available in other places (e.g. 'struct', 'ctypes'). Here is a patch updated for py3k with some minor additions: (1) Fixed some doc inconsistenc

[issue1172711] long long support for array module

Changes by Meador Inge : -- nosy: +minge ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue1172711] long long support for array module

Changes by Senthil Kumaran : -- versions: +Python 3.2 -Python 2.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue1172711] long long support for array module

Mark Dickinson added the comment: BTW, the PyLong_AsUnsignedLongLong BadInternalCall has long since disappeared. I agree with Armin Rigo that the conversion functions in longobject.c are a mess, though (and also that cleanup is difficult). -- ___

[issue1172711] long long support for array module

Mark Dickinson added the comment: Seems like a reasonable addition to me. Anyone feel like refreshing the patch so that it applies to py3k? -- nosy: +mark.dickinson ___ Python tracker _

[issue1172711] long long support for array module

Craig McQueen added the comment: So it looks as though this isn't going in to Python 2.7. How about 3.x? -- nosy: +cmcqueen1975 ___ Python tracker ___ ___

[issue1172711] long long support for array module

Changes by Hirokazu Yamamoto : Removed file: http://bugs.python.org/file14438/array_long_long.patch ___ Python tracker ___ ___ Python-bugs-l

[issue1172711] long long support for array module

Changes by Hirokazu Yamamoto : Added file: http://bugs.python.org/file14439/array_long_long.patch ___ Python tracker ___ ___ Python-bugs-lis

[issue1172711] long long support for array module

Hirokazu Yamamoto added the comment: How about this patch? I haven't tested so intensely, but testcase seems working. -- nosy: +ocean-city Added file: http://bugs.python.org/file14438/array_long_long.patch ___ Python tracker

[issue1172711] long long support for array module

Changes by Daniel Diniz : -- components: +Extension Modules -Library (Lib) stage: -> test needed type: -> feature request versions: +Python 2.7 -Python 2.5 ___ Python tracker ___