[issue11754] Changed test to check calculated constants in test_string.py

Terry J. Reedy added the comment: Three years later, I do understand 'circular'. Such cut-and-paste whitebox tests tend to simultaneously test too much -- the particular implementation(1) -- and too little -- the actual specification(2). (1) The test would falsely fail if a string were reorder

[issue11754] Changed test to check calculated constants in test_string.py

Mark Lawrence added the comment: I see very little value in implementing this change, thoughts? -- nosy: +BreamoreBoy versions: +Python 2.7, Python 3.4, Python 3.5 -Python 3.3 ___ Python tracker ___

[issue11754] Changed test to check calculated constants in test_string.py

Terry J. Reedy added the comment: I do not understand 'circular'. The change is from 'attribute exists' to 'attribute has correct value'. If any are changed, I would think all should be changed. -- nosy: +terry.reedy ___ Python tracker

[issue11754] Changed test to check calculated constants in test_string.py

Benjamin Peterson added the comment: Being rather circular, that doesn't seem to be a particularly useful test. (Not that the original is either.) It'd be more "correct" if you actually tested that hex numbers are contained within string.hexdigits, for example. -- nosy: +benjamin.pete

[issue11754] Changed test to check calculated constants in test_string.py

Changes by Brian Curtin : -- nosy: +brian.curtin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue11754] Changed test to check calculated constants in test_string.py

Joel Luellwitz added the comment: Make a slight change to diff file. -- nosy: +JoelLuellwitz Added file: http://bugs.python.org/file21521/test_calculated_constants.diff ___ Python tracker _

[issue11754] Changed test to check calculated constants in test_string.py

New submission from Lynne Qu : Changed test to check calculated constants in test_string.py -- components: Tests files: test_calculated_constants.diff keywords: patch messages: 132874 nosy: Lynne.Qu priority: normal severity: normal status: open title: Changed test to check calculated co