[issue11754] Check calculated constants in test_string.py

2015-04-13 Thread R. David Murray
R. David Murray added the comment: Thanks, Chalmer. Hopefully Benjamin won't be too annoyed by these :) -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed versions: -Python 2.7, Python 3.4 ___ Python tracker

[issue11754] Check calculated constants in test_string.py

2015-04-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset e1457e9f340f by R David Murray in branch 'default': #11754: test contents of string module attributes. https://hg.python.org/cpython/rev/e1457e9f340f -- nosy: +python-dev ___ Python tracker

[issue11754] Check calculated constants in test_string.py

2015-04-13 Thread chalmer_lowe
chalmer_lowe added the comment: Based on review comments, in order to reduce unnecessary redundancy in the tests: - composed later strings from previously defined substrings, where it made sense to do so. -- Added file: http://bugs.python.org/file38975/issue11754_patch_2.txt _

[issue11754] Check calculated constants in test_string.py

2015-04-13 Thread R. David Murray
R. David Murray added the comment: Added a review comment. -- nosy: +r.david.murray ___ Python tracker ___ ___ Python-bugs-list mailin

[issue11754] Check calculated constants in test_string.py

2015-04-13 Thread chalmer_lowe
chalmer_lowe added the comment: Discussed with David Murray at PyCon Sprints 2015. Considered the fact that to preserve backwards compatibility, it seems important that rather than a) merely checking for the presence of each constant string (as the test does now) OR b) checking for each desired

[issue11754] Check calculated constants in test_string.py

2014-06-27 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- title: Changed test to check calculated constants in test_string.py -> Check calculated constants in test_string.py ___ Python tracker ___ ___