[issue11939] Implement stat.st_dev and os.path.samefile on windows

Brian Curtin added the comment: Backed out the changeset. If you have a solution, feel free to fix it. -- ___ Python tracker ___ ___ P

[issue11939] Implement stat.st_dev and os.path.samefile on windows

Serhiy Storchaka added the comment: Now the code is wrong on non-Windows without PY_LONG_LONG and with signed st_dev. -- ___ Python tracker ___ _

[issue11939] Implement stat.st_dev and os.path.samefile on windows

Roundup Robot added the comment: New changeset 61bada808b34 by Brian Curtin in branch 'default': Set st_dev on Windows as unsigned long to match its DWORD type, related to the change to fix #11939. http://hg.python.org/cpython/rev/61bada808b34 -- ___

[issue11939] Implement stat.st_dev and os.path.samefile on windows

Serhiy Storchaka added the comment: > New changeset 3738d270c54a by Brian Curtin in branch 'default': > st_dev/st_rdev should be unsigned long as dwVolumeSerialNumber, which it is > set to, is a DWORD. This was fixed in #11939 and the overflow was > mentioned in #10657 and seen by me on some mach

[issue11939] Implement stat.st_dev and os.path.samefile on windows

Roundup Robot added the comment: New changeset 3738d270c54a by Brian Curtin in branch 'default': st_dev/st_rdev should be unsigned long as dwVolumeSerialNumber, which it is set to, is a DWORD. This was fixed in #11939 and the overflow was mentioned in #10657 and seen by me on some machines. htt

[issue11939] Implement stat.st_dev and os.path.samefile on windows

Brian Curtin added the comment: Separate issue. Fixed in #16788. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue11939] Implement stat.st_dev and os.path.samefile on windows

Serhiy Storchaka added the comment: Try on Windows: >>> import os >>> from os.path import * >>> samestat(os.stat('.'), os.stat('.')) Traceback (most recent call last): File "", line 1, in NameError: name 'samestat' is not defined -- ___ Python tra

[issue11939] Implement stat.st_dev and os.path.samefile on windows

Roundup Robot added the comment: New changeset 9e980454b85e by Brian Curtin in branch 'default': Add tests for Issue #10646. http://hg.python.org/cpython/rev/9e980454b85e -- ___ Python tracker _

[issue11939] Implement stat.st_dev and os.path.samefile on windows

Brian Curtin added the comment: Thanks for the reviews. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ _

[issue11939] Implement stat.st_dev and os.path.samefile on windows

Roundup Robot added the comment: New changeset 82531b78b719 by Brian Curtin in branch 'default': Add NEWS entry for fixing #11939 http://hg.python.org/cpython/rev/82531b78b719 -- ___ Python tracker

[issue11939] Implement stat.st_dev and os.path.samefile on windows

Roundup Robot added the comment: New changeset 189b21f9bc0c by Brian Curtin in branch 'default': Fix #11939. Set st_dev attribute on Windows to simplify os.path.samefile. http://hg.python.org/cpython/rev/189b21f9bc0c -- nosy: +python-dev ___ Python tr

[issue11939] Implement stat.st_dev and os.path.samefile on windows

Brian Curtin added the comment: Docs and the __all__ changes in V3 patch. -- Added file: http://bugs.python.org/file28430/issue11939_v3.diff ___ Python tracker ___ __

[issue11939] Implement stat.st_dev and os.path.samefile on windows

Serhiy Storchaka added the comment: On other hand, you should add "samefile", "sameopenfile" and "samestat" back to __all__ in posixpath and ntpath. __all__ is a list of exported names, not a list of defined names. -- ___ Python tracker

[issue11939] Implement stat.st_dev and os.path.samefile on windows

Serhiy Storchaka added the comment: Hmm. test_macpath will now run the tests for samefile etc. macpath doesn't contain os.path.samefile. But in Modules/posixmodule.c I don't see any special cases for classic MacOS. Actually, I don't know how tests behave on classic MacOS. Please update the do

[issue11939] Implement stat.st_dev and os.path.samefile on windows

Brian Curtin added the comment: Here is an updated patch addressing the sameopenfile that remained in Lib/ntpath.py, thanks to Sehriy's comment on the review. -- Added file: http://bugs.python.org/file28429/issue11939_v2.diff ___ Python tracker

[issue11939] Implement stat.st_dev and os.path.samefile on windows

Brian Curtin added the comment: Why do you think that? I don't have a mac so I can't test it. -- ___ Python tracker ___ ___ Python-bug

[issue11939] Implement stat.st_dev and os.path.samefile on windows

Serhiy Storchaka added the comment: What about macpath? I think test_macpath will fail. -- nosy: +serhiy.storchaka versions: +Python 3.4 -Python 3.3 ___ Python tracker ___ __

[issue11939] Implement stat.st_dev and os.path.samefile on windows

Brian Curtin added the comment: Here's a patch that fills st_dev, and while we're at it st_rdev (which is the same value). I've moved the implementation of samefile/sameopenfile/samestat from Lib/posixpath.py over to Lib/genericpath.py and then removed the implementation from Lib/ntpath.py, s

[issue11939] Implement stat.st_dev and os.path.samefile on windows

Brian Curtin added the comment: I created/assigned #10646 to myself for other samefile issues - I can cover this as well unless someone beats me to it. -- assignee: -> brian.curtin nosy: +brian.curtin stage: -> needs patch versions: +Python 3.3 __

[issue11939] Implement stat.st_dev and os.path.samefile on windows

New submission from Amaury Forgeot d'Arc : Since 9cd1036455e7, os.stat() on Windows fills the st_ino member; it could fill st_dev just as easily; then os.path.samefile() could be shared with the posix implementation. -- components: Windows messages: 134595 nosy: amaury.forgeotdarc priori