[issue12106] reflect syntatic sugar in with ast

2011-05-28 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc amaur...@gmail.com added the comment: Does this change have a visible effect? If so, can it have some unit test? Otherwise pypy and other alternative implementations are likely to miss this change. -- nosy: +amaury.forgeotdarc

[issue12106] reflect syntatic sugar in with ast

2011-05-28 Thread Amaury Forgeot d'Arc
Changes by Amaury Forgeot d'Arc amaur...@gmail.com: -- status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12106 ___ ___

[issue12106] reflect syntatic sugar in with ast

2011-05-28 Thread Nick Coghlan
Nick Coghlan ncogh...@gmail.com added the comment: The AST version changed, and, more importantly, if other implementations pick up our AST changes without updating their compilers accordingly, their symbol table analysis and code compilation processes will break. So yes, the test suite does

[issue12106] reflect syntatic sugar in with ast

2011-05-28 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc amaur...@gmail.com added the comment: Thanks for this answer. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12106 ___ ___

[issue12106] reflect syntatic sugar in with ast

2011-05-28 Thread Nick Coghlan
Nick Coghlan ncogh...@gmail.com added the comment: One other thing I should mention is that in a later checkin, Benjamin did add a couple of explicit with statement examples to test_ast. These will fail if other implementations don't update the front end of their compilation processes

[issue12106] reflect syntatic sugar in with ast

2011-05-28 Thread Ezio Melotti
Ezio Melotti ezio.melo...@gmail.com added the comment: That would be c4ddb460f4f2. -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12106 ___

[issue12106] reflect syntatic sugar in with ast

2011-05-27 Thread Roundup Robot
Roundup Robot devnull@devnull added the comment: New changeset 9b11cc4e2918 by Benjamin Peterson in branch 'default': reflect with statements with multiple items in the AST (closes #12106) http://hg.python.org/cpython/rev/9b11cc4e2918 -- nosy: +python-dev resolution: - fixed stage: -

[issue12106] reflect syntatic sugar in with ast

2011-05-24 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: Here is an improved patch. Sans comments, I will apply in a few days. -- Added file: http://bugs.python.org/file22100/fixwith2.patch ___ Python tracker rep...@bugs.python.org

[issue12106] reflect syntatic sugar in with ast

2011-05-24 Thread Nick Coghlan
Nick Coghlan ncogh...@gmail.com added the comment: Just to articulate the rationale, I'm guessing the reasoning behind this is to make it feasible for source-AST-source translators to retain the original grouping? -- ___ Python tracker

[issue12106] reflect syntatic sugar in with ast

2011-05-24 Thread Nick Coghlan
Nick Coghlan ncogh...@gmail.com added the comment: Visual scan of the patch in Reitveld looks fine to me. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12106 ___

[issue12106] reflect syntatic sugar in with ast

2011-05-24 Thread Benjamin Peterson
Benjamin Peterson benja...@python.org added the comment: 2011/5/24 Nick Coghlan rep...@bugs.python.org: Nick Coghlan ncogh...@gmail.com added the comment: Just to articulate the rationale, I'm guessing the reasoning behind this is to make it feasible for source-AST-source translators to

[issue12106] reflect syntatic sugar in with ast

2011-05-18 Thread Benjamin Peterson
New submission from Benjamin Peterson benja...@python.org: This patch causes multiple with statements with multiple with items to be represented in the AST instead of flattened as currently happens. -- components: Interpreter Core files: fixwith.patch keywords: patch messages: 136262