[issue12199] Unify TryExcept and TryFinally

2011-05-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset e0e663132363 by Benjamin Peterson in branch 'default': unify TryExcept and TryFinally (closes #12199) http://hg.python.org/cpython/rev/e0e663132363 -- nosy: +python-dev resolution: -> fixed stage: -> committed/rejected status: open -> clo

[issue12199] Unify TryExcept and TryFinally

2011-05-29 Thread Nick Coghlan
Nick Coghlan added the comment: Looks good to me. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue12199] Unify TryExcept and TryFinally

2011-05-28 Thread Benjamin Peterson
Benjamin Peterson added the comment: Thanks for the review. New patch. -- Added file: http://bugs.python.org/file22170/try2.patch ___ Python tracker ___

[issue12199] Unify TryExcept and TryFinally

2011-05-28 Thread Nick Coghlan
Nick Coghlan added the comment: >From my review: """One genuine problem with a stale assert and comment in ast.c, and a small objection to style in compile.c (I'd like a new compile_try() function to match the new AST node). Otherwise looked good in a desk review.""" -- ___

[issue12199] Unify TryExcept and TryFinally

2011-05-27 Thread Benjamin Peterson
New submission from Benjamin Peterson : You can write them as one compound statement in Python, so there's no point in having two ast classes. -- components: Interpreter Core files: try.patch keywords: patch messages: 137097 nosy: benjamin.peterson, ncoghlan priority: normal severity: n